[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604236#comment-16604236 ] 

ASF GitHub Bot commented on CB-12774:
-------------------------------------

janpio commented on issue #602: CB-12774 : Don't munge scoped plugin IDs anymore. Comment requested.
URL: https://github.com/apache/cordova-lib/pull/602#issuecomment-418679124
 
 
   @tobilarscheid This PR has a failing test on Windows:
   
   ```
   Failures:
   1) plugin end-to-end Test 013 : should be able to add and remove scoped npm packages without screwing up everything
     Message:
       Expected Plugin "@testscope/cordova-lib-test-plugin-scoped" is not present in the project. See `cordova plugin list`. to be undefined.
     Stack:
       Error: Expected Plugin "@testscope/cordova-lib-test-plugin-scoped" is not present in the project. See `cordova plugin list`. to be undefined.
           at C:\projects\cordova-lib\integration-tests\plugin.spec.js:329:29
           at _rejected (C:\projects\cordova-lib\node_modules\q\q.js:797:24)
           at C:\projects\cordova-lib\node_modules\q\q.js:823:30
           at Promise.when (C:\projects\cordova-lib\node_modules\q\q.js:1035:31)
   ```
   
   Also unfortunately the branch is now also conflicted and has to be rebased. Could you take care of that @akdor1154 please? Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> cordova plugin add doesn't support scoped packages from private registries
> --------------------------------------------------------------------------
>
>                 Key: CB-12774
>                 URL: https://issues.apache.org/jira/browse/CB-12774
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-lib
>    Affects Versions: 1.1.0
>            Reporter: Enrico Mazzucchelli
>            Assignee: Raphael
>            Priority: Major
>              Labels: cordova-8.0.0
>             Fix For: 1.1.1
>
>
> STEP TO REPRODUCE:
> 1) setup a private repo (for example sinopia with docker: https://github.com/kfatehi/docker-sinopia)
> 2) add scope in your npm config:  npm config set @myco:registry http://0.0.0.0:4873/
> 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in plugin.xml set plugin id: @myco/my.co.plugin.demo.
> 3) publish plugin in your private repo:
>     - npm set registry http://0.0.0.0:4873
>     - npm publish
>    -  npm set registry https://registry.npmjs.org/
> 4) in your cordova project dir, exec:
>     cordova plugin add @myco/my.co.plugin.demo
> EXPECTED BEHAVIOR:
>   cordova plugin are installed 
> ACTUAL BEHAVIOR:
>   cordova installation failed:
>   Error: Failed to fetch plugin my.co.plugin.demo via registry.
>   Probably this is either a connection problem, or plugin spec is incorrect.
>   Check your connection and plugin name/version/URL.
>   Error: npm: Command failed with exit code 1 Error output:
>   npm ERR! code E404
>   npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/my.co.plugin.demo
>   npm ERR! 404 
>   npm ERR! 404  'com.vipera.de.foundation.commons' is not in the npm registry.
>   npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
>   npm ERR! 404 
>   npm ERR! 404 Note that you can also install from a
>   npm ERR! 404 tarball, folder, http url, or git url.
> However node module are correctly installed (verified with npm ls) and fetch.json have a new entry with key
> @my.co.plugin.demo.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org