You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/04/30 00:51:51 UTC
[Impala-ASF-CR] Revert "IMPALA-7971: Add support for insert events in event processor."
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13182
Change subject: Revert "IMPALA-7971: Add support for insert events in event processor."
......................................................................
Revert "IMPALA-7971: Add support for insert events in event processor."
This reverts commit 15a33d1baaf4723794e52825a5c4082ff7487507.
Change-Id: Iec886d5d0d66320e89f12a5032dbea1b1cca92b3
---
M be/src/service/client-request-state.cc
M common/thrift/CatalogService.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M fe/src/test/resources/hive-site.xml.py
D tests/custom_cluster/test_event_processing.py
10 files changed, 13 insertions(+), 592 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/13182/1
--
To view, visit http://gerrit.cloudera.org:8080/13182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec886d5d0d66320e89f12a5032dbea1b1cca92b3
Gerrit-Change-Number: 13182
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-7971: Add support for insert events in event processor."
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has abandoned this change. ( http://gerrit.cloudera.org:8080/13182 )
Change subject: Revert "IMPALA-7971: Add support for insert events in event processor."
......................................................................
Abandoned
Abandoning this CR since the fix has been merged instead: https://gerrit.cloudera.org/c/13184/
--
To view, visit http://gerrit.cloudera.org:8080/13182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iec886d5d0d66320e89f12a5032dbea1b1cca92b3
Gerrit-Change-Number: 13182
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-7971: Add support for insert events in event processor."
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13182 )
Change subject: Revert "IMPALA-7971: Add support for insert events in event processor."
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec886d5d0d66320e89f12a5032dbea1b1cca92b3
Gerrit-Change-Number: 13182
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 00:52:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-7971: Add support for insert events in event processor."
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13182 )
Change subject: Revert "IMPALA-7971: Add support for insert events in event processor."
......................................................................
Patch Set 1:
Maybe we should just substitute 'getRelativePath' -> 'getFileName' in the added code to fix the compile error? I'll put up a gerrit for that.
--
To view, visit http://gerrit.cloudera.org:8080/13182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec886d5d0d66320e89f12a5032dbea1b1cca92b3
Gerrit-Change-Number: 13182
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 02:47:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-7971: Add support for insert events in event processor."
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13182 )
Change subject: Revert "IMPALA-7971: Add support for insert events in event processor."
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4109/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec886d5d0d66320e89f12a5032dbea1b1cca92b3
Gerrit-Change-Number: 13182
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 00:53:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-7971: Add support for insert events in event processor."
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13182 )
Change subject: Revert "IMPALA-7971: Add support for insert events in event processor."
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2987/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13182
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec886d5d0d66320e89f12a5032dbea1b1cca92b3
Gerrit-Change-Number: 13182
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 01:14:29 +0000
Gerrit-HasComments: No