[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

["Dave (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864255#action_12864255 ] 

Dave commented on MYFACES-2618:
-------------------------------

In our case, one such warning is about 2.5K. The component path is very long. 
We redirect warning to a log file. so the warnings will explode disk space after running for a few days. We hope that there is a parameter in faces-config.xml for keeping the warning silent.

>>>-------------
Now, for the AJAX case: if nothing is submitted, why would you run the decoding for this field? That sounds a bit strange to me. You might decide to execute only some of the fields, but then you would also submit these fields - a split between submitting some and decoding some others is nothing which I would see as being useful.
>>>----------

For ajax, we send ajax request with parameters(name/value pairs) for submitted values. For submitted values:

clientId_1=value1
clientId_2=value2

If the form has clientId_3, but no value is submitted for clientId_3, then there will be no parameter for clientId_3.  The decode() method should not be called for clientId_3.  Is it called?  If it is called but no submitted value, the decode method should ignore it without any warning.






> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.