You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Lieven Govaerts <lg...@mobsol.be> on 2006/11/04 13:00:38 UTC

[PATCH] Prepare the Windows installer scripts for svn 1.4.2

Since svn 1.4.2 is about to be released, I started fixing the Windows
installer in accordance to the list of remarks I sent to this list some
time ago:
http://svn.haxx.se/dev/archive-2006-09/0504.shtml

Changes:
- The windows .zip packages now include a licenses folder containing the
license files for all our dependencies, like apr, neon & bdb (thanks djh).
- Attached patch to the installer scripts will include this licenses
folder in the installer. It also copies the Subversion license file to
that folder.
- The layout of the COPYING file (the svn license) was fixed on trunk in
r19842, I nominated it for backport to 1.4.x.

- If attached patch is approved, I'll also nominate r21516 and r22155
(some typos and copyright years) + this patch for backport to 1.4.x.

Lieven

[[[
Add license files of Subversion and the included libraries in
the Windows installer.

* packages/windows-innosetup/svn.iss
  Create a licenses folder in the output path and Start menu in
  which we put the license files of Subversion and all included
  libraries.

* packages/windows-innosetup/templates/svn_dynamics.iss
  Define path to licenses folder
]]]


RE: SPAM-LOW: Re: [PATCH] Prepare the Windows installer scripts for svn 1.4.2

Posted by Troy Simpson <tr...@ebswift.com>.
Thankyou Lieven,

I will review the installer patches as soon as I get a chance.


Troy
 

-----Original Message-----
From: Lieven Govaerts [mailto:lgo@mobsol.be] 
Sent: Monday, 6 November 2006 12:49 AM
To: Branko Čibej
Cc: Subversion Developers; Troy Simpson
Subject: SPAM-LOW: Re: [PATCH] Prepare the Windows installer scripts for svn
1.4.2

Branko Čibej wrote:
> Lieven Govaerts wrote:
>> Since svn 1.4.2 is about to be released, I started fixing the Windows 
>> installer in accordance to the list of remarks I sent to this list 
>> some time ago:
>> http://svn.haxx.se/dev/archive-2006-09/0504.shtml
>>   
> 
> Looks good to me, +1.
> 
> -- Brane
> 

Thanks for the review, committed in r22224.

Lieven.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: [PATCH] Prepare the Windows installer scripts for svn 1.4.2

Posted by Lieven Govaerts <lg...@mobsol.be>.
Branko Čibej wrote:
> Lieven Govaerts wrote:
>> Since svn 1.4.2 is about to be released, I started fixing the Windows
>> installer in accordance to the list of remarks I sent to this list some
>> time ago:
>> http://svn.haxx.se/dev/archive-2006-09/0504.shtml
>>   
> 
> Looks good to me, +1.
> 
> -- Brane
> 

Thanks for the review, committed in r22224.

Lieven.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Prepare the Windows installer scripts for svn 1.4.2

Posted by Branko Čibej <br...@xbc.nu>.
Lieven Govaerts wrote:
> Since svn 1.4.2 is about to be released, I started fixing the Windows
> installer in accordance to the list of remarks I sent to this list some
> time ago:
> http://svn.haxx.se/dev/archive-2006-09/0504.shtml
>
> Changes:
> - The windows .zip packages now include a licenses folder containing the
> license files for all our dependencies, like apr, neon & bdb (thanks djh).
> - Attached patch to the installer scripts will include this licenses
> folder in the installer. It also copies the Subversion license file to
> that folder.
> - The layout of the COPYING file (the svn license) was fixed on trunk in
> r19842, I nominated it for backport to 1.4.x.
>
> - If attached patch is approved, I'll also nominate r21516 and r22155
> (some typos and copyright years) + this patch for backport to 1.4.x.
>
> Lieven
>
> [[[
> Add license files of Subversion and the included libraries in
> the Windows installer.
>
> * packages/windows-innosetup/svn.iss
>   Create a licenses folder in the output path and Start menu in
>   which we put the license files of Subversion and all included
>   libraries.
>
> * packages/windows-innosetup/templates/svn_dynamics.iss
>   Define path to licenses folder
> ]]]
>   

Looks good to me, +1.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org