You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/14 07:40:49 UTC

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1261: bugfix: 'required' should same level as `properties`, added test case.

membphis commented on a change in pull request #1261: bugfix: 'required' should same level as `properties`, added test case.
URL: https://github.com/apache/incubator-apisix/pull/1261#discussion_r392565529
 
 

 ##########
 File path: lua/apisix/plugins/grpc-transcode.lua
 ##########
 @@ -66,12 +61,14 @@ local schema = {
             type        = "number",
             default     = 0
         },
-        pb_option = { type = "array",
-                      items = { type="string", anyOf = pb_option_def },
-                      minItems = 1,
-                    },
-    requried = { "proto_id", "service", "method" },
-    additionalProperties = true }
+        pb_option = {
+            type = "array",
+            items = { type="string", anyOf = pb_option_def },
 
 Review comment:
   will fix it later

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services