[GitHub] [maven] michael-o commented on a change in pull request #678: [MNG-7244] Ignore pom.-prefix in expressions

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #678:
URL: https://github.com/apache/maven/pull/678#discussion_r808406484



##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/interpolation/AbstractStringBasedModelInterpolator.java
##########
@@ -189,7 +187,7 @@ public Object getValue( String expression )
         if ( projectDir != null )
         {
             processors.add( new PathTranslatingPostProcessor( PROJECT_PREFIXES, TRANSLATED_PATH_EXPRESSIONS,
-                                                              projectDir, pathTranslator ) );
+                    projectDir, pathTranslator ) );

Review comment:
       This should not have happened.

##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/interpolation/ProblemDetectingValueSource.java
##########
@@ -60,12 +68,12 @@ public Object getValue( String expression )
 
         if ( value != null && expression.startsWith( bannedPrefix ) )
         {
-            String msg = "The expression ${" + expression + "} is deprecated.";
+            String msg = "The expression ${" + expression + "} is " + status + ".";

Review comment:
       Why do we need this now? I mean `pom.` is gone and such an occurency should be treated as opaque and will not be touched at ll. It will remain as a placeholder in the effective model.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org