You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sankalpsthakur (via GitHub)" <gi...@apache.org> on 2026/08/13 07:38:33 UTC
[PR] Fix KubernetesPodOperator succeeding after SIGTERM/on_kill interrupt [airflow]
sankalpsthakur opened a new pull request, #71533:
URL: https://github.com/apache/airflow/pull/71533
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
When KubernetesExecutor task pods and KubernetesPodOperator child pods are interrupted together (spot drain / dual SIGTERM), the task instance was finalized as SUCCESS even though the child never finished.
Root cause: `task_runner` SIGTERM handling calls `on_kill()`, which sets `_killed` and deletes the child. `cleanup()` then returned immediately so `execute()` completed normally. The supervisor records SUCCESS for a 0-exit with no terminal-state message. Interrupting only the child still failed (404 / PodFailed) because `on_kill()` never ran.
This does not revert #69034 (warm-shutdown supervisor). SIGTERM on the supervisor is still not treated as task failure. The change is KPO-only: after `on_kill()`, cleanup still skips a second delete (avoids 404 retries) but raises `AirflowException` so the TI is failed / up_for_retry.
### Summary
- `KubernetesPodOperator.cleanup()` raises if `on_kill()` already ran, instead of returning as success.
- Unit tests cover the `_killed` cleanup path and the execute_sync race (SIGTERM/on_kill during wait, then execute continues).
### Validation
- Published `apache-airflow-providers-cncf-kubernetes==10.21.0`: `cleanup()` after `_killed=True` returned `None` (the SUCCESS bug).
- Same call against this change: `AirflowException: Pod sleep-worker was interrupted before it completed.`
- Tests added:
- `test_cleanup_raises_when_on_kill_already_ran`
- `test_execute_sync_on_kill_during_wait_is_not_success`
- Full `test_pod.py` file is `db_test` (breeze). Local proof used Airflow 3.1.3 + overlaid operator module, no live cluster.
Fixes #71202
### AI/LLM disclosure
- AI coding tools (including Grok and/or Codex agent-assisted editing) were used to help draft or modify code and this PR description.
- I reviewed the complete change, understand the reasoning, and ran the reported local tests before submitting.
- This submission is original work of authorship under the project CLA / contributor terms; AI output was not pasted unreviewed.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (Grok / Cursor agent)
Generated-by: Grok (Cursor agent) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KubernetesPodOperator succeeding after SIGTERM/on_kill interrupt [airflow]
Posted by "sankalpsthakur (via GitHub)" <gi...@apache.org>.
sankalpsthakur commented on PR #71533:
URL: https://github.com/apache/airflow/pull/71533#issuecomment-5313412449
Rebased onto main and used `PodInterrupted` (plus ruff-format) so static checks should pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KubernetesPodOperator succeeding after SIGTERM/on_kill interrupt [airflow]
Posted by "sankalpsthakur (via GitHub)" <gi...@apache.org>.
sankalpsthakur closed pull request #71533: Fix KubernetesPodOperator succeeding after SIGTERM/on_kill interrupt
URL: https://github.com/apache/airflow/pull/71533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KubernetesPodOperator succeeding after SIGTERM/on_kill interrupt [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #71533:
URL: https://github.com/apache/airflow/pull/71533#issuecomment-5277462161
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KubernetesPodOperator succeeding after SIGTERM/on_kill interrupt [airflow]
Posted by "sankalpsthakur (via GitHub)" <gi...@apache.org>.
sankalpsthakur commented on PR #71533:
URL: https://github.com/apache/airflow/pull/71533#issuecomment-5554243086
Withdrawing; no maintainer signal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org