[GitHub] [incubator-pinot] npawar commented on a change in pull request #4306: Added tests for RealtimeSegmentValidationManager

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #4306: Added tests for RealtimeSegmentValidationManager
URL: https://github.com/apache/incubator-pinot/pull/4306#discussion_r292708365
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
 ##########
 @@ -635,6 +641,9 @@ public void setOfflineSegmentIntervalCheckerInitialDelayInSeconds(long initialDe
   }
 
   public long getPeriodicTaskInitialDelayInSeconds() {
+    if (containsKey(ControllerPeriodicTasksConf.SEGMENT_LEVEL_VALIDATION_INTERVAL_IN_SECONDS)) {
 
 Review comment:
   This one is the generic PeriodicTask initial delay. The segment level validation seconds shouldn't be applied here. 
   Maybe we need another on getRealtimeSegmentValidationInitialDelay()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org