You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/13 14:34:01 UTC
[GitHub] mgaido91 commented on a change in pull request #23773:
[SPARK-26721][ML] Avoid per-tree normalization in featureImportance for GBT
mgaido91 commented on a change in pull request #23773: [SPARK-26721][ML] Avoid per-tree normalization in featureImportance for GBT
URL: https://github.com/apache/spark/pull/23773#discussion_r256421078
##########
File path: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala
##########
@@ -341,11 +341,12 @@ class GBTClassificationModel private[ml](
* The importance vector is normalized to sum to 1. This method is suggested by Hastie et al.
Review comment:
no, it is still valid. The final vector is still normalized to 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org