[jira] [Comment Edited] (KAFKA-17055) Use random replica ids in KafkaRaftClientTest and KafkaRaftClientSnapshotTest

["Mason C (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-17055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864541#comment-17864541 ] 

Mason C edited comment on KAFKA-17055 at 7/10/24 8:23 AM:
----------------------------------------------------------

I have changed the well known ids (0,1,2) in KafkaRaftClientTests to a random generated integer. If they look good to you, I will start on the SnapshotTests. Thanks.


was (Author: JIRAUSER302343):
I have changed the well known ids (0,1,2) in KafkaRaftClientTests to a random generated interger. If they look good to you, I will start on the SnapshotTests. Thanks.

> Use random replica ids in KafkaRaftClientTest and KafkaRaftClientSnapshotTest
> -----------------------------------------------------------------------------
>
>                 Key: KAFKA-17055
>                 URL: https://issues.apache.org/jira/browse/KAFKA-17055
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: José Armando García Sancio
>            Priority: Major
>
> All of the tests in KafkakRaftClientTest and KafkaRaftClientSnapshotTest use well known ids like 0, 1, etc. Because of this those tests were not able to catch a bug in the BeginQuorumEpoch schema were the default value for VoterId was 0 instead of -1.
> Improve those tests by using random positive numbers to lower the probability that they will match the default value of a schema.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)