You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "blcksrx (via GitHub)" <gi...@apache.org> on 2023/12/17 17:47:15 UTC
[PR] k8s spark operator compatibility [airflow]
blcksrx opened a new pull request, #36268:
URL: https://github.com/apache/airflow/pull/36268
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Changes in this PR:
- Added `override_existing` argument with default to the operator.
- Uses the K8S application `uid` instead of naming
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #32363
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell commented on code in PR #36268:
URL: https://github.com/apache/airflow/pull/36268#discussion_r1429239828
##########
airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py:
##########
@@ -59,7 +59,7 @@ class SparkKubernetesOperator(BaseOperator):
def __init__(
self,
*,
- application_file: str | dict,
Review Comment:
Just curious, would users have passed `application_file` as a `dict` before or did it just not work previously? I'm just thinking of any backwards compat issues here albeit potentially small.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 commented on PR #36268:
URL: https://github.com/apache/airflow/pull/36268#issuecomment-1925874173
> A major change happened in the operator actually, that makes it hard to do it! The new change generates a new job name(at least what i understood from the code) and it needs collaboration of these changes commiters
isn't it just to add this line:
```python
template_fields: Sequence[str] = ("application_file", "namespace", "override_existing")
```
or I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "blcksrx (via GitHub)" <gi...@apache.org>.
blcksrx commented on code in PR #36268:
URL: https://github.com/apache/airflow/pull/36268#discussion_r1429261594
##########
airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py:
##########
@@ -59,7 +59,7 @@ class SparkKubernetesOperator(BaseOperator):
def __init__(
self,
*,
- application_file: str | dict,
Review Comment:
Ah, that's strange, cause I didn't change it. sorry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "blcksrx (via GitHub)" <gi...@apache.org>.
blcksrx commented on PR #36268:
URL: https://github.com/apache/airflow/pull/36268#issuecomment-1925867495
A major change happened in the operator actually, that makes it hard to do it!
The new change generates a new job name(at least what i understood from the code) and it needs collaboration of these changes commiters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "blcksrx (via GitHub)" <gi...@apache.org>.
blcksrx commented on PR #36268:
URL: https://github.com/apache/airflow/pull/36268#issuecomment-1906582870
@assaf-xm no review yet :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "ruslanguns (via GitHub)" <gi...@apache.org>.
ruslanguns commented on PR #36268:
URL: https://github.com/apache/airflow/pull/36268#issuecomment-1907626900
This PR is very important for us, we are start working with Airflow and Spark and this additional means a lot. I really encourage the reviewers to review this. Thanks in advanced:
FYI @jedcunningham @hussein-awala @josh-fell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36268:
URL: https://github.com/apache/airflow/pull/36268#issuecomment-1907882516
Can you rebase it please @blcksrx ? There are some conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "blcksrx (via GitHub)" <gi...@apache.org>.
blcksrx commented on PR #36268:
URL: https://github.com/apache/airflow/pull/36268#issuecomment-1925874694
This part is simple,the operator it self got completely changed, check it from the main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "blcksrx (via GitHub)" <gi...@apache.org>.
blcksrx commented on PR #36268:
URL: https://github.com/apache/airflow/pull/36268#issuecomment-1910942786
@potiuk I see a lot of changes, It gonna check it during the weekened
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 commented on PR #36268:
URL: https://github.com/apache/airflow/pull/36268#issuecomment-1925866476
I think it will be nice to add this `override_existing` as templated field.
If it's not to much can u add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "blcksrx (via GitHub)" <gi...@apache.org>.
blcksrx commented on code in PR #36268:
URL: https://github.com/apache/airflow/pull/36268#discussion_r1429261594
##########
airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py:
##########
@@ -59,7 +59,7 @@ class SparkKubernetesOperator(BaseOperator):
def __init__(
self,
*,
- application_file: str | dict,
Review Comment:
Probably yes then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "assaf-xm (via GitHub)" <gi...@apache.org>.
assaf-xm commented on PR #36268:
URL: https://github.com/apache/airflow/pull/36268#issuecomment-1906020596
@blcksrx is there any progress with the review of this PR?
(this is a small PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36268:
URL: https://github.com/apache/airflow/pull/36268#issuecomment-2010947712
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] k8s spark operator compatibility [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #36268: k8s spark operator compatibility
URL: https://github.com/apache/airflow/pull/36268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org