You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2017/01/25 06:41:29 UTC

[GitHub] zeppelin pull request #1943: [ZEPPELIN-2011] Add lib/interpreter to classpat...

GitHub user minahlee opened a pull request:

    https://github.com/apache/zeppelin/pull/1943

    [ZEPPELIN-2011] Add lib/interpreter to classpath

    ### What is this PR for?
    Interpreter installation fail with `NoClassDefFoundError` error when zeppelin is built as distribution package. This PR fixes it by adding `lib/interpreter` to classpath.
    
    ### What type of PR is it?
    Bug Fix | Hot Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-2011](https://issues.apache.org/jira/browse/ZEPPELIN-2011)
    
    ### How should this be tested?
    1. Build distribution package
    ```
    mvn clean package -DskipTests -pl zeppelin-interpreter,zeppelin-zengine,:zeppelin-display_2.10,:zeppelin-spark-dependencies_2.10,:zeppelin-spark_2.10,zeppelin-web,zeppelin-server,zeppelin-distribution -am -Pbuild-distr
    ```
    2. Change working directory
    ```
    $ cd zeppelin-distribution/target/zeppelin-0.8.0-SNAPSHOT/zeppelin-0.8.0-SNAPSHOT
    ```
    3. Run `bin/install-interpreter.sh` and see if error is gone.
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/minahlee/zeppelin ZEPPELIN-2011

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1943.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1943
    
----
commit af14a3f89a78c5c16d55dca39d692e33b1a8d5f6
Author: Mina Lee <mi...@apache.org>
Date:   2017-01-25T05:58:25Z

    Add lib/interpreter to classpath

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1943: [HOTFIX][ZEPPELIN-2011] Add lib/interpreter to classpa...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/1943
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1943: [HOTFIX][ZEPPELIN-2011] Add lib/interpreter to classpa...

Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/1943
  
    Tested and it was working well, LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1943: [HOTFIX][ZEPPELIN-2011] Add lib/interpreter to ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1943


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---