You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Gurkan Erdogdu (JIRA)" <ji...@apache.org> on 2010/09/19 18:23:34 UTC

[jira] Created: (OPENEJB-1360) Possible Bug in AnnotationDeployer # processCallbacks

Possible Bug in AnnotationDeployer # processCallbacks
-----------------------------------------------------

                 Key: OPENEJB-1360
                 URL: https://issues.apache.org/jira/browse/OPENEJB-1360
             Project: OpenEJB
          Issue Type: Bug
            Reporter: Gurkan Erdogdu


In AnnotationDeployer # processCallbacks method, there is a check for each
callback/around....configuration,

LifecycleCallback postConstruct = getFirst(bean.getPostConstruct());
if(postConstruct == null){
for (Method method : classFinder.findAnnotatedMethods(PostConstruct.class)) {
  ......
}
}

Firstly, code checks that callback is defined on deployment descriptor, if it is
defined, no more annotation check is done. I think that this is not correct
behaviour because it eats interceptors that are defined on "superclasses".

Also, interceptor specification talks about merging annotation and DD.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENEJB-1360) Possible Bug in AnnotationDeployer # processCallbacks

Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gurkan Erdogdu updated OPENEJB-1360:
------------------------------------

    Attachment: patch.txt

> Possible Bug in AnnotationDeployer # processCallbacks
> -----------------------------------------------------
>
>                 Key: OPENEJB-1360
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1360
>             Project: OpenEJB
>          Issue Type: Bug
>            Reporter: Gurkan Erdogdu
>         Attachments: patch.txt
>
>
> In AnnotationDeployer # processCallbacks method, there is a check for each
> callback/around....configuration,
> LifecycleCallback postConstruct = getFirst(bean.getPostConstruct());
> if(postConstruct == null){
> for (Method method : classFinder.findAnnotatedMethods(PostConstruct.class)) {
>   ......
> }
> }
> Firstly, code checks that callback is defined on deployment descriptor, if it is
> defined, no more annotation check is done. I think that this is not correct
> behaviour because it eats interceptors that are defined on "superclasses".
> Also, interceptor specification talks about merging annotation and DD.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.