You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/02/11 06:27:24 UTC
[PR] chore: remove Applitools visual testing integration [superset]
rusackas opened a new pull request, #37873:
URL: https://github.com/apache/superset/pull/37873
## Summary
Completely removes all Applitools visual testing integration from the codebase. We're no longer using this service.
### Deleted files (10 files)
- `.github/workflows/superset-applitool-cypress.yml` - Cypress visual testing workflow
- `.github/workflows/superset-applitools-storybook.yml` - Storybook visual testing workflow
- `superset-frontend/applitools.config.js` - Storybook Applitools config
- `superset-frontend/cypress-base/applitools.config.js` - Cypress Applitools config
- `superset-frontend/cypress-base/cypress/applitools/*.test.ts` - 5 Applitools test files
- `docs/static/img/applitools.png` - Logo image
### Modified files
- **Dependencies**: Removed `@applitools/eyes-storybook` and `@applitools/eyes-cypress`
- **Cypress config**: Removed eyesPlugin wrapper and applitools spec pattern
- **Cypress support**: Removed `@applitools/eyes-cypress/commands` import
- **TypeScript**: Removed Applitools types from tsconfig.json
- **CI**: Removed `cypress-run-applitools` function from bashlib.sh
- **License review**: Removed Applitools package exceptions from dependency-review.yml
- **Docs footer**: Removed Applitools logo/link from site footer
- **Style guide**: Removed Applitools mention from frontend guidelines
### Impact
- Removes ~7,800 lines of code and dependencies
- Removes 2 scheduled CI workflows that were running daily
- No functionality change - Applitools was only used for visual regression testing
## Test plan
- CI should pass without Applitools
- Cypress tests should still run (regular e2e tests unaffected)
- Docs site should build and display correctly without Applitools logo in footer
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: remove Applitools visual testing integration [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37873:
URL: https://github.com/apache/superset/pull/37873#issuecomment-3882561473
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: remove Applitools visual testing integration [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37873:
URL: https://github.com/apache/superset/pull/37873#issuecomment-3883107122
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: remove Applitools visual testing integration [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #37873:
URL: https://github.com/apache/superset/pull/37873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: remove Applitools visual testing integration [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #37873:
URL: https://github.com/apache/superset/pull/37873#issuecomment-3882603835
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | cf7bc8ff05e445ac7e1e671e33adc3b3f150d8f5 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/698c214c4dcb4800082c0f89 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-37873--superset-docs-preview.netlify.app](https://deploy-preview-37873--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-37873--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: remove Applitools visual testing integration [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #37873:
URL: https://github.com/apache/superset/pull/37873#issuecomment-3882572222
## **Sequence Diagram**
The PR removes Applitools integration so CI no longer runs visual tests and Cypress runs only regular e2e specs; the docs/site footer no longer references Applitools. The diagram shows the simplified, main success path after removal.
```mermaid
sequenceDiagram
participant Developer
participant CI
participant CypressRunner
participant DocsSite
Developer->>CI: Push PR / schedule triggers
CI->>CypressRunner: Run test job (cypress.config.ts)
CypressRunner->>CypressRunner: Execute e2e specs only (applitools removed)
CypressRunner-->>CI: Test results
CI->>DocsSite: Build docs (footer without Applitools)
DocsSite-->>CI: Build/artifacts ready
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: remove Applitools visual testing integration [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #37873:
URL: https://github.com/apache/superset/pull/37873#issuecomment-3882868884
Big shoutout to @geido who worked so hard to get all this working way-back-when. I feel bad gutting it, but... let's clean house! :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org