You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2014/05/12 10:05:14 UTC

[jira] [Resolved] (WICKET-5586) NextButton isEnabled() should bo logical conjunction of getWizardModel().isNextAvailable() and super.isEnabled()

     [ https://issues.apache.org/jira/browse/WICKET-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sven Meier resolved WICKET-5586.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 7.0.0-M2
                   6.16.0
         Assignee: Sven Meier

changed as proposed

> NextButton isEnabled() should bo logical conjunction of getWizardModel().isNextAvailable() and super.isEnabled()
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-5586
>                 URL: https://issues.apache.org/jira/browse/WICKET-5586
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>    Affects Versions: 6.12.0, 7.0.0-M1
>            Reporter: Mikael Björertz
>            Assignee: Sven Meier
>              Labels: navigation, wizard
>             Fix For: 6.16.0, 7.0.0-M2
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> The implementation of isEnabled in NextButton breaks the implicit contract of setEnabled(false) -> isEnabled() returning false. There is no apparent reason and no explanation to why this is done.
> Implementation should be 
> return super.isEnabled() && getWizardModel().isNextAvailable();



--
This message was sent by Atlassian JIRA
(v6.2#6252)