You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "quantranhong1999 (via GitHub)" <gi...@apache.org> on 2026/10/13 04:34:57 UTC
[PR] [BUILD] Apply user isolation for some distributed tests [james-project]
quantranhong1999 opened a new pull request, #3251:
URL: https://github.com/apache/james-project/pull/3251
Expected gain on CI: 6-10 minutes per build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [BUILD] Apply user isolation for some distributed tests [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3251:
URL: https://github.com/apache/james-project/pull/3251#discussion_r4254921369
##########
server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQWebAdminServerTaskSerializationIntegrationTest.java:
##########
@@ -188,115 +159,6 @@ void recomputeFastViewProjectionItemsShouldComplete(GuiceJamesServer server) thr
.body("additionalInformation.failedMessageCount", is(0));
}
- @Test
- void subscribeAllShouldComplete(GuiceJamesServer server) throws Exception {
Review Comment:
I did not get my coffee yet this morning yet.
So sorry, I will need a clarification.
Where all those tests did go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [BUILD] Apply user isolation for some distributed tests [james-project]
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on PR #3251:
URL: https://github.com/apache/james-project/pull/3251#issuecomment-6144508174
> Timing retex
<img width="674" height="156" alt="image" src="https://github.com/user-attachments/assets/68a66ea0-d18a-45d1-b9d9-27f000ace02b" />
Sadly, for the webadmin distributed module (locally, the gain was −11%). Let's see for the 2nd build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [BUILD] Apply user isolation for some distributed tests [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3251:
URL: https://github.com/apache/james-project/pull/3251#discussion_r4254913390
##########
server/apps/distributed-app/pom.xml:
##########
@@ -462,6 +462,7 @@
-javaagent:"${settings.localRepository}"/org/jacoco/org.jacoco.agent/${jacoco-maven-plugin.version}/org.jacoco.agent-${jacoco-maven-plugin.version}-runtime.jar=destfile=${basedir}/target/jacoco.exec
-Xms512m -Xmx2048m</argLine>
<reuseForks>true</reuseForks>
+ <forkCount>2</forkCount>
Review Comment:
I'm not opposed to it but it looks greedy to me....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [BUILD] Apply user isolation for some distributed tests [james-project]
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on PR #3251:
URL: https://github.com/apache/james-project/pull/3251#issuecomment-6159396849
We got the 2nd green build. However, the build cache was triggered though and only 26m of build time =.=.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [BUILD] Apply user isolation for some distributed tests [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #3251:
URL: https://github.com/apache/james-project/pull/3251#issuecomment-6144310838
Timing retex @quantranhong1999 ?
Second build is :green_apple: I presume we are good then...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [BUILD] Apply user isolation for some distributed tests [james-project]
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #3251:
URL: https://github.com/apache/james-project/pull/3251#discussion_r4257510830
##########
server/apps/distributed-app/pom.xml:
##########
@@ -462,6 +462,7 @@
-javaagent:"${settings.localRepository}"/org/jacoco/org.jacoco.agent/${jacoco-maven-plugin.version}/org.jacoco.agent-${jacoco-maven-plugin.version}-runtime.jar=destfile=${basedir}/target/jacoco.exec
-Xms512m -Xmx2048m</argLine>
<reuseForks>true</reuseForks>
+ <forkCount>2</forkCount>
Review Comment:
We got the 1st build green. I triggered a 2nd build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [BUILD] Apply user isolation for some distributed tests [james-project]
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 merged PR #3251:
URL: https://github.com/apache/james-project/pull/3251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [BUILD] Apply user isolation for some distributed tests [james-project]
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #3251:
URL: https://github.com/apache/james-project/pull/3251#discussion_r4255293306
##########
server/apps/distributed-app/pom.xml:
##########
@@ -462,6 +462,7 @@
-javaagent:"${settings.localRepository}"/org/jacoco/org.jacoco.agent/${jacoco-maven-plugin.version}/org.jacoco.agent-${jacoco-maven-plugin.version}-runtime.jar=destfile=${basedir}/target/jacoco.exec
-Xms512m -Xmx2048m</argLine>
<reuseForks>true</reuseForks>
+ <forkCount>2</forkCount>
Review Comment:
Hmm, this is OK on my local with 8GB of memory limited to Docker. So let's see the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [BUILD] Apply user isolation for some distributed tests [james-project]
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #3251:
URL: https://github.com/apache/james-project/pull/3251#discussion_r4255317043
##########
server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQWebAdminServerTaskSerializationIntegrationTest.java:
##########
@@ -188,115 +159,6 @@ void recomputeFastViewProjectionItemsShouldComplete(GuiceJamesServer server) thr
.body("additionalInformation.failedMessageCount", is(0));
}
- @Test
- void subscribeAllShouldComplete(GuiceJamesServer server) throws Exception {
Review Comment:
Not all, but some of the tests that can leverage user isolation were moved to `RabbitMQWebAdminServerUserTaskSerializationIntegrationTest`.
The remaining tests which can not rely on user isolation still remain on the original test class.
(was explained in the commit description btw, but hopefully this short comment helped)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org