You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/05/11 17:38:45 UTC

[GitHub] [phoenix] gokceni commented on a change in pull request #1228: PHOENIX-6462 Index build that failed should be reporting it into the PHOENIX_INDEX_TOOL_RESULT table

gokceni commented on a change in pull request #1228:
URL: https://github.com/apache/phoenix/pull/1228#discussion_r630392682



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -357,6 +361,7 @@ public boolean next(List<Cell> results) throws IOException {
         } catch (Throwable e) {
             LOGGER.error("Exception in IndexRebuildRegionScanner for region "
                     + region.getRegionInfo().getRegionNameAsString(), e);
+            this.shouldRetry = true;

Review comment:
       This is a good idea! @kadirozde what do you think? We can just say, ok we know that we are successfully finished for this region and shouldRetry=false in that end of try, and all other cases there must be either region split/move or exception and retry.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org