You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/30 03:08:00 UTC

[GitHub] [spark] turboFei opened a new pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

turboFei opened a new pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task
URL: https://github.com/apache/spark/pull/26339
 
 
   ### What changes were proposed in this pull request?
   As described in https://issues.apache.org/jira/browse/SPARK-27194 and https://issues.apache.org/jira/browse/SPARK-29302,  there is an issue for dynamic partition overwrite.
   
   Based on the proposal by @advancedxy (see details in https://github.com/apache/spark/pull/24142#issuecomment-516723747), I implement this PR.
   
   1. Set a working path under stagingDir named `_temporary`.
   2. Set task name to `_temporary/partitionPath/taskAttemptId/filename` firstly.
   3. after task completed, rename `_temporary/partitionPath/taskAttemptId/filename` to  `partitionPath/filename`.
   
   ### Why are the changes needed?
   
   For dynamic partition overwrite, a task may conflict with its speculative task.
   
   
   ### Does this PR introduce any user-facing change?
   No.
   
   
   ### How was this patch tested?
   Existing UT.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org