You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2021/03/08 15:27:58 UTC
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17026
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
IMPALA-9470: Use Parquet Bloom filters - Part 1
This change adds read support for Parquet Bloom filters for some types.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests that
Parquet Bloom filtering works for the supported types and that we do
not incorrectly discard row groups for the unsupported type VARCHAR.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M common/thrift/parquet.thrift
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
25 files changed, 6,815 insertions(+), 122 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/11
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 11
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 18:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8424/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 18
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Mar 2021 16:56:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 40: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 40
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Jun 2021 06:31:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 39: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 39
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Jun 2021 15:49:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 13:
(183 comments)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/exec/parquet/hdfs-parquet-scanner.cc@1819
PS13, Line 1819: const int bytes = std::max(1, bloom_filter_header.numBytes); // TODO: Trying to silence a clang warning.
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@70
PS13, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@92
PS13, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@113
PS13, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@243
PS13, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@253
PS13, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@254
PS13, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@270
PS13, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@429
PS13, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@441
PS13, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@476
PS13, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@628
PS13, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@631
PS13, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@700
PS13, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@724
PS13, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@743
PS13, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@756
PS13, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@766
PS13, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@768
PS13, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@791
PS13, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@792
PS13, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@808
PS13, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@809
PS13, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@811
PS13, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@881
PS13, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@886
PS13, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@888
PS13, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@912
PS13, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@915
PS13, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@977
PS13, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1028
PS13, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1029
PS13, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1046
PS13, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1052
PS13, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1257
PS13, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1258
PS13, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1686
PS13, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1707
PS13, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1708
PS13, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1709
PS13, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1710
PS13, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1711
PS13, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1771
PS13, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1953
PS13, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1960
PS13, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1986
PS13, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@1994
PS13, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2030
PS13, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2155
PS13, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2158
PS13, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2174
PS13, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2278
PS13, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2289
PS13, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2290
PS13, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2291
PS13, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2292
PS13, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2293
PS13, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2494
PS13, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2514
PS13, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2521
PS13, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2545
PS13, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2553
PS13, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2587
PS13, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2637
PS13, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2648
PS13, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@2852
PS13, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3010
PS13, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3011
PS13, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3012
PS13, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3013
PS13, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3014
PS13, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3015
PS13, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3016
PS13, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3017
PS13, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3020
PS13, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3021
PS13, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3022
PS13, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3023
PS13, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3062
PS13, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3110
PS13, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3137
PS13, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3138
PS13, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3140
PS13, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3141
PS13, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3160
PS13, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3161
PS13, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3162
PS13, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3163
PS13, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3164
PS13, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3165
PS13, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3166
PS13, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3167
PS13, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3168
PS13, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3169
PS13, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3170
PS13, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3171
PS13, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3419
PS13, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3441
PS13, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3457
PS13, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3462
PS13, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3463
PS13, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3474
PS13, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3480
PS13, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3618
PS13, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3621
PS13, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3705
PS13, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3709
PS13, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3754
PS13, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3769
PS13, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3782
PS13, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3818
PS13, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3822
PS13, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3850
PS13, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3858
PS13, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3865
PS13, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3926
PS13, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3958
PS13, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@3966
PS13, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4101
PS13, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4102
PS13, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4113
PS13, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4136
PS13, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4148
PS13, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4181
PS13, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4346
PS13, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4367
PS13, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4368
PS13, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4381
PS13, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4418
PS13, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4425
PS13, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4433
PS13, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4436
PS13, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4448
PS13, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4451
PS13, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4497
PS13, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4501
PS13, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4513
PS13, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4515
PS13, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4517
PS13, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4527
PS13, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4532
PS13, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4534
PS13, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4541
PS13, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4615
PS13, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4672
PS13, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4694
PS13, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4703
PS13, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4709
PS13, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4711
PS13, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4714
PS13, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4736
PS13, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4741
PS13, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4749
PS13, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4780
PS13, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4827
PS13, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4838
PS13, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4873
PS13, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4894
PS13, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4918
PS13, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4936
PS13, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4947
PS13, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4956
PS13, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4974
PS13, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4979
PS13, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4980
PS13, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@4983
PS13, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5004
PS13, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5030
PS13, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5049
PS13, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5169
PS13, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5225
PS13, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5235
PS13, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5243
PS13, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5247
PS13, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5258
PS13, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5260
PS13, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5262
PS13, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5279
PS13, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5321
PS13, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5352
PS13, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5356
PS13, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/be/src/thirdparty/xxhash/xxhash.h@5363
PS13, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/13/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/13/common/thrift/parquet.thrift@656
PS13, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 13
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 18:48:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 39: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7188/
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 39
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Jun 2021 20:59:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
IMPALA-9470: Use Parquet Bloom filters - Part 1
This change adds read support for Parquet Bloom filters for some types.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests that
Parquet Bloom filtering works for the supported types and that we do
not incorrectly discard row groups for the unsupported type VARCHAR.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/parquet.thrift
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
27 files changed, 6,848 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/15
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 15
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 28:
(184 comments)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@70
PS28, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@92
PS28, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@113
PS28, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@243
PS28, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@253
PS28, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@254
PS28, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@270
PS28, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@429
PS28, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@441
PS28, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@476
PS28, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@628
PS28, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@631
PS28, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@700
PS28, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@724
PS28, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@743
PS28, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@756
PS28, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@766
PS28, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@768
PS28, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@791
PS28, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@792
PS28, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@808
PS28, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@809
PS28, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@811
PS28, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@881
PS28, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@886
PS28, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@888
PS28, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@912
PS28, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@915
PS28, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@977
PS28, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1028
PS28, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1029
PS28, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1046
PS28, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1052
PS28, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1257
PS28, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1258
PS28, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1686
PS28, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1707
PS28, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1708
PS28, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1709
PS28, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1710
PS28, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1711
PS28, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1771
PS28, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1953
PS28, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1960
PS28, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1986
PS28, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@1994
PS28, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2030
PS28, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2155
PS28, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2158
PS28, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2174
PS28, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2278
PS28, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2289
PS28, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2290
PS28, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2291
PS28, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2292
PS28, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2293
PS28, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2494
PS28, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2514
PS28, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2521
PS28, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2545
PS28, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2553
PS28, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2587
PS28, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2637
PS28, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2648
PS28, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@2852
PS28, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3010
PS28, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3011
PS28, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3012
PS28, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3013
PS28, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3014
PS28, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3015
PS28, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3016
PS28, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3017
PS28, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3020
PS28, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3021
PS28, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3022
PS28, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3023
PS28, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3062
PS28, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3110
PS28, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3137
PS28, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3138
PS28, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3140
PS28, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3141
PS28, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3160
PS28, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3161
PS28, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3162
PS28, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3163
PS28, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3164
PS28, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3165
PS28, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3166
PS28, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3167
PS28, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3168
PS28, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3169
PS28, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3170
PS28, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3171
PS28, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3419
PS28, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3441
PS28, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3457
PS28, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3462
PS28, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3463
PS28, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3474
PS28, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3480
PS28, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3618
PS28, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3621
PS28, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3705
PS28, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3709
PS28, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3754
PS28, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3769
PS28, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3782
PS28, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3818
PS28, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3822
PS28, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3850
PS28, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3858
PS28, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3865
PS28, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3926
PS28, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3958
PS28, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@3966
PS28, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4101
PS28, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4102
PS28, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4113
PS28, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4136
PS28, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4148
PS28, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4181
PS28, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4346
PS28, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4367
PS28, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4368
PS28, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4381
PS28, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4418
PS28, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4425
PS28, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4433
PS28, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4436
PS28, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4448
PS28, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4451
PS28, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4497
PS28, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4501
PS28, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4513
PS28, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4515
PS28, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4517
PS28, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4527
PS28, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4532
PS28, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4534
PS28, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4541
PS28, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4615
PS28, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4672
PS28, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4694
PS28, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4703
PS28, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4709
PS28, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4711
PS28, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4714
PS28, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4736
PS28, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4741
PS28, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4749
PS28, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4780
PS28, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4827
PS28, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4838
PS28, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4873
PS28, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4894
PS28, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4918
PS28, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4936
PS28, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4947
PS28, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4956
PS28, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4974
PS28, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4979
PS28, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4980
PS28, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@4983
PS28, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5004
PS28, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5030
PS28, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5049
PS28, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5169
PS28, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5225
PS28, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5235
PS28, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5243
PS28, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5247
PS28, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5258
PS28, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5260
PS28, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5262
PS28, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5279
PS28, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5321
PS28, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5352
PS28, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5356
PS28, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/thirdparty/xxhash/xxhash.h@5363
PS28, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/util/parquet-bloom-filter.h
File be/src/util/parquet-bloom-filter.h:
http://gerrit.cloudera.org:8080/#/c/17026/28/be/src/util/parquet-bloom-filter.h@63
PS28, Line 63: // The BloomFilter is divided up into Buckets and each Bucket comprises of 8 BucketWords of
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/28/common/thrift/parquet.thrift@656
PS28, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/28/tests/query_test/test_parquet_bloom_filter.py
File tests/query_test/test_parquet_bloom_filter.py:
http://gerrit.cloudera.org:8080/#/c/17026/28/tests/query_test/test_parquet_bloom_filter.py@21
PS28, Line 21: class TestParquetBloomFilter(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 28
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Apr 2021 22:10:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 30: Code-Review+1
(3 comments)
I can give +2 once these comments are resolved.
A note about AVX2: I am ok with committing it as it is and clean it up in a later commit, as lot of cleanup should be done in other parts related to AVX2.
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/util/parquet-bloom-filter-avx2.cc
File be/src/util/parquet-bloom-filter-avx2.cc:
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/util/parquet-bloom-filter-avx2.cc@17
PS30, Line 17:
Can you add a comment to the files that are mainly copied from Kudu code about their source?
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/util/parquet-bloom-filter.cc
File be/src/util/parquet-bloom-filter.cc:
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/util/parquet-bloom-filter.cc@37
PS30, Line 37: DEFINE_bool(disable_parquetbloomfilter_avx2, false,
Note that AVX2 support became required recently in x86_64:
https://gerrit.cloudera.org/#/c/17406/
http://gerrit.cloudera.org:8080/#/c/17026/30/testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
File testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test:
http://gerrit.cloudera.org:8080/#/c/17026/30/testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test@9
PS30, Line 9: select int8_col from parquet_bloom_filter where int8_col = 1;
Can you add some tests with more predicates? HdfsParquetScanner::CreateColIdx2EqConjunctMap() has quite complex logic and some issues may not come up if there is only a single eq predicate. Some examples:
- other predicates on a column besides =
- eq predicates on more than one column
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 30
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 May 2021 08:13:33 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 14:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8324/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 14
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 22:39:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
IMPALA-9470: Use Parquet Bloom filters - Part 1
This change adds read support for Parquet Bloom filters for some types.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests that
Parquet Bloom filtering works for the supported types and that we do
not incorrectly discard row groups for the unsupported type VARCHAR.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/rat_exclude_files.txt
M common/thrift/parquet.thrift
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
26 files changed, 6,820 insertions(+), 122 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/12
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 12
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#38). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
IMPALA-10640: Support reading Parquet Bloom filters - most common types
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
The following types are not supported for the given reasons:
----------------------------------------------------------------
|Impala type | Problem |
|----------------------------------------------------------------|
|VARCHAR(N) | truncation can change hash |
|CHAR(N) | padding / truncation can change hash |
|DECIMAL | multiple encodings supported |
|TIMESTAMP | multiple encodings supported, timezone conversion |
|DATE | not considered yet |
----------------------------------------------------------------
Support may be added for these types later, see IMPALA-10641.
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/jenkins/critique-gerrit-review.py
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter-disabled.test
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
36 files changed, 7,310 insertions(+), 125 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/38
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 38
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 17:
(25 comments)
http://gerrit.cloudera.org:8080/#/c/17026/17//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17026/17//COMMIT_MSG@7
PS17, Line 7: Part 1
Can you add some info about what is expected in later parts?
http://gerrit.cloudera.org:8080/#/c/17026/17//COMMIT_MSG@26
PS17, Line 26: Testing:
It would be great to add some unit tests for ParquetBloomFilter, especially if there are paths that are not used in the EE test.
http://gerrit.cloudera.org:8080/#/c/17026/17//COMMIT_MSG@28
PS17, Line 28: Parquet Bloom filtering works for the supported types and that we do
Please mention that we use a Parquet file generated by some other tool. This info should be also added to https://github.com/apache/impala/blob/aeeff53e884a67ee7f5980654a1d394c6e3e34ac/testdata/data/README
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exec/parquet/hdfs-parquet-scanner.h
File be/src/exec/parquet/hdfs-parquet-scanner.h:
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exec/parquet/hdfs-parquet-scanner.h@529
PS17, Line 529: buffer_pool_client_
BufferPool::ClientHandle should be only used from a single thread:
https://github.com/apache/impala/blob/master/be/src/runtime/bufferpool/buffer-pool.h#L332
I think that can cause problems if there are multiple scanners for a single scan node.
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exec/parquet/hdfs-parquet-scanner.h@801
PS17, Line 801: static bool IsParquetBloomFilterSupported(parquet::Type::type parquet_type,
There may be better places for these functions, e.g. ParquetMetadataUtils, ParquetCommon, or probably a separate file for Parquet bloom filter related stuff.
http://gerrit.cloudera.org:8080/#/c/17026/3/be/src/exec/parquet/hdfs-parquet-scanner.h
File be/src/exec/parquet/hdfs-parquet-scanner.h:
http://gerrit.cloudera.org:8080/#/c/17026/3/be/src/exec/parquet/hdfs-parquet-scanner.h@704
PS3, Line 704: ///
It could be noted that this is read from metadata_range_.
http://gerrit.cloudera.org:8080/#/c/17026/3/be/src/exec/parquet/hdfs-parquet-scanner.h@718
PS3, Line 718: /// Decides how to divide stream_->reservation() between the columns. May increase
consistency: EvalDictionaryFilters uses skip_row_group for the same purpose.
http://gerrit.cloudera.org:8080/#/c/17026/3/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/17026/3/be/src/exec/parquet/hdfs-parquet-scanner.cc@1108
PS3, Line 1108: nst string& fn_
A few DCHECKs would be nice, e.g. to ensure that metadata_range_ is filled.
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exec/parquet/hdfs-parquet-scanner.cc@843
PS17, Line 843: continue;
This means that we will skip the row group without raising an y counters. I think that we should process the row group if there are issues with the bloomfilter.
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exec/parquet/hdfs-parquet-scanner.cc@1470
PS17, Line 1470: FindChildSlotRef
Is this needed for any supported types? e.g. char(N) in the example shouldn't be supported.
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exec/parquet/hdfs-parquet-scanner.cc@1684
PS17, Line 1684: const int8_t* const cast_value = reinterpret_cast<const int8_t*>(value);
: const int byte_len = ParquetPlainEncoder::Encode(*cast_value,
: -1 /* fixed_len_size */, storage->data());
: DCHECK_EQ(byte_len, output_len);
Create a template function for this code?
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exec/parquet/hdfs-parquet-scanner.cc@1729
PS17, Line 1729: const int exp_size = ParquetPlainEncoder::ByteSize(*cast_value);
: storage->resize(exp_size);
if this was moved out, then the same template function could be used as the one mentioned at line 1684
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exec/parquet/hdfs-parquet-scanner.cc@1825
PS17, Line 1825: __isset.meta_data
We shouldn't need to check this here.
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exec/parquet/hdfs-parquet-scanner.cc@1834
PS17, Line 1834: &header_size, &bloom_filter_header));
nit: too much indentation
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exec/parquet/hdfs-parquet-scanner.cc@1842
PS17, Line 1842: return Status(Substitute("Could not allocate buffer of $0 bytes for Parquet "
nit: too much indentation
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exec/parquet/hdfs-parquet-scanner.cc@1857
PS17, Line 1857: data_buffer.buffer() + data_already_read, data_to_read));
nit: too much indentation
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exprs/expr-value.h
File be/src/exprs/expr-value.h:
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exprs/expr-value.h@209
PS17, Line 209: /// Returns whether the two ExprValue's are equal if they both have the gien type.
typo
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/exprs/expr-value.h@252
PS17, Line 252: case TYPE_DATETIME: // Not implemented
nit: double space
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/kudu/util/block_bloom_filter.cc
File be/src/kudu/util/block_bloom_filter.cc:
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/kudu/util/block_bloom_filter.cc@162
PS17, Line 162: Substitute("Mismatch in BlockBloomFilter source directory size $0 and expected size $1",
nit: long line
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/util/parquet-bloom-filter.h
File be/src/util/parquet-bloom-filter.h:
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/util/parquet-bloom-filter.h@35
PS17, Line 35: /// Reset the filter state, allocate/reallocate and initialize the 'directory_'. All
: /// calls to Insert() and Find() should only be done between the calls to Init() and
: /// Close(). Init and Close are safe to call multiple times.
: Status Init(const int log_bufferpool_space);
Do we ever use this functon? If not, then it could be removed.
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/util/parquet-bloom-filter.h@80
PS17, Line 80: /// Returns the expected false positive rate for the given ndv and log_bufferpool_space
nit: missing .
http://gerrit.cloudera.org:8080/#/c/17026/9/be/src/util/parquet-bloom-filter.h
File be/src/util/parquet-bloom-filter.h:
http://gerrit.cloudera.org:8080/#/c/17026/9/be/src/util/parquet-bloom-filter.h@35
PS9, Line 35: /// Reset the filter state, allocate/reallocate and initialize the 'directory_'. All
: /// calls to Insert() and Find() should only be done between the calls to Init() and
: /// Close(). Init and Close are safe to call multiple times.
: Status Init(const int log_bufferpool_space);
Do we actually call this functions?
http://gerrit.cloudera.org:8080/#/c/17026/9/be/src/util/parquet-bloom-filter.cc
File be/src/util/parquet-bloom-filter.cc:
http://gerrit.cloudera.org:8080/#/c/17026/9/be/src/util/parquet-bloom-filter.cc@52
PS9, Line 52: // We take care of hashing in this class and do not use the underlying Kudu
: // BloomFilter's hashing algorithm, so the hash algorithm and seed do not matter.
It could be less hacky if kudu::BlockBloomFilter was extended a bit to support "external hashing". E.g. it could have an extra init function and a bool is_external_hashing, and there could be DCHECKs in functions that cannot be called in case of external hashing.
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/util/parquet-bloom-filter.cc
File be/src/util/parquet-bloom-filter.cc:
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/util/parquet-bloom-filter.cc@36
PS17, Line 36: buffer_allocator_
If we initialize the block bloom filter without copy then the buffer_allocator_ won't be used (if I saw correctly). As we only use the no copy path, I think that buffer_allocator_ and client are not longer needed.
http://gerrit.cloudera.org:8080/#/c/17026/17/tests/query_test/test_parquet_bloom_filter.py
File tests/query_test/test_parquet_bloom_filter.py:
http://gerrit.cloudera.org:8080/#/c/17026/17/tests/query_test/test_parquet_bloom_filter.py@37
PS17, Line 37: test_deprecated_stats
should be renamed
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 17
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Mar 2021 19:45:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 20:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@70
PS20, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@92
PS20, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@113
PS20, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@243
PS20, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@253
PS20, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@254
PS20, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@270
PS20, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@429
PS20, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@441
PS20, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@476
PS20, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@628
PS20, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@631
PS20, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@700
PS20, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@724
PS20, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@743
PS20, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@756
PS20, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@766
PS20, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@768
PS20, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@791
PS20, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@792
PS20, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@808
PS20, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@809
PS20, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@811
PS20, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@881
PS20, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@886
PS20, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@888
PS20, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@912
PS20, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@915
PS20, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@977
PS20, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1028
PS20, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1029
PS20, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1046
PS20, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1052
PS20, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1257
PS20, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1258
PS20, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1686
PS20, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1707
PS20, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1708
PS20, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1709
PS20, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1710
PS20, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1711
PS20, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1771
PS20, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1953
PS20, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1960
PS20, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1986
PS20, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@1994
PS20, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2030
PS20, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2155
PS20, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2158
PS20, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2174
PS20, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2278
PS20, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2289
PS20, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2290
PS20, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2291
PS20, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2292
PS20, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2293
PS20, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2494
PS20, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2514
PS20, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2521
PS20, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2545
PS20, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2553
PS20, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2587
PS20, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2637
PS20, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2648
PS20, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@2852
PS20, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3010
PS20, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3011
PS20, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3012
PS20, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3013
PS20, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3014
PS20, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3015
PS20, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3016
PS20, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3017
PS20, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3020
PS20, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3021
PS20, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3022
PS20, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3023
PS20, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3062
PS20, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3110
PS20, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3137
PS20, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3138
PS20, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3140
PS20, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3141
PS20, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3160
PS20, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3161
PS20, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3162
PS20, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3163
PS20, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3164
PS20, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3165
PS20, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3166
PS20, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3167
PS20, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3168
PS20, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3169
PS20, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3170
PS20, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3171
PS20, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3419
PS20, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3441
PS20, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3457
PS20, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3462
PS20, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3463
PS20, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3474
PS20, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3480
PS20, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3618
PS20, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3621
PS20, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3705
PS20, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3709
PS20, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3754
PS20, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3769
PS20, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3782
PS20, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3818
PS20, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3822
PS20, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3850
PS20, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3858
PS20, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3865
PS20, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3926
PS20, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3958
PS20, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@3966
PS20, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4101
PS20, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4102
PS20, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4113
PS20, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4136
PS20, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4148
PS20, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4181
PS20, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4346
PS20, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4367
PS20, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4368
PS20, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4381
PS20, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4418
PS20, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4425
PS20, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4433
PS20, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4436
PS20, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4448
PS20, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4451
PS20, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4497
PS20, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4501
PS20, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4513
PS20, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4515
PS20, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4517
PS20, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4527
PS20, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4532
PS20, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4534
PS20, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4541
PS20, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4615
PS20, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4672
PS20, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4694
PS20, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4703
PS20, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4709
PS20, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4711
PS20, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4714
PS20, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4736
PS20, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4741
PS20, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4749
PS20, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4780
PS20, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4827
PS20, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4838
PS20, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4873
PS20, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4894
PS20, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4918
PS20, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4936
PS20, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4947
PS20, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4956
PS20, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4974
PS20, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4979
PS20, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4980
PS20, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@4983
PS20, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5004
PS20, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5030
PS20, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5049
PS20, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5169
PS20, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5225
PS20, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5235
PS20, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5243
PS20, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5247
PS20, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5258
PS20, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5260
PS20, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5262
PS20, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5279
PS20, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5321
PS20, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5352
PS20, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5356
PS20, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/thirdparty/xxhash/xxhash.h@5363
PS20, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/20/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/20/common/thrift/parquet.thrift@656
PS20, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 20
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Mar 2021 16:20:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#24). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
IMPALA-10640: Support reading Parquet Bloom filters - most common types
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
The following types are not supported for the given reasons:
----------------------------------------------------------------
|Impala type | Problem |
|----------------------------------------------------------------|
|VARCHAR(N) | truncation can change hash |
|CHAR(N) | padding / truncation can change hash |
|DECIMAL | multiple encodings supported |
|TIMESTAMP | multiple encodings supported, timezone conversion |
|DATE | not considered yet |
----------------------------------------------------------------
Support may be added for these types later, see IMPALA-10641.
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
33 files changed, 7,133 insertions(+), 139 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/24
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 24
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 20:
(4 comments)
Thanks for the reviews. There are a few TODOs about which I'm not quite sure, could you please help me with them?
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/exec/parquet/hdfs-parquet-scanner.cc@1482
PS20, Line 1482: DCHECK(false); // TODO: Is it possible?
Do you think this is a possibility?
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/exec/parquet/hdfs-parquet-scanner.cc@1533
PS20, Line 1533: // TODO: That's what we do for stats filtering. Is it the correct way to handle
What do you think of this?
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/exec/parquet/parquet-bloom-filter-util.cc
File be/src/exec/parquet/parquet-bloom-filter-util.cc:
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/exec/parquet/parquet-bloom-filter-util.cc@170
PS18, Line 170: *ptr = storage->data();
: *len = storage->size();
> Resizing could be moved inside ParquetBloomFilterEncodeValue to make the ca
Done
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/exprs/expr-value.h
File be/src/exprs/expr-value.h:
http://gerrit.cloudera.org:8080/#/c/17026/20/be/src/exprs/expr-value.h@236
PS20, Line 236: // TODO: Is it OK for all these string types?
What do you think of this, especially for TYPE_FIXED_UDA_INTERMEDIATE?
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 20
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 13:34:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 35:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8820/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 35
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 May 2021 16:14:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 17:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@70
PS17, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@92
PS17, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@113
PS17, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@243
PS17, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@253
PS17, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@254
PS17, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@270
PS17, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@429
PS17, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@441
PS17, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@476
PS17, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@628
PS17, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@631
PS17, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@700
PS17, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@724
PS17, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@743
PS17, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@756
PS17, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@766
PS17, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@768
PS17, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@791
PS17, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@792
PS17, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@808
PS17, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@809
PS17, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@811
PS17, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@881
PS17, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@886
PS17, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@888
PS17, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@912
PS17, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@915
PS17, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@977
PS17, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1028
PS17, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1029
PS17, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1046
PS17, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1052
PS17, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1257
PS17, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1258
PS17, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1686
PS17, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1707
PS17, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1708
PS17, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1709
PS17, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1710
PS17, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1711
PS17, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1771
PS17, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1953
PS17, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1960
PS17, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1986
PS17, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@1994
PS17, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2030
PS17, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2155
PS17, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2158
PS17, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2174
PS17, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2278
PS17, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2289
PS17, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2290
PS17, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2291
PS17, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2292
PS17, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2293
PS17, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2494
PS17, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2514
PS17, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2521
PS17, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2545
PS17, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2553
PS17, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2587
PS17, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2637
PS17, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2648
PS17, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@2852
PS17, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3010
PS17, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3011
PS17, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3012
PS17, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3013
PS17, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3014
PS17, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3015
PS17, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3016
PS17, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3017
PS17, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3020
PS17, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3021
PS17, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3022
PS17, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3023
PS17, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3062
PS17, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3110
PS17, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3137
PS17, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3138
PS17, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3140
PS17, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3141
PS17, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3160
PS17, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3161
PS17, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3162
PS17, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3163
PS17, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3164
PS17, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3165
PS17, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3166
PS17, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3167
PS17, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3168
PS17, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3169
PS17, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3170
PS17, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3171
PS17, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3419
PS17, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3441
PS17, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3457
PS17, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3462
PS17, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3463
PS17, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3474
PS17, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3480
PS17, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3618
PS17, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3621
PS17, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3705
PS17, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3709
PS17, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3754
PS17, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3769
PS17, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3782
PS17, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3818
PS17, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3822
PS17, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3850
PS17, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3858
PS17, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3865
PS17, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3926
PS17, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3958
PS17, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@3966
PS17, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4101
PS17, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4102
PS17, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4113
PS17, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4136
PS17, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4148
PS17, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4181
PS17, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4346
PS17, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4367
PS17, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4368
PS17, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4381
PS17, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4418
PS17, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4425
PS17, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4433
PS17, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4436
PS17, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4448
PS17, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4451
PS17, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4497
PS17, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4501
PS17, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4513
PS17, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4515
PS17, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4517
PS17, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4527
PS17, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4532
PS17, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4534
PS17, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4541
PS17, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4615
PS17, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4672
PS17, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4694
PS17, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4703
PS17, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4709
PS17, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4711
PS17, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4714
PS17, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4736
PS17, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4741
PS17, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4749
PS17, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4780
PS17, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4827
PS17, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4838
PS17, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4873
PS17, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4894
PS17, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4918
PS17, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4936
PS17, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4947
PS17, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4956
PS17, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4974
PS17, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4979
PS17, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4980
PS17, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@4983
PS17, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5004
PS17, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5030
PS17, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5049
PS17, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5169
PS17, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5225
PS17, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5235
PS17, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5243
PS17, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5247
PS17, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5258
PS17, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5260
PS17, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5262
PS17, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5279
PS17, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5321
PS17, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5352
PS17, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5356
PS17, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/be/src/thirdparty/xxhash/xxhash.h@5363
PS17, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/17/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/17/common/thrift/parquet.thrift@656
PS17, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 17
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Mar 2021 11:02:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 27: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7080/
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 27
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Apr 2021 17:22:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 25: Code-Review+1
Thanks everyone, there are a few styling nits and a missing include guard (comment on patch set 23) that are still there.
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 25
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Apr 2021 08:54:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 23:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8505/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 23
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 10:26:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#26). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
IMPALA-10640: Support reading Parquet Bloom filters - most common types
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
The following types are not supported for the given reasons:
----------------------------------------------------------------
|Impala type | Problem |
|----------------------------------------------------------------|
|VARCHAR(N) | truncation can change hash |
|CHAR(N) | padding / truncation can change hash |
|DECIMAL | multiple encodings supported |
|TIMESTAMP | multiple encodings supported, timezone conversion |
|DATE | not considered yet |
----------------------------------------------------------------
Support may be added for these types later, see IMPALA-10641.
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/jenkins/critique-gerrit-review.py
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter-disabled.test
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
39 files changed, 7,264 insertions(+), 140 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/26
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 26
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
IMPALA-9470: Use Parquet Bloom filters - Part 1
This change adds read support for Parquet Bloom filters for some types.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests that
Parquet Bloom filtering works for the supported types and that we do
not incorrectly discard row groups for the unsupported type VARCHAR.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/parquet.thrift
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
27 files changed, 6,843 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/16
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 16
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#18). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
IMPALA-9470: Use Parquet Bloom filters - Part 1
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- TODO: Add unit tests for ParquetBloomFilter.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
31 files changed, 6,943 insertions(+), 136 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/18
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 18
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 26:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8587/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 26
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Apr 2021 13:01:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 37:
4 tests FAILED, but they may be unrelated as running them locally on master they also failed.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 37
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Jun 2021 10:29:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 34:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@70
PS34, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@92
PS34, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@113
PS34, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@243
PS34, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@253
PS34, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@254
PS34, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@270
PS34, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@429
PS34, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@441
PS34, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@476
PS34, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@628
PS34, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@631
PS34, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@700
PS34, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@724
PS34, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@743
PS34, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@756
PS34, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@766
PS34, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@768
PS34, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@791
PS34, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@792
PS34, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@808
PS34, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@809
PS34, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@811
PS34, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@881
PS34, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@886
PS34, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@888
PS34, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@912
PS34, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@915
PS34, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@977
PS34, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1028
PS34, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1029
PS34, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1046
PS34, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1052
PS34, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1257
PS34, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1258
PS34, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1686
PS34, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1707
PS34, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1708
PS34, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1709
PS34, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1710
PS34, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1711
PS34, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1771
PS34, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1953
PS34, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1960
PS34, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1986
PS34, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@1994
PS34, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2030
PS34, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2155
PS34, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2158
PS34, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2174
PS34, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2278
PS34, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2289
PS34, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2290
PS34, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2291
PS34, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2292
PS34, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2293
PS34, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2494
PS34, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2514
PS34, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2521
PS34, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2545
PS34, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2553
PS34, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2587
PS34, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2637
PS34, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2648
PS34, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@2852
PS34, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3010
PS34, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3011
PS34, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3012
PS34, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3013
PS34, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3014
PS34, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3015
PS34, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3016
PS34, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3017
PS34, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3020
PS34, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3021
PS34, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3022
PS34, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3023
PS34, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3062
PS34, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3110
PS34, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3137
PS34, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3138
PS34, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3140
PS34, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3141
PS34, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3160
PS34, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3161
PS34, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3162
PS34, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3163
PS34, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3164
PS34, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3165
PS34, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3166
PS34, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3167
PS34, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3168
PS34, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3169
PS34, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3170
PS34, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3171
PS34, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3419
PS34, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3441
PS34, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3457
PS34, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3462
PS34, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3463
PS34, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3474
PS34, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3480
PS34, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3618
PS34, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3621
PS34, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3705
PS34, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3709
PS34, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3754
PS34, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3769
PS34, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3782
PS34, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3818
PS34, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3822
PS34, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3850
PS34, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3858
PS34, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3865
PS34, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3926
PS34, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3958
PS34, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@3966
PS34, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4101
PS34, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4102
PS34, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4113
PS34, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4136
PS34, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4148
PS34, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4181
PS34, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4346
PS34, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4367
PS34, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4368
PS34, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4381
PS34, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4418
PS34, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4425
PS34, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4433
PS34, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4436
PS34, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4448
PS34, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4451
PS34, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4497
PS34, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4501
PS34, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4513
PS34, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4515
PS34, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4517
PS34, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4527
PS34, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4532
PS34, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4534
PS34, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4541
PS34, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4615
PS34, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4672
PS34, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4694
PS34, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4703
PS34, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4709
PS34, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4711
PS34, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4714
PS34, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4736
PS34, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4741
PS34, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4749
PS34, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4780
PS34, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4827
PS34, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4838
PS34, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4873
PS34, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4894
PS34, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4918
PS34, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4936
PS34, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4947
PS34, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4956
PS34, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4974
PS34, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4979
PS34, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4980
PS34, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@4983
PS34, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5004
PS34, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5030
PS34, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5049
PS34, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5169
PS34, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5225
PS34, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5235
PS34, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5243
PS34, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5247
PS34, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5258
PS34, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5260
PS34, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5262
PS34, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5279
PS34, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5321
PS34, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5352
PS34, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5356
PS34, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/be/src/thirdparty/xxhash/xxhash.h@5363
PS34, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/34/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/34/common/thrift/parquet.thrift@656
PS34, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 34
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 May 2021 14:48:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 15:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@70
PS15, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@92
PS15, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@113
PS15, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@243
PS15, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@253
PS15, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@254
PS15, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@270
PS15, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@429
PS15, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@441
PS15, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@476
PS15, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@628
PS15, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@631
PS15, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@700
PS15, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@724
PS15, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@743
PS15, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@756
PS15, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@766
PS15, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@768
PS15, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@791
PS15, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@792
PS15, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@808
PS15, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@809
PS15, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@811
PS15, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@881
PS15, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@886
PS15, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@888
PS15, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@912
PS15, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@915
PS15, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@977
PS15, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1028
PS15, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1029
PS15, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1046
PS15, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1052
PS15, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1257
PS15, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1258
PS15, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1686
PS15, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1707
PS15, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1708
PS15, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1709
PS15, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1710
PS15, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1711
PS15, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1771
PS15, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1953
PS15, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1960
PS15, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1986
PS15, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@1994
PS15, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2030
PS15, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2155
PS15, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2158
PS15, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2174
PS15, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2278
PS15, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2289
PS15, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2290
PS15, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2291
PS15, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2292
PS15, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2293
PS15, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2494
PS15, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2514
PS15, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2521
PS15, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2545
PS15, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2553
PS15, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2587
PS15, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2637
PS15, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2648
PS15, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@2852
PS15, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3010
PS15, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3011
PS15, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3012
PS15, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3013
PS15, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3014
PS15, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3015
PS15, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3016
PS15, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3017
PS15, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3020
PS15, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3021
PS15, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3022
PS15, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3023
PS15, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3062
PS15, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3110
PS15, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3137
PS15, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3138
PS15, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3140
PS15, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3141
PS15, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3160
PS15, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3161
PS15, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3162
PS15, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3163
PS15, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3164
PS15, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3165
PS15, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3166
PS15, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3167
PS15, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3168
PS15, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3169
PS15, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3170
PS15, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3171
PS15, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3419
PS15, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3441
PS15, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3457
PS15, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3462
PS15, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3463
PS15, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3474
PS15, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3480
PS15, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3618
PS15, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3621
PS15, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3705
PS15, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3709
PS15, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3754
PS15, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3769
PS15, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3782
PS15, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3818
PS15, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3822
PS15, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3850
PS15, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3858
PS15, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3865
PS15, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3926
PS15, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3958
PS15, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@3966
PS15, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4101
PS15, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4102
PS15, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4113
PS15, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4136
PS15, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4148
PS15, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4181
PS15, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4346
PS15, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4367
PS15, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4368
PS15, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4381
PS15, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4418
PS15, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4425
PS15, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4433
PS15, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4436
PS15, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4448
PS15, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4451
PS15, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4497
PS15, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4501
PS15, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4513
PS15, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4515
PS15, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4517
PS15, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4527
PS15, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4532
PS15, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4534
PS15, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4541
PS15, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4615
PS15, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4672
PS15, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4694
PS15, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4703
PS15, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4709
PS15, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4711
PS15, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4714
PS15, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4736
PS15, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4741
PS15, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4749
PS15, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4780
PS15, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4827
PS15, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4838
PS15, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4873
PS15, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4894
PS15, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4918
PS15, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4936
PS15, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4947
PS15, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4956
PS15, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4974
PS15, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4979
PS15, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4980
PS15, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@4983
PS15, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5004
PS15, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5030
PS15, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5049
PS15, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5169
PS15, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5225
PS15, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5235
PS15, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5243
PS15, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5247
PS15, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5258
PS15, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5260
PS15, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5262
PS15, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5279
PS15, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5321
PS15, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5352
PS15, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5356
PS15, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/be/src/thirdparty/xxhash/xxhash.h@5363
PS15, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/15/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/15/common/thrift/parquet.thrift@656
PS15, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 15
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Mar 2021 11:34:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 30:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@70
PS30, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@92
PS30, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@113
PS30, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@243
PS30, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@253
PS30, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@254
PS30, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@270
PS30, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@429
PS30, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@441
PS30, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@476
PS30, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@628
PS30, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@631
PS30, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@700
PS30, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@724
PS30, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@743
PS30, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@756
PS30, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@766
PS30, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@768
PS30, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@791
PS30, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@792
PS30, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@808
PS30, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@809
PS30, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@811
PS30, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@881
PS30, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@886
PS30, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@888
PS30, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@912
PS30, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@915
PS30, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@977
PS30, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1028
PS30, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1029
PS30, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1046
PS30, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1052
PS30, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1257
PS30, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1258
PS30, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1686
PS30, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1707
PS30, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1708
PS30, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1709
PS30, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1710
PS30, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1711
PS30, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1771
PS30, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1953
PS30, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1960
PS30, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1986
PS30, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@1994
PS30, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2030
PS30, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2155
PS30, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2158
PS30, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2174
PS30, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2278
PS30, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2289
PS30, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2290
PS30, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2291
PS30, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2292
PS30, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2293
PS30, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2494
PS30, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2514
PS30, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2521
PS30, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2545
PS30, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2553
PS30, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2587
PS30, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2637
PS30, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2648
PS30, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@2852
PS30, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3010
PS30, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3011
PS30, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3012
PS30, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3013
PS30, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3014
PS30, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3015
PS30, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3016
PS30, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3017
PS30, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3020
PS30, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3021
PS30, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3022
PS30, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3023
PS30, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3062
PS30, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3110
PS30, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3137
PS30, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3138
PS30, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3140
PS30, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3141
PS30, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3160
PS30, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3161
PS30, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3162
PS30, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3163
PS30, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3164
PS30, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3165
PS30, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3166
PS30, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3167
PS30, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3168
PS30, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3169
PS30, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3170
PS30, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3171
PS30, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3419
PS30, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3441
PS30, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3457
PS30, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3462
PS30, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3463
PS30, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3474
PS30, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3480
PS30, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3618
PS30, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3621
PS30, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3705
PS30, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3709
PS30, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3754
PS30, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3769
PS30, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3782
PS30, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3818
PS30, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3822
PS30, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3850
PS30, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3858
PS30, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3865
PS30, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3926
PS30, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3958
PS30, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@3966
PS30, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4101
PS30, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4102
PS30, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4113
PS30, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4136
PS30, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4148
PS30, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4181
PS30, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4346
PS30, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4367
PS30, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4368
PS30, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4381
PS30, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4418
PS30, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4425
PS30, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4433
PS30, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4436
PS30, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4448
PS30, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4451
PS30, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4497
PS30, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4501
PS30, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4513
PS30, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4515
PS30, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4517
PS30, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4527
PS30, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4532
PS30, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4534
PS30, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4541
PS30, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4615
PS30, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4672
PS30, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4694
PS30, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4703
PS30, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4709
PS30, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4711
PS30, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4714
PS30, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4736
PS30, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4741
PS30, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4749
PS30, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4780
PS30, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4827
PS30, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4838
PS30, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4873
PS30, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4894
PS30, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4918
PS30, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4936
PS30, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4947
PS30, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4956
PS30, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4974
PS30, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4979
PS30, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4980
PS30, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@4983
PS30, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5004
PS30, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5030
PS30, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5049
PS30, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5169
PS30, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5225
PS30, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5235
PS30, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5243
PS30, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5247
PS30, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5258
PS30, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5260
PS30, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5262
PS30, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5279
PS30, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5321
PS30, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5352
PS30, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5356
PS30, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/be/src/thirdparty/xxhash/xxhash.h@5363
PS30, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/30/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/30/common/thrift/parquet.thrift@656
PS30, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 30
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 May 2021 12:57:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 13:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8321/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 13
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 19:08:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 35:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@70
PS35, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@92
PS35, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@113
PS35, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@243
PS35, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@253
PS35, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@254
PS35, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@270
PS35, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@429
PS35, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@441
PS35, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@476
PS35, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@628
PS35, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@631
PS35, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@700
PS35, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@724
PS35, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@743
PS35, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@756
PS35, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@766
PS35, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@768
PS35, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@791
PS35, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@792
PS35, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@808
PS35, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@809
PS35, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@811
PS35, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@881
PS35, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@886
PS35, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@888
PS35, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@912
PS35, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@915
PS35, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@977
PS35, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1028
PS35, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1029
PS35, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1046
PS35, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1052
PS35, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1257
PS35, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1258
PS35, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1686
PS35, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1707
PS35, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1708
PS35, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1709
PS35, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1710
PS35, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1711
PS35, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1771
PS35, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1953
PS35, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1960
PS35, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1986
PS35, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@1994
PS35, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2030
PS35, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2155
PS35, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2158
PS35, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2174
PS35, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2278
PS35, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2289
PS35, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2290
PS35, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2291
PS35, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2292
PS35, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2293
PS35, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2494
PS35, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2514
PS35, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2521
PS35, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2545
PS35, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2553
PS35, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2587
PS35, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2637
PS35, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2648
PS35, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@2852
PS35, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3010
PS35, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3011
PS35, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3012
PS35, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3013
PS35, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3014
PS35, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3015
PS35, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3016
PS35, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3017
PS35, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3020
PS35, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3021
PS35, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3022
PS35, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3023
PS35, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3062
PS35, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3110
PS35, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3137
PS35, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3138
PS35, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3140
PS35, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3141
PS35, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3160
PS35, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3161
PS35, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3162
PS35, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3163
PS35, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3164
PS35, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3165
PS35, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3166
PS35, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3167
PS35, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3168
PS35, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3169
PS35, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3170
PS35, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3171
PS35, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3419
PS35, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3441
PS35, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3457
PS35, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3462
PS35, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3463
PS35, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3474
PS35, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3480
PS35, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3618
PS35, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3621
PS35, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3705
PS35, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3709
PS35, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3754
PS35, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3769
PS35, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3782
PS35, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3818
PS35, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3822
PS35, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3850
PS35, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3858
PS35, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3865
PS35, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3926
PS35, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3958
PS35, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@3966
PS35, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4101
PS35, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4102
PS35, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4113
PS35, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4136
PS35, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4148
PS35, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4181
PS35, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4346
PS35, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4367
PS35, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4368
PS35, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4381
PS35, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4418
PS35, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4425
PS35, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4433
PS35, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4436
PS35, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4448
PS35, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4451
PS35, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4497
PS35, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4501
PS35, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4513
PS35, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4515
PS35, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4517
PS35, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4527
PS35, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4532
PS35, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4534
PS35, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4541
PS35, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4615
PS35, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4672
PS35, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4694
PS35, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4703
PS35, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4709
PS35, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4711
PS35, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4714
PS35, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4736
PS35, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4741
PS35, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4749
PS35, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4780
PS35, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4827
PS35, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4838
PS35, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4873
PS35, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4894
PS35, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4918
PS35, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4936
PS35, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4947
PS35, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4956
PS35, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4974
PS35, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4979
PS35, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4980
PS35, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@4983
PS35, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5004
PS35, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5030
PS35, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5049
PS35, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5169
PS35, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5225
PS35, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5235
PS35, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5243
PS35, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5247
PS35, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5258
PS35, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5260
PS35, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5262
PS35, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5279
PS35, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5321
PS35, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5352
PS35, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5356
PS35, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/be/src/thirdparty/xxhash/xxhash.h@5363
PS35, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/35/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/35/common/thrift/parquet.thrift@656
PS35, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 35
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 May 2021 15:55:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 32:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8757/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 32
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 May 2021 13:10:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 17:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8349/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 17
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Mar 2021 11:21:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 30:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8729/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 30
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 May 2021 13:18:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#23). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
IMPALA-9470: Use Parquet Bloom filters - Part 1
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
33 files changed, 7,133 insertions(+), 139 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/23
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 23
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 18:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/exec/parquet/parquet-bloom-filter-util.cc
File be/src/exec/parquet/parquet-bloom-filter-util.cc:
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/exec/parquet/parquet-bloom-filter-util.cc@170
PS18, Line 170: const int exp_size = sizeof(double);
: storage->resize(exp_size);
Resizing could be moved inside ParquetBloomFilterEncodeValue to make the call sites more compact. So this could look like ParquetBloomFilterEncodeValue<double>(value, storage, sizeof(double));
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 18
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Mar 2021 08:23:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
IMPALA-9470: Use Parquet Bloom filters - Part 1
This change adds read support for Parquet Bloom filters for some types.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests that
Parquet Bloom filtering works for the supported types and that we do
not incorrectly discard row groups for the unsupported type VARCHAR.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/parquet.thrift
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
27 files changed, 6,910 insertions(+), 132 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/17
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 17
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
IMPALA-9470: Use Parquet Bloom filters - Part 1
This change adds read support for Parquet Bloom filters for some types.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests that
Parquet Bloom filtering works for the supported types and that we do
not incorrectly discard row groups for the unsupported type VARCHAR.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/parquet.thrift
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
27 files changed, 6,823 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/13
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 13
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#32). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
IMPALA-10640: Support reading Parquet Bloom filters - most common types
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
The following types are not supported for the given reasons:
----------------------------------------------------------------
|Impala type | Problem |
|----------------------------------------------------------------|
|VARCHAR(N) | truncation can change hash |
|CHAR(N) | padding / truncation can change hash |
|DECIMAL | multiple encodings supported |
|TIMESTAMP | multiple encodings supported, timezone conversion |
|DATE | not considered yet |
----------------------------------------------------------------
Support may be added for these types later, see IMPALA-10641.
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-avx2.cc
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/jenkins/critique-gerrit-review.py
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter-disabled.test
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
37 files changed, 7,327 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/32
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 32
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 23:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@70
PS23, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@92
PS23, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@113
PS23, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@243
PS23, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@253
PS23, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@254
PS23, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@270
PS23, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@429
PS23, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@441
PS23, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@476
PS23, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@628
PS23, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@631
PS23, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@700
PS23, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@724
PS23, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@743
PS23, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@756
PS23, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@766
PS23, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@768
PS23, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@791
PS23, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@792
PS23, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@808
PS23, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@809
PS23, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@811
PS23, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@881
PS23, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@886
PS23, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@888
PS23, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@912
PS23, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@915
PS23, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@977
PS23, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1028
PS23, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1029
PS23, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1046
PS23, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1052
PS23, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1257
PS23, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1258
PS23, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1686
PS23, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1707
PS23, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1708
PS23, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1709
PS23, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1710
PS23, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1711
PS23, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1771
PS23, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1953
PS23, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1960
PS23, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1986
PS23, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1994
PS23, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2030
PS23, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2155
PS23, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2158
PS23, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2174
PS23, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2278
PS23, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2289
PS23, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2290
PS23, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2291
PS23, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2292
PS23, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2293
PS23, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2494
PS23, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2514
PS23, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2521
PS23, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2545
PS23, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2553
PS23, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2587
PS23, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2637
PS23, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2648
PS23, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@2852
PS23, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3010
PS23, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3011
PS23, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3012
PS23, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3013
PS23, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3014
PS23, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3015
PS23, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3016
PS23, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3017
PS23, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3020
PS23, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3021
PS23, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3022
PS23, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3023
PS23, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3062
PS23, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3110
PS23, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3137
PS23, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3138
PS23, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3140
PS23, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3141
PS23, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3160
PS23, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3161
PS23, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3162
PS23, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3163
PS23, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3164
PS23, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3165
PS23, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3166
PS23, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3167
PS23, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3168
PS23, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3169
PS23, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3170
PS23, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3171
PS23, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3419
PS23, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3441
PS23, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3457
PS23, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3462
PS23, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3463
PS23, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3474
PS23, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3480
PS23, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3618
PS23, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3621
PS23, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3705
PS23, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3709
PS23, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3754
PS23, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3769
PS23, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3782
PS23, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3818
PS23, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3822
PS23, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3850
PS23, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3858
PS23, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3865
PS23, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3926
PS23, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3958
PS23, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@3966
PS23, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4101
PS23, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4102
PS23, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4113
PS23, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4136
PS23, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4148
PS23, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4181
PS23, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4346
PS23, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4367
PS23, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4368
PS23, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4381
PS23, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4418
PS23, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4425
PS23, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4433
PS23, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4436
PS23, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4448
PS23, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4451
PS23, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4497
PS23, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4501
PS23, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4513
PS23, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4515
PS23, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4517
PS23, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4527
PS23, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4532
PS23, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4534
PS23, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4541
PS23, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4615
PS23, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4672
PS23, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4694
PS23, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4703
PS23, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4709
PS23, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4711
PS23, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4714
PS23, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4736
PS23, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4741
PS23, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4749
PS23, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4780
PS23, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4827
PS23, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4838
PS23, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4873
PS23, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4894
PS23, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4918
PS23, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4936
PS23, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4947
PS23, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4956
PS23, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4974
PS23, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4979
PS23, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4980
PS23, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@4983
PS23, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5004
PS23, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5030
PS23, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5049
PS23, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5169
PS23, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5225
PS23, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5235
PS23, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5243
PS23, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5247
PS23, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5258
PS23, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5260
PS23, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5262
PS23, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5279
PS23, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5321
PS23, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5352
PS23, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5356
PS23, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@5363
PS23, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/23/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/23/common/thrift/parquet.thrift@656
PS23, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 23
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 10:06:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 27:
The problem seems to be with this test: tests/failure/test_failpoints.py::TestFailpoints::test_failpoints, and this query in particular:
SET mt_dop=4;
SET batch_size=0;
SET num_nodes=0;
SET disable_codegen_rows_threshold=0;
SET disable_codegen=False;
SET abort_on_error=1;
SET exec_single_node_rows_threshold=0;
SET debug_action=0:PREPARE_SCANNER:MEM_LIMIT_EXCEEDED|COORD_BEFORE_EXEC_RPC:JITTER@100@0.3;
SELECT STRAIGHT_JOIN *
FROM functional_kudu.alltypes t1
JOIN /*+broadcast*/ functional_kudu.alltypesagg t2 ON t1.id = t2.id
WHERE t2.int_col < 1000;
It seems that when reading a Kudu table, the code for kudu::BlockBloomFilter may come from different places
- from the Kudu (binary?) dependency and
- be/src/kudu/util/block_bloom_filter.h
The crash happens because an assert in Kudu as kudu::BlockBloomFilter::hash_algorithm_ has an invalid value.
I think it is caused by binary incompatibility between our modified kudu::BlockBloomFilter and the original one, used in Kudu. I have added two fields just before kudu::BlockBloomFilter::hash_algorithm_ and probably that data is treated as if it were the hash_algorithm_ field by the original Kudu code. When I put the new fields to the end of the class, the crash doesn't happen.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 27
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Apr 2021 15:50:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 27: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 27
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Apr 2021 13:41:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 36:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8821/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 36
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Jun 2021 10:18:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 35: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7180/
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 35
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 May 2021 21:28:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 36:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@70
PS36, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@92
PS36, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@113
PS36, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@243
PS36, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@253
PS36, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@254
PS36, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@270
PS36, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@429
PS36, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@441
PS36, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@476
PS36, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@628
PS36, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@631
PS36, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@700
PS36, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@724
PS36, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@743
PS36, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@756
PS36, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@766
PS36, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@768
PS36, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@791
PS36, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@792
PS36, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@808
PS36, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@809
PS36, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@811
PS36, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@881
PS36, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@886
PS36, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@888
PS36, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@912
PS36, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@915
PS36, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@977
PS36, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1028
PS36, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1029
PS36, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1046
PS36, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1052
PS36, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1257
PS36, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1258
PS36, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1686
PS36, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1707
PS36, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1708
PS36, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1709
PS36, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1710
PS36, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1711
PS36, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1771
PS36, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1953
PS36, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1960
PS36, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1986
PS36, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@1994
PS36, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2030
PS36, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2155
PS36, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2158
PS36, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2174
PS36, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2278
PS36, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2289
PS36, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2290
PS36, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2291
PS36, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2292
PS36, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2293
PS36, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2494
PS36, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2514
PS36, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2521
PS36, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2545
PS36, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2553
PS36, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2587
PS36, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2637
PS36, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2648
PS36, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@2852
PS36, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3010
PS36, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3011
PS36, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3012
PS36, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3013
PS36, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3014
PS36, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3015
PS36, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3016
PS36, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3017
PS36, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3020
PS36, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3021
PS36, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3022
PS36, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3023
PS36, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3062
PS36, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3110
PS36, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3137
PS36, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3138
PS36, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3140
PS36, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3141
PS36, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3160
PS36, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3161
PS36, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3162
PS36, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3163
PS36, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3164
PS36, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3165
PS36, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3166
PS36, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3167
PS36, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3168
PS36, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3169
PS36, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3170
PS36, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3171
PS36, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3419
PS36, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3441
PS36, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3457
PS36, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3462
PS36, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3463
PS36, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3474
PS36, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3480
PS36, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3618
PS36, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3621
PS36, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3705
PS36, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3709
PS36, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3754
PS36, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3769
PS36, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3782
PS36, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3818
PS36, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3822
PS36, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3850
PS36, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3858
PS36, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3865
PS36, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3926
PS36, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3958
PS36, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@3966
PS36, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4101
PS36, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4102
PS36, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4113
PS36, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4136
PS36, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4148
PS36, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4181
PS36, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4346
PS36, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4367
PS36, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4368
PS36, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4381
PS36, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4418
PS36, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4425
PS36, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4433
PS36, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4436
PS36, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4448
PS36, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4451
PS36, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4497
PS36, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4501
PS36, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4513
PS36, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4515
PS36, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4517
PS36, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4527
PS36, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4532
PS36, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4534
PS36, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4541
PS36, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4615
PS36, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4672
PS36, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4694
PS36, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4703
PS36, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4709
PS36, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4711
PS36, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4714
PS36, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4736
PS36, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4741
PS36, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4749
PS36, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4780
PS36, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4827
PS36, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4838
PS36, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4873
PS36, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4894
PS36, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4918
PS36, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4936
PS36, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4947
PS36, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4956
PS36, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4974
PS36, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4979
PS36, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4980
PS36, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@4983
PS36, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5004
PS36, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5030
PS36, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5049
PS36, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5169
PS36, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5225
PS36, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5235
PS36, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5243
PS36, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5247
PS36, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5258
PS36, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5260
PS36, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5262
PS36, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5279
PS36, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5321
PS36, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5352
PS36, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5356
PS36, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/be/src/thirdparty/xxhash/xxhash.h@5363
PS36, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/36/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/36/common/thrift/parquet.thrift@656
PS36, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 36
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Jun 2021 09:57:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 26: Code-Review+2
(2 comments)
Great work, Daniel!
http://gerrit.cloudera.org:8080/#/c/17026/24//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17026/24//COMMIT_MSG@7
PS24, Line 7: IMPALA-10640: Support reading Parquet Bloom filters - most common types
> No, I don't think we are planning to add filtering for complex types.
Yeah, I was thinking about leaf values inside complex types. I'm OK with deferring it. Probably it worth to open a Jira for it.
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/parquet-bloom-filter.cc
File be/src/util/parquet-bloom-filter.cc:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/parquet-bloom-filter.cc@18
PS23, Line 18: #include "parquet-bloom-filter.h"
:
: #include <cmath>
: #include <cstdint>
:
: #include "kudu/util/slice.h"
: #include "kudu/util/status.h"
: #include "util/kudu-status-util.h"
:
: #include "thirdparty/xxhash/xxhash.h"
> Isn't the first include in a .cc file usually the corresponding .h file? Se
Yeah, I think the include order is fine.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 26
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Apr 2021 13:40:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 19:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@70
PS19, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@92
PS19, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@113
PS19, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@243
PS19, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@253
PS19, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@254
PS19, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@270
PS19, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@429
PS19, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@441
PS19, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@476
PS19, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@628
PS19, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@631
PS19, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@700
PS19, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@724
PS19, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@743
PS19, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@756
PS19, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@766
PS19, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@768
PS19, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@791
PS19, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@792
PS19, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@808
PS19, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@809
PS19, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@811
PS19, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@881
PS19, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@886
PS19, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@888
PS19, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@912
PS19, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@915
PS19, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@977
PS19, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1028
PS19, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1029
PS19, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1046
PS19, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1052
PS19, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1257
PS19, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1258
PS19, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1686
PS19, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1707
PS19, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1708
PS19, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1709
PS19, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1710
PS19, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1711
PS19, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1771
PS19, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1953
PS19, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1960
PS19, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1986
PS19, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@1994
PS19, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2030
PS19, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2155
PS19, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2158
PS19, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2174
PS19, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2278
PS19, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2289
PS19, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2290
PS19, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2291
PS19, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2292
PS19, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2293
PS19, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2494
PS19, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2514
PS19, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2521
PS19, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2545
PS19, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2553
PS19, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2587
PS19, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2637
PS19, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2648
PS19, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@2852
PS19, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3010
PS19, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3011
PS19, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3012
PS19, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3013
PS19, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3014
PS19, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3015
PS19, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3016
PS19, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3017
PS19, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3020
PS19, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3021
PS19, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3022
PS19, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3023
PS19, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3062
PS19, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3110
PS19, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3137
PS19, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3138
PS19, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3140
PS19, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3141
PS19, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3160
PS19, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3161
PS19, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3162
PS19, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3163
PS19, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3164
PS19, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3165
PS19, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3166
PS19, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3167
PS19, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3168
PS19, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3169
PS19, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3170
PS19, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3171
PS19, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3419
PS19, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3441
PS19, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3457
PS19, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3462
PS19, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3463
PS19, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3474
PS19, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3480
PS19, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3618
PS19, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3621
PS19, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3705
PS19, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3709
PS19, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3754
PS19, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3769
PS19, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3782
PS19, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3818
PS19, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3822
PS19, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3850
PS19, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3858
PS19, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3865
PS19, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3926
PS19, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3958
PS19, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@3966
PS19, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4101
PS19, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4102
PS19, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4113
PS19, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4136
PS19, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4148
PS19, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4181
PS19, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4346
PS19, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4367
PS19, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4368
PS19, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4381
PS19, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4418
PS19, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4425
PS19, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4433
PS19, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4436
PS19, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4448
PS19, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4451
PS19, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4497
PS19, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4501
PS19, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4513
PS19, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4515
PS19, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4517
PS19, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4527
PS19, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4532
PS19, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4534
PS19, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4541
PS19, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4615
PS19, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4672
PS19, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4694
PS19, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4703
PS19, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4709
PS19, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4711
PS19, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4714
PS19, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4736
PS19, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4741
PS19, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4749
PS19, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4780
PS19, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4827
PS19, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4838
PS19, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4873
PS19, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4894
PS19, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4918
PS19, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4936
PS19, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4947
PS19, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4956
PS19, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4974
PS19, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4979
PS19, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4980
PS19, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@4983
PS19, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5004
PS19, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5030
PS19, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5049
PS19, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5169
PS19, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5225
PS19, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5235
PS19, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5243
PS19, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5247
PS19, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5258
PS19, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5260
PS19, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5262
PS19, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5279
PS19, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5321
PS19, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5352
PS19, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5356
PS19, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/be/src/thirdparty/xxhash/xxhash.h@5363
PS19, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/19/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/19/common/thrift/parquet.thrift@656
PS19, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 19
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Mar 2021 15:10:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 22:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@70
PS22, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@92
PS22, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@113
PS22, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@243
PS22, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@253
PS22, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@254
PS22, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@270
PS22, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@429
PS22, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@441
PS22, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@476
PS22, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@628
PS22, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@631
PS22, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@700
PS22, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@724
PS22, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@743
PS22, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@756
PS22, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@766
PS22, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@768
PS22, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@791
PS22, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@792
PS22, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@808
PS22, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@809
PS22, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@811
PS22, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@881
PS22, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@886
PS22, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@888
PS22, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@912
PS22, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@915
PS22, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@977
PS22, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1028
PS22, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1029
PS22, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1046
PS22, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1052
PS22, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1257
PS22, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1258
PS22, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1686
PS22, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1707
PS22, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1708
PS22, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1709
PS22, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1710
PS22, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1711
PS22, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1771
PS22, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1953
PS22, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1960
PS22, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1986
PS22, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@1994
PS22, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2030
PS22, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2155
PS22, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2158
PS22, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2174
PS22, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2278
PS22, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2289
PS22, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2290
PS22, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2291
PS22, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2292
PS22, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2293
PS22, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2494
PS22, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2514
PS22, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2521
PS22, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2545
PS22, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2553
PS22, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2587
PS22, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2637
PS22, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2648
PS22, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@2852
PS22, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3010
PS22, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3011
PS22, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3012
PS22, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3013
PS22, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3014
PS22, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3015
PS22, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3016
PS22, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3017
PS22, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3020
PS22, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3021
PS22, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3022
PS22, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3023
PS22, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3062
PS22, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3110
PS22, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3137
PS22, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3138
PS22, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3140
PS22, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3141
PS22, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3160
PS22, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3161
PS22, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3162
PS22, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3163
PS22, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3164
PS22, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3165
PS22, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3166
PS22, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3167
PS22, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3168
PS22, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3169
PS22, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3170
PS22, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3171
PS22, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3419
PS22, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3441
PS22, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3457
PS22, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3462
PS22, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3463
PS22, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3474
PS22, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3480
PS22, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3618
PS22, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3621
PS22, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3705
PS22, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3709
PS22, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3754
PS22, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3769
PS22, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3782
PS22, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3818
PS22, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3822
PS22, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3850
PS22, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3858
PS22, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3865
PS22, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3926
PS22, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3958
PS22, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@3966
PS22, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4101
PS22, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4102
PS22, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4113
PS22, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4136
PS22, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4148
PS22, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4181
PS22, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4346
PS22, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4367
PS22, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4368
PS22, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4381
PS22, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4418
PS22, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4425
PS22, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4433
PS22, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4436
PS22, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4448
PS22, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4451
PS22, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4497
PS22, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4501
PS22, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4513
PS22, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4515
PS22, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4517
PS22, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4527
PS22, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4532
PS22, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4534
PS22, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4541
PS22, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4615
PS22, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4672
PS22, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4694
PS22, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4703
PS22, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4709
PS22, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4711
PS22, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4714
PS22, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4736
PS22, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4741
PS22, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4749
PS22, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4780
PS22, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4827
PS22, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4838
PS22, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4873
PS22, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4894
PS22, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4918
PS22, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4936
PS22, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4947
PS22, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4956
PS22, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4974
PS22, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4979
PS22, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4980
PS22, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@4983
PS22, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5004
PS22, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5030
PS22, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5049
PS22, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5169
PS22, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5225
PS22, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5235
PS22, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5243
PS22, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5247
PS22, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5258
PS22, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5260
PS22, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5262
PS22, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5279
PS22, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5321
PS22, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5352
PS22, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5356
PS22, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/be/src/thirdparty/xxhash/xxhash.h@5363
PS22, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/22/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/22/common/thrift/parquet.thrift@656
PS22, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 22
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 22:42:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 24:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8512/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 24
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Apr 2021 10:39:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#29). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
IMPALA-10640: Support reading Parquet Bloom filters - most common types
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
The following types are not supported for the given reasons:
----------------------------------------------------------------
|Impala type | Problem |
|----------------------------------------------------------------|
|VARCHAR(N) | truncation can change hash |
|CHAR(N) | padding / truncation can change hash |
|DECIMAL | multiple encodings supported |
|TIMESTAMP | multiple encodings supported, timezone conversion |
|DATE | not considered yet |
----------------------------------------------------------------
Support may be added for these types later, see IMPALA-10641.
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-avx2.cc
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/jenkins/critique-gerrit-review.py
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter-disabled.test
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
37 files changed, 7,410 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/29
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 29
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 16:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@70
PS16, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@92
PS16, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@113
PS16, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@243
PS16, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@253
PS16, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@254
PS16, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@270
PS16, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@429
PS16, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@441
PS16, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@476
PS16, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@628
PS16, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@631
PS16, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@700
PS16, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@724
PS16, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@743
PS16, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@756
PS16, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@766
PS16, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@768
PS16, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@791
PS16, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@792
PS16, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@808
PS16, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@809
PS16, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@811
PS16, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@881
PS16, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@886
PS16, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@888
PS16, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@912
PS16, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@915
PS16, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@977
PS16, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1028
PS16, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1029
PS16, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1046
PS16, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1052
PS16, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1257
PS16, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1258
PS16, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1686
PS16, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1707
PS16, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1708
PS16, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1709
PS16, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1710
PS16, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1711
PS16, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1771
PS16, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1953
PS16, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1960
PS16, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1986
PS16, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@1994
PS16, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2030
PS16, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2155
PS16, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2158
PS16, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2174
PS16, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2278
PS16, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2289
PS16, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2290
PS16, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2291
PS16, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2292
PS16, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2293
PS16, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2494
PS16, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2514
PS16, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2521
PS16, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2545
PS16, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2553
PS16, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2587
PS16, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2637
PS16, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2648
PS16, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@2852
PS16, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3010
PS16, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3011
PS16, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3012
PS16, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3013
PS16, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3014
PS16, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3015
PS16, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3016
PS16, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3017
PS16, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3020
PS16, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3021
PS16, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3022
PS16, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3023
PS16, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3062
PS16, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3110
PS16, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3137
PS16, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3138
PS16, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3140
PS16, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3141
PS16, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3160
PS16, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3161
PS16, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3162
PS16, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3163
PS16, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3164
PS16, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3165
PS16, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3166
PS16, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3167
PS16, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3168
PS16, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3169
PS16, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3170
PS16, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3171
PS16, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3419
PS16, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3441
PS16, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3457
PS16, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3462
PS16, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3463
PS16, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3474
PS16, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3480
PS16, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3618
PS16, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3621
PS16, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3705
PS16, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3709
PS16, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3754
PS16, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3769
PS16, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3782
PS16, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3818
PS16, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3822
PS16, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3850
PS16, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3858
PS16, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3865
PS16, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3926
PS16, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3958
PS16, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@3966
PS16, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4101
PS16, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4102
PS16, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4113
PS16, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4136
PS16, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4148
PS16, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4181
PS16, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4346
PS16, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4367
PS16, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4368
PS16, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4381
PS16, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4418
PS16, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4425
PS16, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4433
PS16, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4436
PS16, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4448
PS16, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4451
PS16, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4497
PS16, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4501
PS16, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4513
PS16, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4515
PS16, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4517
PS16, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4527
PS16, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4532
PS16, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4534
PS16, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4541
PS16, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4615
PS16, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4672
PS16, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4694
PS16, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4703
PS16, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4709
PS16, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4711
PS16, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4714
PS16, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4736
PS16, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4741
PS16, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4749
PS16, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4780
PS16, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4827
PS16, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4838
PS16, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4873
PS16, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4894
PS16, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4918
PS16, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4936
PS16, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4947
PS16, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4956
PS16, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4974
PS16, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4979
PS16, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4980
PS16, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@4983
PS16, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5004
PS16, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5030
PS16, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5049
PS16, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5169
PS16, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5225
PS16, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5235
PS16, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5243
PS16, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5247
PS16, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5258
PS16, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5260
PS16, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5262
PS16, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5279
PS16, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5321
PS16, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5352
PS16, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5356
PS16, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/be/src/thirdparty/xxhash/xxhash.h@5363
PS16, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/16/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/16/common/thrift/parquet.thrift@656
PS16, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 16
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Mar 2021 13:25:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 38:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8833/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 38
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Jun 2021 15:12:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 40:
Submitting manually.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 40
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Jun 2021 06:32:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 14:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@70
PS14, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@92
PS14, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@113
PS14, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@243
PS14, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@253
PS14, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@254
PS14, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@270
PS14, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@429
PS14, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@441
PS14, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@476
PS14, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@628
PS14, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@631
PS14, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@700
PS14, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@724
PS14, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@743
PS14, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@756
PS14, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@766
PS14, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@768
PS14, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@791
PS14, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@792
PS14, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@808
PS14, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@809
PS14, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@811
PS14, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@881
PS14, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@886
PS14, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@888
PS14, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@912
PS14, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@915
PS14, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@977
PS14, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1028
PS14, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1029
PS14, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1046
PS14, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1052
PS14, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1257
PS14, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1258
PS14, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1686
PS14, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1707
PS14, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1708
PS14, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1709
PS14, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1710
PS14, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1711
PS14, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1771
PS14, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1953
PS14, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1960
PS14, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1986
PS14, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@1994
PS14, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2030
PS14, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2155
PS14, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2158
PS14, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2174
PS14, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2278
PS14, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2289
PS14, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2290
PS14, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2291
PS14, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2292
PS14, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2293
PS14, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2494
PS14, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2514
PS14, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2521
PS14, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2545
PS14, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2553
PS14, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2587
PS14, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2637
PS14, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2648
PS14, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@2852
PS14, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3010
PS14, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3011
PS14, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3012
PS14, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3013
PS14, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3014
PS14, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3015
PS14, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3016
PS14, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3017
PS14, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3020
PS14, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3021
PS14, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3022
PS14, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3023
PS14, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3062
PS14, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3110
PS14, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3137
PS14, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3138
PS14, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3140
PS14, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3141
PS14, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3160
PS14, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3161
PS14, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3162
PS14, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3163
PS14, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3164
PS14, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3165
PS14, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3166
PS14, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3167
PS14, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3168
PS14, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3169
PS14, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3170
PS14, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3171
PS14, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3419
PS14, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3441
PS14, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3457
PS14, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3462
PS14, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3463
PS14, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3474
PS14, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3480
PS14, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3618
PS14, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3621
PS14, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3705
PS14, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3709
PS14, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3754
PS14, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3769
PS14, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3782
PS14, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3818
PS14, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3822
PS14, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3850
PS14, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3858
PS14, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3865
PS14, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3926
PS14, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3958
PS14, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@3966
PS14, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4101
PS14, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4102
PS14, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4113
PS14, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4136
PS14, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4148
PS14, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4181
PS14, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4346
PS14, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4367
PS14, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4368
PS14, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4381
PS14, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4418
PS14, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4425
PS14, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4433
PS14, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4436
PS14, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4448
PS14, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4451
PS14, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4497
PS14, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4501
PS14, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4513
PS14, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4515
PS14, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4517
PS14, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4527
PS14, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4532
PS14, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4534
PS14, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4541
PS14, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4615
PS14, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4672
PS14, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4694
PS14, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4703
PS14, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4709
PS14, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4711
PS14, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4714
PS14, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4736
PS14, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4741
PS14, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4749
PS14, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4780
PS14, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4827
PS14, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4838
PS14, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4873
PS14, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4894
PS14, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4918
PS14, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4936
PS14, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4947
PS14, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4956
PS14, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4974
PS14, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4979
PS14, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4980
PS14, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@4983
PS14, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5004
PS14, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5030
PS14, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5049
PS14, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5169
PS14, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5225
PS14, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5235
PS14, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5243
PS14, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5247
PS14, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5258
PS14, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5260
PS14, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5262
PS14, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5279
PS14, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5321
PS14, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5352
PS14, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5356
PS14, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/be/src/thirdparty/xxhash/xxhash.h@5363
PS14, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/14/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/14/common/thrift/parquet.thrift@656
PS14, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 14
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 22:20:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 15:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8328/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 15
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Mar 2021 11:52:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#22). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
IMPALA-9470: Use Parquet Bloom filters - Part 1
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
33 files changed, 7,133 insertions(+), 139 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/22
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 22
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 39:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7188/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 39
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Jun 2021 14:56:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 18:
(184 comments)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/exec/parquet/parquet-bloom-filter-util.cc
File be/src/exec/parquet/parquet-bloom-filter-util.cc:
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/exec/parquet/parquet-bloom-filter-util.cc@218
PS18, Line 218: ScalarExprEvaluator* eval, const parquet::Type::type& parquet_type, vector<uint8_t>* storage,
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@70
PS18, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@92
PS18, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@113
PS18, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@243
PS18, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@253
PS18, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@254
PS18, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@270
PS18, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@429
PS18, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@441
PS18, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@476
PS18, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@628
PS18, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@631
PS18, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@700
PS18, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@724
PS18, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@743
PS18, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@756
PS18, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@766
PS18, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@768
PS18, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@791
PS18, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@792
PS18, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@808
PS18, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@809
PS18, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@811
PS18, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@881
PS18, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@886
PS18, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@888
PS18, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@912
PS18, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@915
PS18, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@977
PS18, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1028
PS18, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1029
PS18, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1046
PS18, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1052
PS18, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1257
PS18, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1258
PS18, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1686
PS18, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1707
PS18, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1708
PS18, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1709
PS18, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1710
PS18, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1711
PS18, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1771
PS18, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1953
PS18, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1960
PS18, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1986
PS18, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@1994
PS18, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2030
PS18, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2155
PS18, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2158
PS18, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2174
PS18, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2278
PS18, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2289
PS18, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2290
PS18, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2291
PS18, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2292
PS18, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2293
PS18, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2494
PS18, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2514
PS18, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2521
PS18, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2545
PS18, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2553
PS18, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2587
PS18, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2637
PS18, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2648
PS18, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@2852
PS18, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3010
PS18, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3011
PS18, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3012
PS18, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3013
PS18, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3014
PS18, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3015
PS18, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3016
PS18, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3017
PS18, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3020
PS18, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3021
PS18, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3022
PS18, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3023
PS18, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3062
PS18, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3110
PS18, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3137
PS18, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3138
PS18, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3140
PS18, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3141
PS18, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3160
PS18, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3161
PS18, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3162
PS18, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3163
PS18, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3164
PS18, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3165
PS18, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3166
PS18, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3167
PS18, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3168
PS18, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3169
PS18, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3170
PS18, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3171
PS18, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3419
PS18, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3441
PS18, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3457
PS18, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3462
PS18, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3463
PS18, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3474
PS18, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3480
PS18, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3618
PS18, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3621
PS18, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3705
PS18, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3709
PS18, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3754
PS18, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3769
PS18, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3782
PS18, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3818
PS18, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3822
PS18, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3850
PS18, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3858
PS18, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3865
PS18, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3926
PS18, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3958
PS18, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@3966
PS18, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4101
PS18, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4102
PS18, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4113
PS18, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4136
PS18, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4148
PS18, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4181
PS18, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4346
PS18, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4367
PS18, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4368
PS18, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4381
PS18, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4418
PS18, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4425
PS18, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4433
PS18, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4436
PS18, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4448
PS18, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4451
PS18, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4497
PS18, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4501
PS18, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4513
PS18, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4515
PS18, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4517
PS18, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4527
PS18, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4532
PS18, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4534
PS18, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4541
PS18, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4615
PS18, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4672
PS18, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4694
PS18, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4703
PS18, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4709
PS18, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4711
PS18, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4714
PS18, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4736
PS18, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4741
PS18, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4749
PS18, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4780
PS18, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4827
PS18, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4838
PS18, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4873
PS18, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4894
PS18, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4918
PS18, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4936
PS18, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4947
PS18, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4956
PS18, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4974
PS18, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4979
PS18, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4980
PS18, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@4983
PS18, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5004
PS18, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5030
PS18, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5049
PS18, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5169
PS18, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5225
PS18, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5235
PS18, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5243
PS18, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5247
PS18, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5258
PS18, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5260
PS18, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5262
PS18, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5279
PS18, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5321
PS18, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5352
PS18, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5356
PS18, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/thirdparty/xxhash/xxhash.h@5363
PS18, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/util/parquet-bloom-filter.cc
File be/src/util/parquet-bloom-filter.cc:
http://gerrit.cloudera.org:8080/#/c/17026/18/be/src/util/parquet-bloom-filter.cc@51
PS18, Line 51: log_space_bytes, slice, false, kudu::FAST_HASH, hash_seed, use_separate_bucket_hash),
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/18/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/18/common/thrift/parquet.thrift@656
PS18, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 18
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Mar 2021 16:36:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 39:
The only failed test is TestFetchAndSpooling.test_rows_sent_counters which is totally unrelated to this change and was known to be flaky in the past (it should be fixed though, see IMPALA-8957)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 39
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Jun 2021 06:23:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 12:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@70
PS12, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@92
PS12, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@113
PS12, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@243
PS12, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@253
PS12, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@254
PS12, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@270
PS12, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@429
PS12, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@441
PS12, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@476
PS12, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@628
PS12, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@631
PS12, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@700
PS12, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@724
PS12, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@743
PS12, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@756
PS12, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@766
PS12, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@768
PS12, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@791
PS12, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@792
PS12, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@808
PS12, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@809
PS12, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@811
PS12, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@881
PS12, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@886
PS12, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@888
PS12, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@912
PS12, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@915
PS12, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@977
PS12, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1028
PS12, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1029
PS12, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1046
PS12, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1052
PS12, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1257
PS12, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1258
PS12, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1686
PS12, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1707
PS12, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1708
PS12, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1709
PS12, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1710
PS12, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1711
PS12, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1771
PS12, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1953
PS12, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1960
PS12, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1986
PS12, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@1994
PS12, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2030
PS12, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2155
PS12, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2158
PS12, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2174
PS12, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2278
PS12, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2289
PS12, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2290
PS12, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2291
PS12, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2292
PS12, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2293
PS12, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2494
PS12, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2514
PS12, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2521
PS12, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2545
PS12, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2553
PS12, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2587
PS12, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2637
PS12, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2648
PS12, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@2852
PS12, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3010
PS12, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3011
PS12, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3012
PS12, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3013
PS12, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3014
PS12, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3015
PS12, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3016
PS12, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3017
PS12, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3020
PS12, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3021
PS12, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3022
PS12, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3023
PS12, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3062
PS12, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3110
PS12, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3137
PS12, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3138
PS12, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3140
PS12, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3141
PS12, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3160
PS12, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3161
PS12, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3162
PS12, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3163
PS12, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3164
PS12, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3165
PS12, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3166
PS12, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3167
PS12, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3168
PS12, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3169
PS12, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3170
PS12, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3171
PS12, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3419
PS12, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3441
PS12, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3457
PS12, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3462
PS12, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3463
PS12, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3474
PS12, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3480
PS12, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3618
PS12, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3621
PS12, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3705
PS12, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3709
PS12, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3754
PS12, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3769
PS12, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3782
PS12, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3818
PS12, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3822
PS12, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3850
PS12, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3858
PS12, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3865
PS12, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3926
PS12, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3958
PS12, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@3966
PS12, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4101
PS12, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4102
PS12, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4113
PS12, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4136
PS12, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4148
PS12, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4181
PS12, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4346
PS12, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4367
PS12, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4368
PS12, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4381
PS12, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4418
PS12, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4425
PS12, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4433
PS12, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4436
PS12, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4448
PS12, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4451
PS12, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4497
PS12, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4501
PS12, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4513
PS12, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4515
PS12, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4517
PS12, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4527
PS12, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4532
PS12, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4534
PS12, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4541
PS12, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4615
PS12, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4672
PS12, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4694
PS12, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4703
PS12, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4709
PS12, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4711
PS12, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4714
PS12, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4736
PS12, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4741
PS12, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4749
PS12, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4780
PS12, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4827
PS12, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4838
PS12, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4873
PS12, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4894
PS12, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4918
PS12, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4936
PS12, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4947
PS12, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4956
PS12, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4974
PS12, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4979
PS12, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4980
PS12, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@4983
PS12, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5004
PS12, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5030
PS12, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5049
PS12, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5169
PS12, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5225
PS12, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5235
PS12, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5243
PS12, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5247
PS12, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5258
PS12, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5260
PS12, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5262
PS12, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5279
PS12, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5321
PS12, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5352
PS12, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5356
PS12, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/be/src/thirdparty/xxhash/xxhash.h@5363
PS12, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/12/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/12/common/thrift/parquet.thrift@656
PS12, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 12
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Mar 2021 16:39:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
IMPALA-10640: Support reading Parquet Bloom filters - most common types
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
The following types are not supported for the given reasons:
----------------------------------------------------------------
|Impala type | Problem |
|----------------------------------------------------------------|
|VARCHAR(N) | truncation can change hash |
|CHAR(N) | padding / truncation can change hash |
|DECIMAL | multiple encodings supported |
|TIMESTAMP | multiple encodings supported, timezone conversion |
|DATE | not considered yet |
----------------------------------------------------------------
Support may be added for these types later, see IMPALA-10641.
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Reviewed-on: http://gerrit.cloudera.org:8080/17026
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Csaba Ringhofer <cs...@cloudera.com>
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/jenkins/critique-gerrit-review.py
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter-disabled.test
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
36 files changed, 7,310 insertions(+), 125 deletions(-)
Approvals:
Csaba Ringhofer: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 41
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 23:
(7 comments)
Hi Daniel, looks good, commented some nits. I will go through the change one more time tomorrow.
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/exec/parquet/parquet-bloom-filter-util.h
File be/src/exec/parquet/parquet-bloom-filter-util.h:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/exec/parquet/parquet-bloom-filter-util.h@17
PS23, Line 17:
nit: missing include guard
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/exec/parquet/parquet-bloom-filter-util.cc
File be/src/exec/parquet/parquet-bloom-filter-util.cc:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/exec/parquet/parquet-bloom-filter-util.cc@18
PS23, Line 18: #include "exec/parquet/parquet-bloom-filter-util.h"
:
: #include <sstream>
:
: #include "exprs/scalar-expr-evaluator.h"
: #include "util/parquet-bloom-filter.h"
nit: include order, usually it is standard include directories first then user defined files
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/thirdparty/xxhash/xxhash.h@1
PS23, Line 1: /*
Maybe we could create a Jira to disable clang on third party libraries. It looks like we would need a new directory specific clang-format file, I only did a quick research on it, so it could be more complex.
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/impala-bloom-filter-buffer-allocator.cc
File be/src/util/impala-bloom-filter-buffer-allocator.cc:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/impala-bloom-filter-buffer-allocator.cc@19
PS23, Line 19:
nit: empty line
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/parquet-bloom-filter-test.cc
File be/src/util/parquet-bloom-filter-test.cc:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/parquet-bloom-filter-test.cc@18
PS23, Line 18: #include "util/parquet-bloom-filter.h"
: #include "testutil/gtest-util.h"
:
: #include <cmath>
: #include <unordered_set>
: #include <vector>
:
: #include "common/names.h"
nit: include order, usually it is standard include directories first then user defined files
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/parquet-bloom-filter.cc
File be/src/util/parquet-bloom-filter.cc:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/parquet-bloom-filter.cc@18
PS23, Line 18: #include "parquet-bloom-filter.h"
:
: #include <cmath>
: #include <cstdint>
:
: #include "kudu/util/slice.h"
: #include "kudu/util/status.h"
: #include "util/kudu-status-util.h"
:
: #include "thirdparty/xxhash/xxhash.h"
nit: include order, usually it is standard include directories first then user defined files
http://gerrit.cloudera.org:8080/#/c/17026/23/tests/query_test/test_parquet_bloom_filter.py
File tests/query_test/test_parquet_bloom_filter.py:
http://gerrit.cloudera.org:8080/#/c/17026/23/tests/query_test/test_parquet_bloom_filter.py@20
PS23, Line 20:
nit: empty line
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 23
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 14:44:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 37:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7182/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 37
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Jun 2021 10:09:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 38:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@70
PS38, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@92
PS38, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@113
PS38, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@243
PS38, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@253
PS38, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@254
PS38, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@270
PS38, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@429
PS38, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@441
PS38, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@476
PS38, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@628
PS38, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@631
PS38, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@700
PS38, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@724
PS38, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@743
PS38, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@756
PS38, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@766
PS38, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@768
PS38, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@791
PS38, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@792
PS38, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@808
PS38, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@809
PS38, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@811
PS38, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@881
PS38, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@886
PS38, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@888
PS38, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@912
PS38, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@915
PS38, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@977
PS38, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1028
PS38, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1029
PS38, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1046
PS38, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1052
PS38, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1257
PS38, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1258
PS38, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1686
PS38, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1707
PS38, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1708
PS38, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1709
PS38, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1710
PS38, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1711
PS38, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1771
PS38, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1953
PS38, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1960
PS38, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1986
PS38, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@1994
PS38, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2030
PS38, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2155
PS38, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2158
PS38, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2174
PS38, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2278
PS38, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2289
PS38, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2290
PS38, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2291
PS38, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2292
PS38, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2293
PS38, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2494
PS38, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2514
PS38, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2521
PS38, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2545
PS38, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2553
PS38, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2587
PS38, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2637
PS38, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2648
PS38, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@2852
PS38, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3010
PS38, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3011
PS38, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3012
PS38, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3013
PS38, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3014
PS38, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3015
PS38, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3016
PS38, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3017
PS38, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3020
PS38, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3021
PS38, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3022
PS38, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3023
PS38, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3062
PS38, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3110
PS38, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3137
PS38, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3138
PS38, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3140
PS38, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3141
PS38, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3160
PS38, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3161
PS38, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3162
PS38, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3163
PS38, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3164
PS38, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3165
PS38, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3166
PS38, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3167
PS38, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3168
PS38, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3169
PS38, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3170
PS38, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3171
PS38, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3419
PS38, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3441
PS38, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3457
PS38, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3462
PS38, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3463
PS38, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3474
PS38, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3480
PS38, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3618
PS38, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3621
PS38, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3705
PS38, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3709
PS38, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3754
PS38, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3769
PS38, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3782
PS38, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3818
PS38, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3822
PS38, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3850
PS38, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3858
PS38, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3865
PS38, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3926
PS38, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3958
PS38, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@3966
PS38, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4101
PS38, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4102
PS38, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4113
PS38, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4136
PS38, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4148
PS38, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4181
PS38, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4346
PS38, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4367
PS38, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4368
PS38, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4381
PS38, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4418
PS38, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4425
PS38, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4433
PS38, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4436
PS38, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4448
PS38, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4451
PS38, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4497
PS38, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4501
PS38, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4513
PS38, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4515
PS38, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4517
PS38, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4527
PS38, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4532
PS38, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4534
PS38, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4541
PS38, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4615
PS38, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4672
PS38, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4694
PS38, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4703
PS38, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4709
PS38, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4711
PS38, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4714
PS38, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4736
PS38, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4741
PS38, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4749
PS38, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4780
PS38, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4827
PS38, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4838
PS38, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4873
PS38, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4894
PS38, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4918
PS38, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4936
PS38, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4947
PS38, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4956
PS38, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4974
PS38, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4979
PS38, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4980
PS38, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@4983
PS38, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5004
PS38, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5030
PS38, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5049
PS38, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5169
PS38, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5225
PS38, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5235
PS38, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5243
PS38, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5247
PS38, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5258
PS38, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5260
PS38, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5262
PS38, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5279
PS38, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5321
PS38, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5352
PS38, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5356
PS38, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/be/src/thirdparty/xxhash/xxhash.h@5363
PS38, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/38/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/38/common/thrift/parquet.thrift@656
PS38, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 38
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Jun 2021 14:52:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 26:
(183 comments)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@70
PS26, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@92
PS26, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@113
PS26, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@243
PS26, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@253
PS26, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@254
PS26, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@270
PS26, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@429
PS26, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@441
PS26, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@476
PS26, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@628
PS26, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@631
PS26, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@700
PS26, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@724
PS26, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@743
PS26, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@756
PS26, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@766
PS26, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@768
PS26, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@791
PS26, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@792
PS26, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@808
PS26, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@809
PS26, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@811
PS26, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@881
PS26, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@886
PS26, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@888
PS26, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@912
PS26, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@915
PS26, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@977
PS26, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1028
PS26, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1029
PS26, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1046
PS26, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1052
PS26, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1257
PS26, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1258
PS26, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1686
PS26, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1707
PS26, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1708
PS26, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1709
PS26, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1710
PS26, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1711
PS26, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1771
PS26, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1953
PS26, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1960
PS26, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1986
PS26, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@1994
PS26, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2030
PS26, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2155
PS26, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2158
PS26, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2174
PS26, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2278
PS26, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2289
PS26, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2290
PS26, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2291
PS26, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2292
PS26, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2293
PS26, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2494
PS26, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2514
PS26, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2521
PS26, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2545
PS26, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2553
PS26, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2587
PS26, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2637
PS26, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2648
PS26, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@2852
PS26, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3010
PS26, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3011
PS26, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3012
PS26, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3013
PS26, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3014
PS26, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3015
PS26, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3016
PS26, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3017
PS26, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3020
PS26, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3021
PS26, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3022
PS26, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3023
PS26, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3062
PS26, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3110
PS26, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3137
PS26, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3138
PS26, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3140
PS26, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3141
PS26, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3160
PS26, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3161
PS26, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3162
PS26, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3163
PS26, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3164
PS26, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3165
PS26, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3166
PS26, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3167
PS26, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3168
PS26, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3169
PS26, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3170
PS26, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3171
PS26, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3419
PS26, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3441
PS26, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3457
PS26, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3462
PS26, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3463
PS26, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3474
PS26, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3480
PS26, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3618
PS26, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3621
PS26, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3705
PS26, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3709
PS26, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3754
PS26, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3769
PS26, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3782
PS26, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3818
PS26, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3822
PS26, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3850
PS26, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3858
PS26, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3865
PS26, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3926
PS26, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3958
PS26, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@3966
PS26, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4101
PS26, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4102
PS26, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4113
PS26, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4136
PS26, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4148
PS26, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4181
PS26, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4346
PS26, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4367
PS26, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4368
PS26, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4381
PS26, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4418
PS26, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4425
PS26, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4433
PS26, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4436
PS26, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4448
PS26, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4451
PS26, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4497
PS26, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4501
PS26, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4513
PS26, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4515
PS26, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4517
PS26, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4527
PS26, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4532
PS26, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4534
PS26, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4541
PS26, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4615
PS26, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4672
PS26, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4694
PS26, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4703
PS26, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4709
PS26, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4711
PS26, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4714
PS26, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4736
PS26, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4741
PS26, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4749
PS26, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4780
PS26, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4827
PS26, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4838
PS26, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4873
PS26, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4894
PS26, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4918
PS26, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4936
PS26, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4947
PS26, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4956
PS26, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4974
PS26, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4979
PS26, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4980
PS26, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@4983
PS26, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5004
PS26, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5030
PS26, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5049
PS26, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5169
PS26, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5225
PS26, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5235
PS26, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5243
PS26, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5247
PS26, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5258
PS26, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5260
PS26, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5262
PS26, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5279
PS26, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5321
PS26, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5352
PS26, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5356
PS26, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/be/src/thirdparty/xxhash/xxhash.h@5363
PS26, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/26/common/thrift/parquet.thrift@656
PS26, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/26/tests/query_test/test_parquet_bloom_filter.py
File tests/query_test/test_parquet_bloom_filter.py:
http://gerrit.cloudera.org:8080/#/c/17026/26/tests/query_test/test_parquet_bloom_filter.py@21
PS26, Line 21: class TestParquetBloomFilter(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 26
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Apr 2021 12:42:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 25: Code-Review+1
(5 comments)
Thanks Daniel, the change LGTM. Tamas said he's planning to take another look so I'm only giving +1 for now.
http://gerrit.cloudera.org:8080/#/c/17026/24//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17026/24//COMMIT_MSG@7
PS24, Line 7: IMPALA-10640: Support reading Parquet Bloom filters - most common types
> I think it can only apply to top level columns as I check whether the type
I see. Is there a plan to extend it to non top level fields? Btw, does Parquet-MR generate bloom filters for them as well?
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@887
PS24, Line 887:
> I've added the query option and put this code and the call to CreateColIdx2
Yeah, adding a test is never a bad idea and it shouldn't be hard to add such a test in a .test file.
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@1483
PS24, Line 1483:
> I've considered that but ParquetPageIndex::ReadAll()
Oh, I see. Thanks for taking a look.
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@1716
PS24, Line 1716: bloom_filter.InitFromDirectoryNoCopy(data_buffer.buffer(), data_buffer.Size()));
> I included the row group idx, column idx and filename in the log message. I
I think it's OK as it is. Based on the column idx and query text I think we should be able to identify the conjunct.
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/parquet-bloom-filter-util.h
File be/src/exec/parquet/parquet-bloom-filter-util.h:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/parquet-bloom-filter-util.h@37
PS24, Line 37: .
> I do not want to guarantee in which cases '*storage' will be used as the im
I see, thanks for extending the comment.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 25
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Apr 2021 15:55:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 29:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8635/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 29
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Apr 2021 12:13:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
IMPALA-9470: Use Parquet Bloom filters - Part 1
This change adds read support for Parquet Bloom filters for some types.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests that
Parquet Bloom filtering works for the supported types and that we do
not incorrectly discard row groups for the unsupported type VARCHAR.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/parquet.thrift
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
27 files changed, 6,825 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/14
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 14
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 35:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7180/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 35
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 May 2021 16:26:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 24:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/17026/24//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17026/24//COMMIT_MSG@7
PS24, Line 7: IMPALA-10640: Support reading Parquet Bloom filters - most common types
Do we filter fields in complex types as well, e.g. elements of an array? Or only top-level columns?
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@887
PS24, Line 887: Status bloom_filter_status = ProcessBloomFilter(row_group,
We have query options to disable row group/page index filtering. Probably we should add a query option for bloom filtering as well, so in case there's a bug in the code the users will be able to disable it.
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@1483
PS24, Line 1483: ReadToBuffer
nit: thanks for adding this member function. Can we use it at ParquetPageIndex::ReadAll() as well?
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@1497
PS24, Line 1497: cache_options));
nit: fits previous line
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@1502
PS24, Line 1502:
nit: +2 indent
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@1716
PS24, Line 1716: if (!bloom_filter.Find(hash)) {
nit: could you please add some logging at VLOG(3)? E.g. which conjunct filtered which row group in which file?
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/parquet-bloom-filter-util.h
File be/src/exec/parquet/parquet-bloom-filter-util.h:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/parquet-bloom-filter-util.h@37
PS24, Line 37: May or may not use
nit: could you add some details please? When storage is used, and when it isn't? And when is 'ptr' used?
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/kudu/util/block_bloom_filter.cc
File be/src/kudu/util/block_bloom_filter.cc:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/kudu/util/block_bloom_filter.cc@135
PS24, Line 135:
nit: too much indentation
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@70
PS24, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
> line too long (112 > 90)
Probably you could add extend EXCLUDE_FILE_PATTERNS to thirdparty files in bin/jenkins/critique-gerrit-review.py.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 24
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Apr 2021 13:29:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 32:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@70
PS32, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@92
PS32, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@113
PS32, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@243
PS32, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@253
PS32, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@254
PS32, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@270
PS32, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@429
PS32, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@441
PS32, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@476
PS32, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@628
PS32, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@631
PS32, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@700
PS32, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@724
PS32, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@743
PS32, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@756
PS32, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@766
PS32, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@768
PS32, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@791
PS32, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@792
PS32, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@808
PS32, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@809
PS32, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@811
PS32, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@881
PS32, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@886
PS32, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@888
PS32, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@912
PS32, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@915
PS32, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@977
PS32, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1028
PS32, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1029
PS32, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1046
PS32, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1052
PS32, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1257
PS32, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1258
PS32, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1686
PS32, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1707
PS32, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1708
PS32, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1709
PS32, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1710
PS32, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1711
PS32, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1771
PS32, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1953
PS32, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1960
PS32, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1986
PS32, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@1994
PS32, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2030
PS32, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2155
PS32, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2158
PS32, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2174
PS32, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2278
PS32, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2289
PS32, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2290
PS32, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2291
PS32, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2292
PS32, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2293
PS32, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2494
PS32, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2514
PS32, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2521
PS32, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2545
PS32, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2553
PS32, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2587
PS32, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2637
PS32, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2648
PS32, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@2852
PS32, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3010
PS32, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3011
PS32, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3012
PS32, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3013
PS32, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3014
PS32, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3015
PS32, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3016
PS32, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3017
PS32, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3020
PS32, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3021
PS32, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3022
PS32, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3023
PS32, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3062
PS32, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3110
PS32, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3137
PS32, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3138
PS32, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3140
PS32, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3141
PS32, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3160
PS32, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3161
PS32, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3162
PS32, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3163
PS32, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3164
PS32, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3165
PS32, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3166
PS32, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3167
PS32, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3168
PS32, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3169
PS32, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3170
PS32, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3171
PS32, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3419
PS32, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3441
PS32, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3457
PS32, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3462
PS32, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3463
PS32, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3474
PS32, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3480
PS32, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3618
PS32, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3621
PS32, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3705
PS32, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3709
PS32, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3754
PS32, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3769
PS32, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3782
PS32, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3818
PS32, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3822
PS32, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3850
PS32, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3858
PS32, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3865
PS32, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3926
PS32, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3958
PS32, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@3966
PS32, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4101
PS32, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4102
PS32, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4113
PS32, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4136
PS32, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4148
PS32, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4181
PS32, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4346
PS32, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4367
PS32, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4368
PS32, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4381
PS32, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4418
PS32, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4425
PS32, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4433
PS32, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4436
PS32, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4448
PS32, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4451
PS32, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4497
PS32, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4501
PS32, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4513
PS32, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4515
PS32, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4517
PS32, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4527
PS32, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4532
PS32, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4534
PS32, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4541
PS32, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4615
PS32, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4672
PS32, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4694
PS32, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4703
PS32, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4709
PS32, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4711
PS32, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4714
PS32, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4736
PS32, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4741
PS32, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4749
PS32, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4780
PS32, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4827
PS32, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4838
PS32, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4873
PS32, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4894
PS32, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4918
PS32, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4936
PS32, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4947
PS32, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4956
PS32, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4974
PS32, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4979
PS32, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4980
PS32, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@4983
PS32, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5004
PS32, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5030
PS32, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5049
PS32, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5169
PS32, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5225
PS32, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5235
PS32, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5243
PS32, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5247
PS32, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5258
PS32, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5260
PS32, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5262
PS32, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5279
PS32, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5321
PS32, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5352
PS32, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5356
PS32, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/be/src/thirdparty/xxhash/xxhash.h@5363
PS32, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/32/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/32/common/thrift/parquet.thrift@656
PS32, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 32
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 May 2021 12:49:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#25). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
IMPALA-10640: Support reading Parquet Bloom filters - most common types
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
The following types are not supported for the given reasons:
----------------------------------------------------------------
|Impala type | Problem |
|----------------------------------------------------------------|
|VARCHAR(N) | truncation can change hash |
|CHAR(N) | padding / truncation can change hash |
|DECIMAL | multiple encodings supported |
|TIMESTAMP | multiple encodings supported, timezone conversion |
|DATE | not considered yet |
----------------------------------------------------------------
Support may be added for these types later, see IMPALA-10641.
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/jenkins/critique-gerrit-review.py
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
38 files changed, 7,161 insertions(+), 140 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/25
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 25
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 37: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7182/
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 37
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Jun 2021 16:08:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 27:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7080/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 27
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Apr 2021 13:41:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 25:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@70
PS25, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@92
PS25, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@113
PS25, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@243
PS25, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@253
PS25, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@254
PS25, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@270
PS25, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@429
PS25, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@441
PS25, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@476
PS25, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@628
PS25, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@631
PS25, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@700
PS25, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@724
PS25, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@743
PS25, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@756
PS25, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@766
PS25, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@768
PS25, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@791
PS25, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@792
PS25, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@808
PS25, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@809
PS25, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@811
PS25, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@881
PS25, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@886
PS25, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@888
PS25, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@912
PS25, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@915
PS25, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@977
PS25, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1028
PS25, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1029
PS25, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1046
PS25, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1052
PS25, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1257
PS25, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1258
PS25, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1686
PS25, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1707
PS25, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1708
PS25, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1709
PS25, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1710
PS25, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1711
PS25, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1771
PS25, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1953
PS25, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1960
PS25, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1986
PS25, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1994
PS25, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2030
PS25, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2155
PS25, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2158
PS25, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2174
PS25, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2278
PS25, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2289
PS25, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2290
PS25, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2291
PS25, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2292
PS25, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2293
PS25, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2494
PS25, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2514
PS25, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2521
PS25, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2545
PS25, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2553
PS25, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2587
PS25, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2637
PS25, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2648
PS25, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2852
PS25, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3010
PS25, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3011
PS25, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3012
PS25, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3013
PS25, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3014
PS25, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3015
PS25, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3016
PS25, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3017
PS25, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3020
PS25, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3021
PS25, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3022
PS25, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3023
PS25, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3062
PS25, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3110
PS25, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3137
PS25, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3138
PS25, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3140
PS25, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3141
PS25, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3160
PS25, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3161
PS25, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3162
PS25, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3163
PS25, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3164
PS25, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3165
PS25, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3166
PS25, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3167
PS25, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3168
PS25, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3169
PS25, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3170
PS25, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3171
PS25, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3419
PS25, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3441
PS25, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3457
PS25, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3462
PS25, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3463
PS25, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3474
PS25, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3480
PS25, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3618
PS25, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3621
PS25, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3705
PS25, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3709
PS25, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3754
PS25, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3769
PS25, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3782
PS25, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3818
PS25, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3822
PS25, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3850
PS25, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3858
PS25, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3865
PS25, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3926
PS25, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3958
PS25, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3966
PS25, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4101
PS25, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4102
PS25, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4113
PS25, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4136
PS25, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4148
PS25, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4181
PS25, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4346
PS25, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4367
PS25, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4368
PS25, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4381
PS25, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4418
PS25, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4425
PS25, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4433
PS25, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4436
PS25, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4448
PS25, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4451
PS25, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4497
PS25, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4501
PS25, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4513
PS25, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4515
PS25, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4517
PS25, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4527
PS25, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4532
PS25, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4534
PS25, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4541
PS25, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4615
PS25, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4672
PS25, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4694
PS25, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4703
PS25, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4709
PS25, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4711
PS25, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4714
PS25, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4736
PS25, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4741
PS25, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4749
PS25, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4780
PS25, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4827
PS25, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4838
PS25, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4873
PS25, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4894
PS25, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4918
PS25, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4936
PS25, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4947
PS25, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4956
PS25, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4974
PS25, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4979
PS25, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4980
PS25, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4983
PS25, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5004
PS25, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5030
PS25, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5049
PS25, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5169
PS25, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5225
PS25, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5235
PS25, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5243
PS25, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5247
PS25, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5258
PS25, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5260
PS25, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5262
PS25, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5279
PS25, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5321
PS25, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5352
PS25, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5356
PS25, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5363
PS25, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/25/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/25/common/thrift/parquet.thrift@656
PS25, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 25
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 15:58:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#34). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
IMPALA-10640: Support reading Parquet Bloom filters - most common types
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
The following types are not supported for the given reasons:
----------------------------------------------------------------
|Impala type | Problem |
|----------------------------------------------------------------|
|VARCHAR(N) | truncation can change hash |
|CHAR(N) | padding / truncation can change hash |
|DECIMAL | multiple encodings supported |
|TIMESTAMP | multiple encodings supported, timezone conversion |
|DATE | not considered yet |
----------------------------------------------------------------
Support may be added for these types later, see IMPALA-10641.
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/jenkins/critique-gerrit-review.py
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter-disabled.test
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
36 files changed, 7,328 insertions(+), 126 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/34
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 34
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 35: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 35
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 May 2021 16:24:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#19). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
IMPALA-9470: Use Parquet Bloom filters - Part 1
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
32 files changed, 7,137 insertions(+), 136 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/19
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 19
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 11:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/8307/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 11
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Mar 2021 15:44:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#35). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
IMPALA-10640: Support reading Parquet Bloom filters - most common types
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
The following types are not supported for the given reasons:
----------------------------------------------------------------
|Impala type | Problem |
|----------------------------------------------------------------|
|VARCHAR(N) | truncation can change hash |
|CHAR(N) | padding / truncation can change hash |
|DECIMAL | multiple encodings supported |
|TIMESTAMP | multiple encodings supported, timezone conversion |
|DATE | not considered yet |
----------------------------------------------------------------
Support may be added for these types later, see IMPALA-10641.
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/jenkins/critique-gerrit-review.py
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter-disabled.test
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
36 files changed, 7,327 insertions(+), 125 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/35
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 35
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 12:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/8308/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 12
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Mar 2021 16:58:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 19:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8458/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 19
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Mar 2021 15:30:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 25:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8524/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 25
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 16:18:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 24:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@70
PS24, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@92
PS24, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@113
PS24, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@243
PS24, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@253
PS24, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@254
PS24, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@270
PS24, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@429
PS24, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@441
PS24, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@476
PS24, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@628
PS24, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@631
PS24, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@700
PS24, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@724
PS24, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@743
PS24, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@756
PS24, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@766
PS24, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@768
PS24, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@791
PS24, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@792
PS24, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@808
PS24, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@809
PS24, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@811
PS24, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@881
PS24, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@886
PS24, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@888
PS24, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@912
PS24, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@915
PS24, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@977
PS24, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1028
PS24, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1029
PS24, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1046
PS24, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1052
PS24, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1257
PS24, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1258
PS24, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1686
PS24, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1707
PS24, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1708
PS24, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1709
PS24, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1710
PS24, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1711
PS24, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1771
PS24, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1953
PS24, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1960
PS24, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1986
PS24, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@1994
PS24, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2030
PS24, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2155
PS24, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2158
PS24, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2174
PS24, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2278
PS24, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2289
PS24, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2290
PS24, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2291
PS24, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2292
PS24, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2293
PS24, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2494
PS24, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2514
PS24, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2521
PS24, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2545
PS24, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2553
PS24, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2587
PS24, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2637
PS24, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2648
PS24, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@2852
PS24, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3010
PS24, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3011
PS24, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3012
PS24, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3013
PS24, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3014
PS24, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3015
PS24, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3016
PS24, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3017
PS24, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3020
PS24, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3021
PS24, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3022
PS24, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3023
PS24, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3062
PS24, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3110
PS24, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3137
PS24, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3138
PS24, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3140
PS24, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3141
PS24, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3160
PS24, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3161
PS24, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3162
PS24, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3163
PS24, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3164
PS24, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3165
PS24, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3166
PS24, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3167
PS24, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3168
PS24, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3169
PS24, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3170
PS24, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3171
PS24, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3419
PS24, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3441
PS24, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3457
PS24, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3462
PS24, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3463
PS24, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3474
PS24, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3480
PS24, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3618
PS24, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3621
PS24, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3705
PS24, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3709
PS24, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3754
PS24, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3769
PS24, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3782
PS24, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3818
PS24, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3822
PS24, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3850
PS24, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3858
PS24, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3865
PS24, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3926
PS24, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3958
PS24, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@3966
PS24, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4101
PS24, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4102
PS24, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4113
PS24, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4136
PS24, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4148
PS24, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4181
PS24, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4346
PS24, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4367
PS24, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4368
PS24, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4381
PS24, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4418
PS24, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4425
PS24, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4433
PS24, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4436
PS24, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4448
PS24, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4451
PS24, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4497
PS24, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4501
PS24, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4513
PS24, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4515
PS24, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4517
PS24, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4527
PS24, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4532
PS24, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4534
PS24, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4541
PS24, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4615
PS24, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4672
PS24, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4694
PS24, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4703
PS24, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4709
PS24, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4711
PS24, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4714
PS24, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4736
PS24, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4741
PS24, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4749
PS24, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4780
PS24, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4827
PS24, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4838
PS24, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4873
PS24, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4894
PS24, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4918
PS24, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4936
PS24, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4947
PS24, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4956
PS24, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4974
PS24, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4979
PS24, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4980
PS24, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@4983
PS24, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5004
PS24, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5030
PS24, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5049
PS24, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5169
PS24, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5225
PS24, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5235
PS24, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5243
PS24, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5247
PS24, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5258
PS24, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5260
PS24, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5262
PS24, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5279
PS24, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5321
PS24, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5352
PS24, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5356
PS24, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@5363
PS24, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/24/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/24/common/thrift/parquet.thrift@656
PS24, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 24
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Apr 2021 10:19:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 34:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8819/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 34
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 May 2021 15:08:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 23: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17026/23//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17026/23//COMMIT_MSG@7
PS23, Line 7: Part 1
Please mention in the title that this is about read support.
http://gerrit.cloudera.org:8080/#/c/17026/23//COMMIT_MSG@10
PS23, Line 10: CHAR(N)
Can you add more info about the unsupported type? E.g.
Impala type | Problem
VARCHAR(N) | truncation can change hash
CHAR(N) | padding / truncation can change hash
DECIMAL | multiple encodings supported
TIMESTAMP:| multiple encodings supported, timezone conversion
DATE | ?
A follow up Jira could be also created and mentioned here that would add support for more problematic types if possible (e.g DATE, DECIMAL, maybe TIMESTAMP)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 23
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Apr 2021 10:22:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 20:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8459/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 20
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Mar 2021 16:38:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#36). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
IMPALA-10640: Support reading Parquet Bloom filters - most common types
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
The following types are not supported for the given reasons:
----------------------------------------------------------------
|Impala type | Problem |
|----------------------------------------------------------------|
|VARCHAR(N) | truncation can change hash |
|CHAR(N) | padding / truncation can change hash |
|DECIMAL | multiple encodings supported |
|TIMESTAMP | multiple encodings supported, timezone conversion |
|DATE | not considered yet |
----------------------------------------------------------------
Support may be added for these types later, see IMPALA-10641.
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/jenkins/critique-gerrit-review.py
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter-disabled.test
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
36 files changed, 7,327 insertions(+), 125 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/36
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 36
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 29:
(182 comments)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@70
PS29, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@92
PS29, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@113
PS29, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@243
PS29, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@253
PS29, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@254
PS29, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@270
PS29, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@429
PS29, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@441
PS29, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@476
PS29, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@628
PS29, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@631
PS29, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@700
PS29, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@724
PS29, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@743
PS29, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@756
PS29, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@766
PS29, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@768
PS29, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@791
PS29, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@792
PS29, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@808
PS29, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@809
PS29, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@811
PS29, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@881
PS29, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@886
PS29, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@888
PS29, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@912
PS29, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@915
PS29, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@977
PS29, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1028
PS29, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1029
PS29, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1046
PS29, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1052
PS29, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1257
PS29, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1258
PS29, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1686
PS29, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1707
PS29, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1708
PS29, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1709
PS29, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1710
PS29, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1711
PS29, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1771
PS29, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1953
PS29, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1960
PS29, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1986
PS29, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@1994
PS29, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2030
PS29, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2155
PS29, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2158
PS29, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2174
PS29, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2278
PS29, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2289
PS29, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2290
PS29, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2291
PS29, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2292
PS29, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2293
PS29, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2494
PS29, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2514
PS29, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2521
PS29, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2545
PS29, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2553
PS29, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2587
PS29, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2637
PS29, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2648
PS29, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@2852
PS29, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3010
PS29, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3011
PS29, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3012
PS29, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3013
PS29, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3014
PS29, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3015
PS29, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3016
PS29, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3017
PS29, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3020
PS29, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3021
PS29, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3022
PS29, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3023
PS29, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3062
PS29, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3110
PS29, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3137
PS29, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3138
PS29, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3140
PS29, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3141
PS29, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3160
PS29, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3161
PS29, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3162
PS29, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3163
PS29, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3164
PS29, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3165
PS29, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3166
PS29, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3167
PS29, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3168
PS29, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3169
PS29, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3170
PS29, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3171
PS29, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3419
PS29, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3441
PS29, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3457
PS29, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3462
PS29, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3463
PS29, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3474
PS29, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3480
PS29, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3618
PS29, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3621
PS29, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3705
PS29, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3709
PS29, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3754
PS29, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3769
PS29, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3782
PS29, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3818
PS29, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3822
PS29, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3850
PS29, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3858
PS29, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3865
PS29, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3926
PS29, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3958
PS29, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@3966
PS29, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4101
PS29, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4102
PS29, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4113
PS29, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4136
PS29, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4148
PS29, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4181
PS29, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4346
PS29, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4367
PS29, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4368
PS29, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4381
PS29, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4418
PS29, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4425
PS29, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4433
PS29, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4436
PS29, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4448
PS29, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4451
PS29, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4497
PS29, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4501
PS29, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4513
PS29, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4515
PS29, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4517
PS29, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4527
PS29, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4532
PS29, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4534
PS29, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4541
PS29, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4615
PS29, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4672
PS29, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4694
PS29, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4703
PS29, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4709
PS29, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4711
PS29, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4714
PS29, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4736
PS29, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4741
PS29, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4749
PS29, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4780
PS29, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4827
PS29, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4838
PS29, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4873
PS29, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4894
PS29, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4918
PS29, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4936
PS29, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4947
PS29, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4956
PS29, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4974
PS29, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4979
PS29, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4980
PS29, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@4983
PS29, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5004
PS29, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5030
PS29, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5049
PS29, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5169
PS29, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5225
PS29, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5235
PS29, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5243
PS29, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5247
PS29, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5258
PS29, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5260
PS29, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5262
PS29, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5279
PS29, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5321
PS29, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5352
PS29, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5356
PS29, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/be/src/thirdparty/xxhash/xxhash.h@5363
PS29, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/29/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/29/common/thrift/parquet.thrift@656
PS29, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 29
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Apr 2021 11:55:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 22:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8495/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 22
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 23:01:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 26:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/17026/24//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17026/24//COMMIT_MSG@7
PS24, Line 7: IMPALA-10640: Support reading Parquet Bloom filters - most common types
> I see. Is there a plan to extend it to non top level fields? Btw, does Parq
No, I don't think we are planning to add filtering for complex types.
Parquet MR only cares about leaf values, not complex values and also it is not clear how we could interpret operations (<>=) on these complex types.
Concerning non-top-level values inside complex types, I'm not sure whether it is possible in Parquet-MR. I don't think we should do it now, we could have a look at it if it turns out to be important.
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@887
PS24, Line 887:
> Yeah, adding a test is never a bad idea and it shouldn't be hard to add suc
Done.
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@1483
PS24, Line 1483:
> Oh, I see. Thanks for taking a look.
Done
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@1716
PS24, Line 1716: bloom_filter.InitFromDirectoryNoCopy(data_buffer.buffer(), data_buffer.Size()));
> I think it's OK as it is. Based on the column idx and query text I think we
Done
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/parquet-bloom-filter-util.h
File be/src/exec/parquet/parquet-bloom-filter-util.h:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/parquet-bloom-filter-util.h@37
PS24, Line 37: ', to the given Pa
> I see, thanks for extending the comment.
Done
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/exec/parquet/parquet-bloom-filter-util.h
File be/src/exec/parquet/parquet-bloom-filter-util.h:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/exec/parquet/parquet-bloom-filter-util.h@17
PS23, Line 17: #pragma once
> nit: missing include guard
Added #pragma once.
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/exec/parquet/parquet-bloom-filter-util.cc
File be/src/exec/parquet/parquet-bloom-filter-util.cc:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/exec/parquet/parquet-bloom-filter-util.cc@18
PS23, Line 18: #include "exec/parquet/parquet-bloom-filter-util.h"
:
: #include <sstream>
:
: #include "exprs/scalar-expr-evaluator.h"
: #include "util/parquet-bloom-filter.h"
> nit: include order, usually it is standard include directories first then u
Isn't the first include in a .cc file usually the corresponding .h file? See for example be/src/exec/parquet/hdfs-parquet-scanner.cc.
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/impala-bloom-filter-buffer-allocator.cc
File be/src/util/impala-bloom-filter-buffer-allocator.cc:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/impala-bloom-filter-buffer-allocator.cc@19
PS23, Line 19: #include "runtime/exec-env.h"
> nit: empty line
Done
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/parquet-bloom-filter-test.cc
File be/src/util/parquet-bloom-filter-test.cc:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/parquet-bloom-filter-test.cc@18
PS23, Line 18: #include <cmath>
: #include <unordered_set>
: #include <vector>
:
: #include "common/names.h"
: #include "testutil/gtest-util.h"
: #include "util/parquet-bloom-filter.h"
:
> nit: include order, usually it is standard include directories first then u
Done
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/parquet-bloom-filter.cc
File be/src/util/parquet-bloom-filter.cc:
http://gerrit.cloudera.org:8080/#/c/17026/23/be/src/util/parquet-bloom-filter.cc@18
PS23, Line 18: #include "parquet-bloom-filter.h"
:
: #include <cmath>
: #include <cstdint>
:
: #include "kudu/util/slice.h"
: #include "kudu/util/status.h"
: #include "util/kudu-status-util.h"
:
: #include "thirdparty/xxhash/xxhash.h"
> nit: include order, usually it is standard include directories first then u
Isn't the first include in a .cc file usually the corresponding .h file? See for example be/src/exec/parquet/hdfs-parquet-scanner.cc.
http://gerrit.cloudera.org:8080/#/c/17026/23/tests/query_test/test_parquet_bloom_filter.py
File tests/query_test/test_parquet_bloom_filter.py:
http://gerrit.cloudera.org:8080/#/c/17026/23/tests/query_test/test_parquet_bloom_filter.py@20
PS23, Line 20:
> nit: empty line
Done
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 26
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Apr 2021 12:42:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#20). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
IMPALA-9470: Use Parquet Bloom filters - Part 1
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
33 files changed, 7,140 insertions(+), 139 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/20
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 20
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#28). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
IMPALA-10640: Support reading Parquet Bloom filters - most common types
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
The following types are not supported for the given reasons:
----------------------------------------------------------------
|Impala type | Problem |
|----------------------------------------------------------------|
|VARCHAR(N) | truncation can change hash |
|CHAR(N) | padding / truncation can change hash |
|DECIMAL | multiple encodings supported |
|TIMESTAMP | multiple encodings supported, timezone conversion |
|DATE | not considered yet |
----------------------------------------------------------------
Support may be added for these types later, see IMPALA-10641.
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-avx2.cc
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/jenkins/critique-gerrit-review.py
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter-disabled.test
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
37 files changed, 7,409 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/28
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 28
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 28:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8624/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 28
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Apr 2021 22:29:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#30). ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
IMPALA-10640: Support reading Parquet Bloom filters - most common types
This change adds read support for Parquet Bloom filters for types that
can reasonably be supported in Impala. Other types, such as CHAR(N),
would be very difficult to support because the length may be different
in Parquet and in Impala which results in truncation or padding, and
that changes the hash which makes using the Bloom filter impossible.
Write support will be added in a later change.
The supported Parquet type - Impala type pairs are the following:
---------------------------------------
|Parquet type | Impala type |
|---------------------------------------|
|INT32 | TINYINT, SMALLINT, INT |
|INT64 | BIGINT |
|FLOAT | FLOAT |
|DOUBLE | DOUBLE |
|BYTE_ARRAY | STRING |
---------------------------------------
The following types are not supported for the given reasons:
----------------------------------------------------------------
|Impala type | Problem |
|----------------------------------------------------------------|
|VARCHAR(N) | truncation can change hash |
|CHAR(N) | padding / truncation can change hash |
|DECIMAL | multiple encodings supported |
|TIMESTAMP | multiple encodings supported, timezone conversion |
|DATE | not considered yet |
----------------------------------------------------------------
Support may be added for these types later, see IMPALA-10641.
If a Bloom filter is available for a column that is fully dictionary
encoded, the Bloom filter is not used as the dictionary can give exact
results in filtering.
Testing:
- Added tests/query_test/test_parquet_bloom_filter.py that tests
whether Parquet Bloom filtering works for the supported types and
that we do not incorrectly discard row groups for the unsupported
type VARCHAR. The Parquet file used in the test was generated with
an external tool.
- Added unit tests for ParquetBloomFilter in file
be/src/util/parquet-bloom-filter-test.cc
- A minor, unrelated change was done in
be/src/util/bloom-filter-test.cc: the MakeRandom() function had
return type uint64_t, the documentation claimed it returned a 64 bit
random number, but the actual number of random bits is 32, which is
what is intended in the tests. The return type and documentation
have been corrected to use 32 bits.
Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
---
M LICENSE.txt
M be/src/exec/parquet/CMakeLists.txt
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner.h
A be/src/exec/parquet/parquet-bloom-filter-util.cc
A be/src/exec/parquet/parquet-bloom-filter-util.h
M be/src/exprs/expr-value.h
M be/src/exprs/literal.cc
M be/src/exprs/literal.h
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/bufferpool/buffer-pool.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
A be/src/thirdparty/xxhash/README.md
A be/src/thirdparty/xxhash/xxhash.h
M be/src/util/CMakeLists.txt
M be/src/util/bloom-filter-test.cc
M be/src/util/bloom-filter.cc
M be/src/util/bloom-filter.h
A be/src/util/impala-bloom-filter-buffer-allocator.cc
A be/src/util/impala-bloom-filter-buffer-allocator.h
A be/src/util/parquet-bloom-filter-avx2.cc
A be/src/util/parquet-bloom-filter-test.cc
A be/src/util/parquet-bloom-filter.cc
A be/src/util/parquet-bloom-filter.h
M bin/jenkins/critique-gerrit-review.py
M bin/rat_exclude_files.txt
M bin/run_clang_tidy.sh
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M common/thrift/parquet.thrift
M testdata/data/README
A testdata/data/parquet-bloom-filtering.parquet
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter-disabled.test
A testdata/workloads/functional-query/queries/QueryTest/parquet-bloom-filter.test
A tests/query_test/test_parquet_bloom_filter.py
37 files changed, 7,410 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17026/30
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 30
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types
......................................................................
Patch Set 25:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/17026/24//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17026/24//COMMIT_MSG@7
PS24, Line 7: IMPALA-10640: Support reading Parquet Bloom filters - most common types
> Do we filter fields in complex types as well, e.g. elements of an array? Or
I think it can only apply to top level columns as I check whether the type of the expression is among the supported types for Parquet Bloom filtering (see them below) and if the type is a complex type, it is not included.
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@887
PS24, Line 887:
> We have query options to disable row group/page index filtering. Probably w
I've added the query option and put this code and the call to CreateColIdx2EqConjunctMap() inside an IF statement depending on the query option.
Do you think we should also add a test case in tests/query_test/test_parquet_bloom_filter.py that checks there is no Bloom filtering if the query option is 'false'?
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@1483
PS24, Line 1483:
> nit: thanks for adding this member function. Can we use it at ParquetPageIn
I've considered that but ParquetPageIndex::ReadAll()
uses a different overload of scan_node_->AllocateScanRange(), which also involves subranges, so it would be more complicated.
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@1497
PS24, Line 1497: fset, partition_
> nit: fits previous line
Done
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@1502
PS24, Line 1502: n
> nit: +2 indent
Done
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/hdfs-parquet-scanner.cc@1716
PS24, Line 1716: bloom_filter.InitFromDirectoryNoCopy(data_buffer.buffer(), data_buffer.Size()));
> nit: could you please add some logging at VLOG(3)? E.g. which conjunct filt
I included the row group idx, column idx and filename in the log message. If you think it's important, I can add info about the specific conjunct, but now I only store the hash of the value of the literal in the EQ conjunct, so at this point in the code we cannot identify the conjunct. If you think it is needed, I can store more info about the conjuncts.
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/parquet-bloom-filter-util.h
File be/src/exec/parquet/parquet-bloom-filter-util.h:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/exec/parquet/parquet-bloom-filter-util.h@37
PS24, Line 37: .
> nit: could you add some details please? When storage is used, and when it i
I do not want to guarantee in which cases '*storage' will be used as the implementation may change. I have updated the doc comment to hopefully make it clearer how we use it. Essentially, the result should always be read through '*ptr', and iff allocation is needed to store the result, '*storage' will be used to allocate a buffer and '*ptr' will point to that buffer.
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/kudu/util/block_bloom_filter.cc
File be/src/kudu/util/block_bloom_filter.cc:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/kudu/util/block_bloom_filter.cc@135
PS24, Line 135: us
> nit: too much indentation
Done
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/24/be/src/thirdparty/xxhash/xxhash.h@70
PS24, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
> Probably you could add extend EXCLUDE_FILE_PATTERNS to thirdparty files in
Done
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 25
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 15:57:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 11:
(185 comments)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/exec/parquet/hdfs-parquet-scanner.cc@1576
PS11, Line 1576: status = DeserializeThriftMsg(buffer->buffer(), header_size, true, bloom_filter_header);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/exec/parquet/hdfs-parquet-scanner.cc@1819
PS11, Line 1819: "Bloom filter data for file '$1'.", bloom_filter_header.numBytes, filename()));
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h
File be/src/thirdparty/xxhash/xxhash.h:
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@70
PS11, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@92
PS11, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@113
PS11, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */)
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@243
PS11, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@253
PS11, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@254
PS11, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret)
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@270
PS11, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE)
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@429
PS11, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState().
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@441
PS11, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@476
PS11, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@628
PS11, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@631
PS11, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@700
PS11, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@724
PS11, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (120 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@743
PS11, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@756
PS11, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@766
PS11, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@768
PS11, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@791
PS11, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@792
PS11, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@808
PS11, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@809
PS11, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize);
line too long (122 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@811
PS11, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@881
PS11, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@886
PS11, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@888
PS11, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@912
PS11, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@915
PS11, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@977
PS11, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1028
PS11, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed,
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1029
PS11, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic.
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1046
PS11, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes.
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1052
PS11, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1257
PS11, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1258
PS11, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6)
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1686
PS11, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1707
PS11, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1708
PS11, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1709
PS11, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1710
PS11, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1711
PS11, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1771
PS11, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r).
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1953
PS11, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1960
PS11, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1986
PS11, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@1994
PS11, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2030
PS11, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2155
PS11, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2158
PS11, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2174
PS11, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2278
PS11, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr);
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2289
PS11, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2290
PS11, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2291
PS11, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2292
PS11, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2293
PS11, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */
line too long (136 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2494
PS11, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2514
PS11, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2521
PS11, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2545
PS11, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2553
PS11, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2587
PS11, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2637
PS11, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2648
PS11, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned);
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@2852
PS11, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2))
line too long (111 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3010
PS11, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3011
PS11, Line 3011: do { \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3012
PS11, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3013
PS11, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3014
PS11, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3015
PS11, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3016
PS11, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3017
PS11, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3020
PS11, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3021
PS11, Line 3021: do { \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3022
PS11, Line 3022: (outLo) = vmovn_u64 (in); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3023
PS11, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3062
PS11, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3110
PS11, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3137
PS11, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3138
PS11, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3140
PS11, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) )
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3141
PS11, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3160
PS11, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3161
PS11, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3162
PS11, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3163
PS11, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3164
PS11, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3165
PS11, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3166
PS11, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3167
PS11, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3168
PS11, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3169
PS11, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3170
PS11, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3171
PS11, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e,
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3419
PS11, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3441
PS11, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3457
PS11, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3462
PS11, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3463
PS11, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3474
PS11, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3480
PS11, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64)));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3618
PS11, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3621
PS11, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3705
PS11, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3709
PS11, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2));
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3754
PS11, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1));
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3769
PS11, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64);
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3782
PS11, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3818
PS11, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3822
PS11, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3850
PS11, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3858
PS11, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3865
PS11, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64);
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3926
PS11, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3958
PS11, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1));
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@3966
PS11, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4101
PS11, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4102
PS11, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4113
PS11, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4136
PS11, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 };
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4148
PS11, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4181
PS11, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4346
PS11, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE;
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4367
PS11, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4368
PS11, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START);
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4381
PS11, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start)
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4418
PS11, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble);
line too long (121 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4425
PS11, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4433
PS11, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4436
PS11, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4448
PS11, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4451
PS11, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc);
line too long (125 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4497
PS11, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4501
PS11, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4513
PS11, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4515
PS11, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4517
PS11, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4527
PS11, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default);
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4532
PS11, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4534
PS11, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret);
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4541
PS11, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4615
PS11, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4672
PS11, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4694
PS11, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4703
PS11, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4709
PS11, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512);
line too long (126 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4711
PS11, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512);
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4714
PS11, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512);
line too long (114 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4736
PS11, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4741
PS11, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4749
PS11, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */
line too long (97 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4780
PS11, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN);
line too long (115 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4827
PS11, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4838
PS11, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4873
PS11, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4894
PS11, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) );
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4918
PS11, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4936
PS11, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4947
PS11, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4956
PS11, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed;
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4974
PS11, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4979
PS11, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4980
PS11, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed;
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@4983
PS11, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5004
PS11, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2);
line too long (113 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5030
PS11, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1);
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5049
PS11, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5169
PS11, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5225
PS11, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret),
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5235
PS11, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen)
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5243
PS11, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t);
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5247
PS11, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5258
PS11, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64);
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5260
PS11, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (106 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5262
PS11, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64);
line too long (107 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5279
PS11, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize)
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5321
PS11, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize)
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5352
PS11, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret;
line too long (108 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5356
PS11, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START);
line too long (100 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/be/src/thirdparty/xxhash/xxhash.h@5363
PS11, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START,
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/common/thrift/parquet.thrift
File common/thrift/parquet.thrift:
http://gerrit.cloudera.org:8080/#/c/17026/11/common/thrift/parquet.thrift@656
PS11, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17026/11/tests/query_test/test_parquet_bloom_filter.py
File tests/query_test/test_parquet_bloom_filter.py:
http://gerrit.cloudera.org:8080/#/c/17026/11/tests/query_test/test_parquet_bloom_filter.py@21
PS11, Line 21: class TestParquetBloomFilter(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 11
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Mar 2021 15:28:44 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9470: Use Parquet Bloom filters - Part 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-9470: Use Parquet Bloom filters - Part 1
......................................................................
Patch Set 16:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8342/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287
Gerrit-Change-Number: 17026
Gerrit-PatchSet: 16
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Mar 2021 13:44:21 +0000
Gerrit-HasComments: No