You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:55:52 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue #10796: Add more test cases for shardingsphere-sql-parser-engine module
terrymanu opened a new issue #10796:
URL: https://github.com/apache/shardingsphere/issues/10796
- [ ] Add test case for SQLParserEngine
- [ ] Add test case for DatabaseTypedSQLParserFacadeRegistry with DatabaseTypedSQLParserFacade fixture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] LeeGuoPing commented on issue #10796: Add more test cases for shardingsphere-sql-parser-engine module
Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #10796:
URL: https://github.com/apache/shardingsphere/issues/10796#issuecomment-862064663
But now I don't understand how to add test case for SQLParserEngine, Can you give me some advice, thank you @terrymanu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #10796: Add more test cases for shardingsphere-sql-parser-engine module
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #10796:
URL: https://github.com/apache/shardingsphere/issues/10796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] LeeGuoPing commented on issue #10796: Add more test cases for shardingsphere-sql-parser-engine module
Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #10796:
URL: https://github.com/apache/shardingsphere/issues/10796#issuecomment-860060456
I want to try it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #10796: Add more test cases for shardingsphere-sql-parser-engine module
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #10796:
URL: https://github.com/apache/shardingsphere/issues/10796#issuecomment-862210786
> when I add test case named DatabaseTypedSQLParserFacadeRegistryTest, I created a new package name fixture, it contains DatabaseLexer, DatabaseParser,DatabaseParserFacade. And use SPI to test it, my idea is right?
>
> 
You are correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #10796: Add more test cases for shardingsphere-sql-parser-engine module
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #10796:
URL: https://github.com/apache/shardingsphere/issues/10796#issuecomment-860060831
@LeeGuoPing Welcome, I just assigned to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #10796: Add more test cases for shardingsphere-sql-parser-engine module
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #10796:
URL: https://github.com/apache/shardingsphere/issues/10796#issuecomment-862211293
> But now I don't understand how to add test case for SQLParserEngine, Can you give me some advice, thank you @terrymanu
It is better to mock sqlParserExecutor and parseTreeCache, then verify the call times of `parse`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] LeeGuoPing commented on issue #10796: Add more test cases for shardingsphere-sql-parser-engine module
Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on issue #10796:
URL: https://github.com/apache/shardingsphere/issues/10796#issuecomment-862060944
when I add test case named DatabaseTypedSQLParserFacadeRegistryTest, I created a new package name fixture, it contains DatabaseLexer, DatabaseParser,DatabaseParserFacade. And use SPI to test it, my idea is right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org