You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by BJangir <gi...@git.apache.org> on 2018/01/15 17:09:00 UTC

[GitHub] carbondata pull request #1807: [CARBONDATA-2030]avg with Aggregate table for...

GitHub user BJangir opened a pull request:

    https://github.com/apache/carbondata/pull/1807

    [CARBONDATA-2030]avg with Aggregate table for double data type is failed.

    avg with Aggregate table for double data type is failed.
    
    Root Cause:- for avg column , agg table returns sum and count , sum col. data type is based on actual data type of the column but for count col. always  LongType .so while doing divide by it is failed in spark layer
    
    Solution :- Change the return datatype for count also . use the same datatype sum column .
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     NA
     - [ ] Any backward compatibility impacted?
     NA
     - [ ] Document update required? NA
    
     - [ ] Testing done=Done
           Added UT.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BJangir/incubator-carbondata CARBONDATA-2030

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1807.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1807
    
----
commit c34dbe766c8878ece0aee5d9d2de9b06bac85f96
Author: BJangir <ba...@...>
Date:   2018-01-15T17:05:54Z

    avg with Aggregate table for double data type is failed.

----


---

[GitHub] carbondata pull request #1807: [CARBONDATA-2030]avg with Aggregate table for...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1807


---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    LGTM


---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2850/



---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by BJangir <gi...@git.apache.org>.
Github user BJangir commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    retest this please


---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2832/



---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by BJangir <gi...@git.apache.org>.
Github user BJangir commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    retest this please


---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    retest sdv please


---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1597/



---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    retest this please


---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2900/



---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1678/



---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2814/



---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1614/



---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1573/



---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2809/



---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1579/



---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2911/



---

[GitHub] carbondata issue #1807: [CARBONDATA-2030]avg with Aggregate table for double...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1807
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1589/



---