You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/15 09:35:53 UTC
[GitHub] [fineract] ptuomola opened a new pull request #1068: FINERACT-723: Fixed to use the right date in more tests
ptuomola opened a new pull request #1068:
URL: https://github.com/apache/fineract/pull/1068
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1068: FINERACT-723: Fixed to use the right date in more tests
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1068:
URL: https://github.com/apache/fineract/pull/1068#issuecomment-644953698
This is interesting.. why do we even have those 2 separate date functions? I'm keeping this PR open and not yet merged because I'm hoping to look s little bit more closely at those dates utilities - another day (too tired).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1068: FINERACT-723: Fixed to use the right date in more tests
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1068:
URL: https://github.com/apache/fineract/pull/1068#issuecomment-644370544
@vorburger Here are some more date changes to fix timezone issues with integration tests...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1068: FINERACT-723: Fixed to use the right date in more tests
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1068:
URL: https://github.com/apache/fineract/pull/1068#issuecomment-645243106
@vorburger As far as I can see, DateUtils.getDateOfTenant is the "server side" version: it assumes it can find the Tenant object from a ThreadLocal variable initialised on the server.
org.apache.fineract.integrationtests.common.Utils.getLocalDateOfTenant() is a "client side" version that is used only by the tests. It currently only returns dates based on a hardcoded timezone of "Asia/Kolkata" which matches the default tenant set-up used in the server.
I think we'll always need a test client and a server side version of this. Of course the latter could be made smarter by e.g. retrieving the timezone from the server. But at the same time, given it's only used in integration tests and all the ITs use the same timezone, I'm not sure this would add a lot of value...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1068: FINERACT-723: Fixed to use the right date in more tests
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1068:
URL: https://github.com/apache/fineract/pull/1068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org