You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/09/16 04:50:55 UTC

[GitHub] [ofbiz-plugins] priyasharma1 commented on a change in pull request #64: Best selling category template translation

priyasharma1 commented on a change in pull request #64:
URL: https://github.com/apache/ofbiz-plugins/pull/64#discussion_r709767028



##########
File path: ecommerce/config/EcommerceUiLabels.xml
##########
@@ -350,6 +350,10 @@
         <value xml:lang="zh">分配明细</value>
         <value xml:lang="zh-TW">分配細項</value>
     </property>
+    <property key="EcommerceBestSelling">

Review comment:
       Hi @CharlesNereide, thanks for your contribution!
   
   Can we change this key to "EcommercePopularCategories" instead, for consistency reasons?
   You might notice this pattern in other labels too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org