[I] [C++] Clarify that RunEndEncodedBuilder::AppendScalar Only Accepts std::shared_ptr [arrow]

["andishgar (via GitHub)" <gi...@apache.org>]

andishgar opened a new issue, #50507:
URL: https://github.com/apache/arrow/issues/50507

   ### Describe the enhancement requested
   
   The current API of `arrow::RunEndEncodedBuilder::AppendScalar` is:
   
   ```c++
   Status AppendScalar(const Scalar& scalar, int64_t n_repeats) override;
   ```
   
   However, because of [this code](https://github.com/apache/arrow/blob/7932e197eaa00577ff3e83ddf956022df3ef174c/cpp/src/arrow/array/builder_run_end.cc#L102), it effectively only accepts `std::shared_ptr<Scalar>`.
   
   We should either change the API to accept only `std::shared_ptr<Scalar>`, or provide an overload that supports both forms (although I'm not sure whether `Scalar` is intended to be copyable or whether its copy constructor is usable in this context).
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [C++] Clarify that RunEndEncodedBuilder::AppendScalar Only Accepts std::shared_ptr [arrow]

["andishgar (via GitHub)" <gi...@apache.org>]

andishgar commented on issue #50507:
URL: https://github.com/apache/arrow/issues/50507#issuecomment-5011769409

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org