You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by li...@inuus.com on 2010/04/29 11:04:09 UTC

Use guice 2.0 features to clean up guice modules (issue1008044)

Reviewers: shindig.remailer_gmail.com,

Message:
this gets rid of most of the TypeLiterals<> and makes the code a bit
cleaner and easier to deal with.

Some of the Set<> bindings could be replaced with guice-multibinding if
we want to add another guice dependency


Description:
Use guice 2.0 features to clean up guice modules

Please review this at http://codereview.appspot.com/1008044/show

Affected files:
   M  
java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
   M  
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderModule.java
   M  
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingGadgetRewriter.java
   M  
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/old/SanitizingGadgetRewriter.java
   M  
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java
   M  
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AuthenticationModule.java
   M  
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java