You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "317brian (via GitHub)" <gi...@apache.org> on 2024/03/12 19:51:12 UTC
[PR] docs: clarify description of uri/uriprefix (druid)
317brian opened a new pull request, #16110:
URL: https://github.com/apache/druid/pull/16110
### Description
Light copyediting and clarifying that you need to specify either the URI or URI prefix
#### Release note
none
<hr>
<hr>
This PR has:
- [x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] docs: clarify description of uri/uriprefix (druid)
Posted by "techdocsmith (via GitHub)" <gi...@apache.org>.
techdocsmith merged PR #16110:
URL: https://github.com/apache/druid/pull/16110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] docs: clarify description of uri/uriprefix (druid)
Posted by "techdocsmith (via GitHub)" <gi...@apache.org>.
techdocsmith commented on code in PR #16110:
URL: https://github.com/apache/druid/pull/16110#discussion_r1522121851
##########
docs/development/extensions-core/lookups-cached-global.md:
##########
@@ -211,8 +211,8 @@ The remapping values for each globally cached lookup can be specified by a JSON
|Property|Description|Required|Default|
|--------|-----------|--------|-------|
|`pollPeriod`|Period between polling for updates|No|0 (only once)|
-|`uri`|URI for the file of interest, specified as a file, hdfs, s3 or gs path|No|Use `uriPrefix`|
-|`uriPrefix`|A URI that specifies a directory (or other searchable resource) in which to search for files|No|Use `uri`|
+|`uri`|URI for the file of interest. Can be a file, HDFS, S3 or GCS path|Either `uri` or `uriPrefix` must be set|None|
Review Comment:
```suggestion
|`uri`|URI for the lookup file. Can be a file, HDFS, S3 or GCS path|Either `uri` or `uriPrefix` must be set|None|
```
File of interest? 😬
##########
docs/development/extensions-core/lookups-cached-global.md:
##########
@@ -211,8 +211,8 @@ The remapping values for each globally cached lookup can be specified by a JSON
|Property|Description|Required|Default|
|--------|-----------|--------|-------|
|`pollPeriod`|Period between polling for updates|No|0 (only once)|
-|`uri`|URI for the file of interest, specified as a file, hdfs, s3 or gs path|No|Use `uriPrefix`|
-|`uriPrefix`|A URI that specifies a directory (or other searchable resource) in which to search for files|No|Use `uri`|
+|`uri`|URI for the file of interest. Can be a file, HDFS, S3 or GCS path|Either `uri` or `uriPrefix` must be set|None|
+|`uriPrefix`|A URI prefix that specifies a directory (or other searchable resource) in which to search for files|Either `uri` or `uriPrefix` must be set|None|
Review Comment:
```suggestion
|`uriPrefix`|A URI prefix that specifies a directory or other searchable resource where lookup files are located |Either `uri` or `uriPrefix` must be set|None|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org