You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "lancelly (via GitHub)" <gi...@apache.org> on 2025/05/13 15:10:37 UTC
[PR] Support correlated quantified comparison [iotdb]
lancelly opened a new pull request, #15498:
URL: https://github.com/apache/iotdb/pull/15498
This PR introduces both correlated quantified comparison subquery into IoTDB TableModel.
Correlated subquery has such limitations:
1. limit clause with row count greater than 1 is not supported in correlated subquery for now.
2. TopK clause is not supported in correlated subquery for now.
3. Non-Equality comparison is not supported in correlated subquery for now.(Error msg for this is kind of confusing since it's related to join: For now, FullOuterJoin and LeftJoin only support EquiJoinClauses )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support correlated quantified comparison [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #15498:
URL: https://github.com/apache/iotdb/pull/15498#issuecomment-2877142572
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/15498?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `7.00000%` with `93 lines` in your changes missing coverage. Please review.
> Project coverage is 39.25%. Comparing base [(`eda4249`)](https://app.codecov.io/gh/apache/iotdb/commit/eda424904628669089a8f2ddcdb99e661add5ec9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`7109ee9`)](https://app.codecov.io/gh/apache/iotdb/commit/7109ee98c339eee25c47a129351153193cfffc20?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/15498?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...rative/rule/TransformCorrelatedScalarSubquery.java](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fplanner%2Fiterative%2Frule%2FTransformCorrelatedScalarSubquery.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL3BsYW5uZXIvaXRlcmF0aXZlL3J1bGUvVHJhbnNmb3JtQ29ycmVsYXRlZFNjYWxhclN1YnF1ZXJ5LmphdmE=) | 11.32% | [47 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ggregation/grouped/GroupedCountAllAccumulator.java](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fexecution%2Foperator%2Fsource%2Frelational%2Faggregation%2Fgrouped%2FGroupedCountAllAccumulator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvZXhlY3V0aW9uL29wZXJhdG9yL3NvdXJjZS9yZWxhdGlvbmFsL2FnZ3JlZ2F0aW9uL2dyb3VwZWQvR3JvdXBlZENvdW50QWxsQWNjdW11bGF0b3IuamF2YQ==) | 0.00% | [26 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...tion/dag/column/FailFunctionColumnTransformer.java](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Ftransformation%2Fdag%2Fcolumn%2FFailFunctionColumnTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvdHJhbnNmb3JtYXRpb24vZGFnL2NvbHVtbi9GYWlsRnVuY3Rpb25Db2x1bW5UcmFuc2Zvcm1lci5qYXZh) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...execution/relational/ColumnTransformerBuilder.java](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fexecution%2Frelational%2FColumnTransformerBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvZXhlY3V0aW9uL3JlbGF0aW9uYWwvQ29sdW1uVHJhbnNmb3JtZXJCdWlsZGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ion/operator/process/FilterAndProjectOperator.java](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fexecution%2Foperator%2Fprocess%2FFilterAndProjectOperator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvZXhlY3V0aW9uL29wZXJhdG9yL3Byb2Nlc3MvRmlsdGVyQW5kUHJvamVjdE9wZXJhdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...umn/unary/ArithmeticNegationColumnTransformer.java](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Ftransformation%2Fdag%2Fcolumn%2Funary%2FArithmeticNegationColumnTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvdHJhbnNmb3JtYXRpb24vZGFnL2NvbHVtbi91bmFyeS9Bcml0aG1ldGljTmVnYXRpb25Db2x1bW5UcmFuc2Zvcm1lci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rce/relational/aggregation/AccumulatorFactory.java](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fexecution%2Foperator%2Fsource%2Frelational%2Faggregation%2FAccumulatorFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvZXhlY3V0aW9uL29wZXJhdG9yL3NvdXJjZS9yZWxhdGlvbmFsL2FnZ3JlZ2F0aW9uL0FjY3VtdWxhdG9yRmFjdG9yeS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ne/plan/relational/metadata/TableMetadataImpl.java](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fmetadata%2FTableMetadataImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL21ldGFkYXRhL1RhYmxlTWV0YWRhdGFJbXBsLmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #15498 +/- ##
============================================
- Coverage 39.25% 39.25% -0.01%
Complexity 198 198
============================================
Files 4697 4700 +3
Lines 304561 304796 +235
Branches 38062 38099 +37
============================================
+ Hits 119567 119659 +92
- Misses 184994 185137 +143
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/15498?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support correlated quantified comparison [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #15498:
URL: https://github.com/apache/iotdb/pull/15498#issuecomment-2876939443
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=15498) **Quality Gate failed**
Failed conditions
 [11.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=15498&metric=new_duplicated_lines_density&view=list) (required ≤ 5%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=15498)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org