You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/08/20 19:13:00 UTC
[jira] [Work logged] (BEAM-10771) Create whitespacelint precommit
for non code files in Beam repo
[ https://issues.apache.org/jira/browse/BEAM-10771?focusedWorklogId=473040&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473040 ]
ASF GitHub Bot logged work on BEAM-10771:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/20 19:12
Start Date: 20/Aug/20 19:12
Worklog Time Spent: 10m
Work Description: KevinGG commented on a change in pull request #12444:
URL: https://github.com/apache/beam/pull/12444#discussion_r474210889
##########
File path: .test-infra/jenkins/job_PreCommit_Whitespace.groovy
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import PrecommitJobBuilder
+
+PrecommitJobBuilder builder = new PrecommitJobBuilder(
Review comment:
Added the item
##########
File path: sdks/python/scripts/run_whitespacelint.sh
##########
@@ -0,0 +1,56 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+set -e
Review comment:
Documented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 473040)
Remaining Estimate: 0h
Time Spent: 10m
> Create whitespacelint precommit for non code files in Beam repo
> ---------------------------------------------------------------
>
> Key: BEAM-10771
> URL: https://issues.apache.org/jira/browse/BEAM-10771
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Ning Kang
> Assignee: Ning Kang
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Create a precommit job that runs on changes of non code files in Beam to find out trailing whitespaces and report such issues.
> Supported non code file types are:
> * *.md (markdown files)
> * build.gradle (gradle build files)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)