You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2012/09/07 21:01:30 UTC
svn commit: r1382128 -
/jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java
Author: pmouawad
Date: Fri Sep 7 19:01:30 2012
New Revision: 1382128
URL: http://svn.apache.org/viewvc?rev=1382128&view=rev
Log:
Remove isNumeric and add warning
Modified:
jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java
Modified: jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java?rev=1382128&r1=1382127&r2=1382128&view=diff
==============================================================================
--- jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java (original)
+++ jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java Fri Sep 7 19:01:30 2012
@@ -26,7 +26,6 @@ import java.util.Collection;
import java.util.LinkedList;
import java.util.List;
-import org.apache.commons.lang3.StringUtils;
import org.apache.jmeter.engine.util.CompoundVariable;
import org.apache.jmeter.samplers.SampleResult;
import org.apache.jmeter.samplers.Sampler;
@@ -148,12 +147,7 @@ public class StringFromFile extends Abst
myStart = Integer.parseInt(start);
} catch(NumberFormatException e) {
myStart = COUNT_UNUSED;// Don't process invalid numbers
- // TODO Should this be a warning ?
- if(log.isDebugEnabled()) {
- if(StringUtils.isNumeric(start)) {
- log.debug("Exception parsing "+start + " as int, value will not be considered as Start Number sequence");
- }
- }
+ log.warn("Exception parsing "+start + " as int, value will not be considered as Start Number sequence");
}
}
// Have we used myCurrent yet?
@@ -169,12 +163,7 @@ public class StringFromFile extends Abst
myEnd = Integer.parseInt(tmp);
} catch(NumberFormatException e) {
myEnd = COUNT_UNUSED;// Don't process invalid numbers (including "")
- // TODO Should this be a warning ?
- if(log.isDebugEnabled()) {
- if(StringUtils.isNumeric(tmp)) {
- log.debug("Exception parsing "+tmp + " as int, value will not be considered as End Number sequence");
- }
- }
+ log.warn("Exception parsing "+tmp + " as int, value will not be considered as End Number sequence");
}
}