You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/29 00:08:09 UTC

[GitHub] [airflow] mdediana opened a new pull request #9058: Improve test for the next_execution cli command

mdediana opened a new pull request #9058:
URL: https://github.com/apache/airflow/pull/9058


   Improve `TestCliDags.test_next_execution` in terms of efficiency and readability. Perhaps the `@pytest.mark.quarantined` annotation could be removed, but it is still there because locally the test takes longer than others in the same test case.  
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mdediana commented on pull request #9058: Improve test for the next_execution cli command

Posted by GitBox <gi...@apache.org>.

mdediana commented on pull request #9058:
URL: https://github.com/apache/airflow/pull/9058#issuecomment-635693864


   My intention with this change is that I'd like to try to add a new option to this command but first wanted to get the related tests in a better state.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9058: Improve test for the next_execution cli command

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #9058:
URL: https://github.com/apache/airflow/pull/9058#issuecomment-636256531


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9058: Improve test for the next_execution cli command

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #9058:
URL: https://github.com/apache/airflow/pull/9058#issuecomment-635681639

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on a change in pull request #9058: Improve test for the next_execution cli command

Posted by GitBox <gi...@apache.org>.

turbaszek commented on a change in pull request #9058:
URL: https://github.com/apache/airflow/pull/9058#discussion_r432602581



##########
File path: tests/cli/commands/test_dag_command.py
##########
@@ -240,21 +240,29 @@ def test_cli_backfill_depends_on_past_backwards(self, mock_run):
 
     @pytest.mark.quarantined

Review comment:
       ```suggestion
   
   ```
   Should we try?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mdediana commented on a change in pull request #9058: Improve test for the next_execution cli command

Posted by GitBox <gi...@apache.org>.

mdediana commented on a change in pull request #9058:
URL: https://github.com/apache/airflow/pull/9058#discussion_r432604604



##########
File path: tests/cli/commands/test_dag_command.py
##########
@@ -240,21 +240,29 @@ def test_cli_backfill_depends_on_past_backwards(self, mock_run):
 
     @pytest.mark.quarantined

Review comment:
       Sure!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek merged pull request #9058: Improve test for the next_execution cli command

Posted by GitBox <gi...@apache.org>.

turbaszek merged pull request #9058:
URL: https://github.com/apache/airflow/pull/9058


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on a change in pull request #9058: Improve test for the next_execution cli command

Posted by GitBox <gi...@apache.org>.

turbaszek commented on a change in pull request #9058:
URL: https://github.com/apache/airflow/pull/9058#discussion_r432549412



##########
File path: tests/cli/commands/test_dag_command.py
##########
@@ -240,21 +239,30 @@ def test_cli_backfill_depends_on_past_backwards(self, mock_run):
 
     @pytest.mark.quarantined
     def test_next_execution(self):
-        # A scaffolding function
-        def reset_dr_db(dag_id):
-            session = Session()
-            dr = session.query(DagRun).filter_by(dag_id=dag_id)
-            dr.delete()
-            session.commit()
-            session.close()
-
         dag_ids = ['example_bash_operator',  # schedule_interval is '0 0 * * *'
                    'latest_only',  # schedule_interval is timedelta(hours=4)
                    'example_python_operator',  # schedule_interval=None
                    'example_xcom']  # schedule_interval="@once"
 
+        session = Session()
+        dr = session.query(DagRun).filter(DagRun.dag_id.in_(dag_ids))
+        dr.delete(synchronize_session=False)
+        session.commit()
+        session.close()

Review comment:
       Let's use `create_session` context manager, WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org