You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mans2singh <gi...@git.apache.org> on 2017/07/22 02:14:53 UTC
[GitHub] nifi pull request #2030: NIFI-4212 - RethinkDB Delete Processor
GitHub user mans2singh opened a pull request:
https://github.com/apache/nifi/pull/2030
NIFI-4212 - RethinkDB Delete Processor
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mans2singh/nifi NIFI-4212
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2030.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2030
----
commit 5ea664840e5caf88e8cd848f25c4a3cff2756409
Author: mans2singh <ma...@yahoo.com>
Date: 2017-07-22T02:07:15Z
NIFI-4212 - RethinkDB Delete Processor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2030: NIFI-4212 - RethinkDB Delete Processor
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2030
Thanks for fixing those items, @mans2singh, I'll get this merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2030: NIFI-4212 - RethinkDB Delete Processor
Posted by mans2singh <gi...@git.apache.org>.
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2030
Hi @jvwing - Thanks for your feedback and recommendations.
I used EL support for returning changed document attribute to give the use the flexibility to make the decision globally or per document. If you think this is not useful, I can change it.
You are right about the change document in the attribute and I've removed the related attributes.
Also, I've corrected modify provenance event to be invoked only when the flow file content is changed.
Please let me know if you have any other recommendations.
Thanks again.
Mans
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2030: NIFI-4212 - RethinkDB Delete Processor
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2030
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2030: NIFI-4212 - RethinkDB Delete Processor
Posted by mans2singh <gi...@git.apache.org>.
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2030
Hi @jvwing - Please let me know if you have any other recommendations for this pull request. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2030: NIFI-4212 - RethinkDB Delete Processor
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2030
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2030: NIFI-4212 - RethinkDB Delete Processor
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2030
Overall, this looks good - tests pass, integration tests pass, refactoring of integration test credentials is nice, code looks good. In my basic testing, it deleted objects from RethinkDB just fine. I have a few questions about the **Return old Changes from the delete** option, and how it is processed. I am not very familiar with RethinkDB, so I had to check the [delete docs](https://rethinkdb.com/api/java/delete/) on how it works. I have no practical experience using this option.
* Instead of a true/false dropdown list, you made this a free text field supporting expression language. May I ask why? I think it would be easier to edit if we did, and easier to understand if we made the options more explanatory ("Capture changes as FlowFile content", "Do not capture changes", or something like that).
* If the option is true, the processor writes the changes to the attribute `rethinkdb.delete.changes`, the changes are also contained in the entire raw `attribute rethinkdb.delete.result` attribute, and finally the changes are written to the flowfile content. Do we need all of those?
* In the event that the deleted document is large, the attributes will be large, and potentially unusable due to truncation at 64KB.
* The modify provenance event is reported regardless of this setting. Shouldn't we only do that if a change is made?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2030: NIFI-4212 - RethinkDB Delete Processor
Posted by mans2singh <gi...@git.apache.org>.
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2030
Thanks @jvwing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---