You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "John George (JIRA)" <ji...@apache.org> on 2011/05/04 19:24:03 UTC
[jira] [Created] (HDFS-1889) incorrect path in start/stop dfs
script
incorrect path in start/stop dfs script
---------------------------------------
Key: HDFS-1889
URL: https://issues.apache.org/jira/browse/HDFS-1889
Project: Hadoop HDFS
Issue Type: Bug
Reporter: John George
Assignee: John George
HADOOP_HOME in start-dfs.sh and stop-dfs.sh should be changed to HADOOP_HDFS_HOME because hdfs script is in the hdfs
directory and not common directory
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1889) incorrect path in start/stop dfs
script
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028959#comment-13028959 ]
Hadoop QA commented on HDFS-1889:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12478201/HDFS-1889-1.patch
against trunk revision 1099525.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.namenode.TestBackupNode
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestFileConcurrentReader
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/452//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/452//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/452//console
This message is automatically generated.
> incorrect path in start/stop dfs script
> ---------------------------------------
>
> Key: HDFS-1889
> URL: https://issues.apache.org/jira/browse/HDFS-1889
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Attachments: HDFS-1889-1.patch, HDFS-1889.patch
>
>
> HADOOP_HOME in start-dfs.sh and stop-dfs.sh should be changed to HADOOP_HDFS_HOME because hdfs script is in the hdfs
> directory and not common directory
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1889) incorrect path in start/stop dfs
script
Posted by "John George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HDFS-1889:
------------------------------
Attachment: HDFS-1889.patch
Attaching patch. No tests added since this tests the scripts that start and stop hadoop.
> incorrect path in start/stop dfs script
> ---------------------------------------
>
> Key: HDFS-1889
> URL: https://issues.apache.org/jira/browse/HDFS-1889
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Attachments: HDFS-1889.patch
>
>
> HADOOP_HOME in start-dfs.sh and stop-dfs.sh should be changed to HADOOP_HDFS_HOME because hdfs script is in the hdfs
> directory and not common directory
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1889) incorrect path in start/stop dfs
script
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029051#comment-13029051 ]
Eli Collins commented on HDFS-1889:
-----------------------------------
+1 lgtm. test failures are unrelated.
> incorrect path in start/stop dfs script
> ---------------------------------------
>
> Key: HDFS-1889
> URL: https://issues.apache.org/jira/browse/HDFS-1889
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Fix For: 0.23.0
>
> Attachments: HDFS-1889-1.patch, HDFS-1889.patch
>
>
> HADOOP_HOME in start-dfs.sh and stop-dfs.sh should be changed to HADOOP_HDFS_HOME because hdfs script is in the hdfs
> directory and not common directory
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1889) incorrect path in start/stop dfs
script
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028896#comment-13028896 ]
Hadoop QA commented on HDFS-1889:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12478185/HDFS-1889.patch
against trunk revision 1099525.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/450//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/450//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/450//console
This message is automatically generated.
> incorrect path in start/stop dfs script
> ---------------------------------------
>
> Key: HDFS-1889
> URL: https://issues.apache.org/jira/browse/HDFS-1889
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Attachments: HDFS-1889.patch
>
>
> HADOOP_HOME in start-dfs.sh and stop-dfs.sh should be changed to HADOOP_HDFS_HOME because hdfs script is in the hdfs
> directory and not common directory
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1889) incorrect path in start/stop dfs
script
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028885#comment-13028885 ]
Eli Collins commented on HDFS-1889:
-----------------------------------
Hey John,
I think we need to make this change in a number of places. I think federation added a bunch of uses of HADOOP_HOME that should be HADOOP_HDFS_HOME:
On trunk pre-federation:
{noformat}
hdfs2 (branch-0.22)$ grep -r HADOOP_HOME bin/
bin/hdfs-config.sh:elif [ -d "${HADOOP_HOME}" ]; then
bin/hdfs-config.sh: . "$HADOOP_HOME"/bin/hadoop-config.sh
{noformat}
On trunk:
{noformat}
hdfs2 (branch-0.22)$ c trunk
Switched to branch 'trunk'
hdfs2 (trunk)$ grep -r HADOOP_HOME bin/
bin/hdfs-config.sh:elif [ -d "${HADOOP_HOME}" ]; then
bin/hdfs-config.sh: . "$HADOOP_HOME"/bin/hadoop-config.sh
bin/stop-dfs.sh:NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -namenodes)
bin/stop-dfs.sh:SECONDARY_NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -secondarynamenodes 2>&-)
bin/start-dfs.sh:NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -namenodes)
bin/start-dfs.sh:SECONDARY_NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -secondarynamenodes 2>&-)
bin/refresh-namenodes.sh:namenodes=$("$HADOOP_HOME/bin/hdfs" getconf -namenodes)
bin/refresh-namenodes.sh: "$HADOOP_HOME/bin/hdfs" dfsadmin -refreshNodes
bin/distribute-exclude.sh:namenodes=$("$HADOOP_HOME/bin/hdfs" getconf -namenodes)
bin/distribute-exclude.sh:excludeFilenameRemote=$("$HADOOP_HOME/bin/hdfs" getconf -excludeFile)
{noformat}
> incorrect path in start/stop dfs script
> ---------------------------------------
>
> Key: HDFS-1889
> URL: https://issues.apache.org/jira/browse/HDFS-1889
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Attachments: HDFS-1889.patch
>
>
> HADOOP_HOME in start-dfs.sh and stop-dfs.sh should be changed to HADOOP_HDFS_HOME because hdfs script is in the hdfs
> directory and not common directory
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1889) incorrect path in start/stop dfs
script
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1889:
------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've committed this. Thanks John!
> incorrect path in start/stop dfs script
> ---------------------------------------
>
> Key: HDFS-1889
> URL: https://issues.apache.org/jira/browse/HDFS-1889
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Fix For: 0.23.0
>
> Attachments: HDFS-1889-1.patch, HDFS-1889.patch
>
>
> HADOOP_HOME in start-dfs.sh and stop-dfs.sh should be changed to HADOOP_HDFS_HOME because hdfs script is in the hdfs
> directory and not common directory
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1889) incorrect path in start/stop dfs
script
Posted by "John George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HDFS-1889:
------------------------------
Status: Patch Available (was: Open)
> incorrect path in start/stop dfs script
> ---------------------------------------
>
> Key: HDFS-1889
> URL: https://issues.apache.org/jira/browse/HDFS-1889
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Attachments: HDFS-1889.patch
>
>
> HADOOP_HOME in start-dfs.sh and stop-dfs.sh should be changed to HADOOP_HDFS_HOME because hdfs script is in the hdfs
> directory and not common directory
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1889) incorrect path in start/stop dfs
script
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037327#comment-13037327 ]
Hudson commented on HDFS-1889:
------------------------------
Integrated in Hadoop-Hdfs-trunk #673 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/])
> incorrect path in start/stop dfs script
> ---------------------------------------
>
> Key: HDFS-1889
> URL: https://issues.apache.org/jira/browse/HDFS-1889
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Fix For: 0.23.0
>
> Attachments: HDFS-1889-1.patch, HDFS-1889.patch
>
>
> HADOOP_HOME in start-dfs.sh and stop-dfs.sh should be changed to HADOOP_HDFS_HOME because hdfs script is in the hdfs
> directory and not common directory
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1889) incorrect path in start/stop dfs
script
Posted by "John George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HDFS-1889:
------------------------------
Attachment: HDFS-1889-1.patch
Good point Eli. Changing (reverting to pre- federation) all hdfs/bin directory references from HADOOP_HOME/bin/hdfs to HADOOP_HDFS_HOME/bin/hdfs.
> incorrect path in start/stop dfs script
> ---------------------------------------
>
> Key: HDFS-1889
> URL: https://issues.apache.org/jira/browse/HDFS-1889
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John George
> Assignee: John George
> Attachments: HDFS-1889-1.patch, HDFS-1889.patch
>
>
> HADOOP_HOME in start-dfs.sh and stop-dfs.sh should be changed to HADOOP_HDFS_HOME because hdfs script is in the hdfs
> directory and not common directory
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira