[GitHub] [incubator-doris] wangbo commented on a change in pull request #7855: (optimization)(vectorized) improving Column inserter

[GitBox <gi...@apache.org>]

wangbo commented on a change in pull request #7855:
URL: https://github.com/apache/incubator-doris/pull/7855#discussion_r790435073



##########
File path: be/src/vec/columns/column_vector.h
##########
@@ -120,10 +120,13 @@ class ColumnVector final : public COWHelper<ColumnVectorHelper, ColumnVector<T>>
     ColumnVector(std::initializer_list<T> il) : data {il} {}
 
     void insert_res_column(const uint16_t* sel, size_t sel_size, vectorized::ColumnVector<T>* res_ptr) {
+        auto& res_data = res_ptr->data; 
+        res_data.reserve(res_ptr->size() + sel_size);

Review comment:
       why ```+ sel_size```  here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org