You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "k5342 (via GitHub)" <gi...@apache.org> on 2023/02/08 06:45:35 UTC

[GitHub] [ozone] k5342 commented on a diff in pull request #3842: HDDS-7295. Introduce delimiter-awareness into `KeyIteratorFSO`

k5342 commented on code in PR #3842:
URL: https://github.com/apache/ozone/pull/3842#discussion_r1099721809


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java:
##########
@@ -650,11 +650,12 @@ public long getUsedNamespace() {
    * keys if key prefix is null.
    *
    * @param keyPrefix Bucket prefix to match
+   * @param delimiter A delimiter to group matched keys
    * @return {@code Iterator<OzoneKey>}
    */
-  public Iterator<? extends OzoneKey> listKeys(String keyPrefix)
-      throws IOException {
-    return listKeys(keyPrefix, null);
+  public Iterator<? extends OzoneKey> listKeys(String keyPrefix,
+      String delimiter) throws IOException {
+    return listKeys(keyPrefix, delimiter, null);

Review Comment:
   Hi @DaveTeng0, this change will not change the result for OBS buckets (the delimiter param is ignored for now).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org