You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/21 02:50:24 UTC

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10162: chore: deprecate QueryView (ModelView)

codecov-commenter commented on pull request #10162:
URL: https://github.com/apache/incubator-superset/pull/10162#issuecomment-661590905


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10162?src=pr&el=h1) Report
   > Merging [#10162](https://codecov.io/gh/apache/incubator-superset/pull/10162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73797b8b6406ba9ca54fb603d6bd7a6c92ee4cd9&el=desc) will **increase** coverage by `1.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10162/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10162?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10162      +/-   ##
   ==========================================
   + Coverage   70.63%   71.69%   +1.06%     
   ==========================================
     Files         601      405     -196     
     Lines       32286    13312   -18974     
     Branches     3275     3275              
   ==========================================
   - Hits        22804     9544   -13260     
   + Misses       9376     3662    -5714     
     Partials      106      106              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.63% <ø> (+0.02%)` | :arrow_up: |
   | #javascript | `59.61% <ø> (ø)` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10162?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10162/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10162/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `62.60% <0.00%> (ø)` | |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10162/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | | |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/10162/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | | |
   | [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/10162/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | | |
   | [superset/migrations/env.py](https://codecov.io/gh/apache/incubator-superset/pull/10162/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9lbnYucHk=) | | |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10162/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | | |
   | [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10162/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | | |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10162/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | | |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10162/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | | |
   | ... and [188 more](https://codecov.io/gh/apache/incubator-superset/pull/10162/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10162?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10162?src=pr&el=footer). Last update [73797b8...72c539c](https://codecov.io/gh/apache/incubator-superset/pull/10162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org