You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by pb...@apache.org on 2010/04/22 23:57:37 UTC
svn commit: r937077 - /subversion/trunk/subversion/libsvn_repos/dump.c
Author: pburba
Date: Thu Apr 22 21:57:37 2010
New Revision: 937077
URL: http://svn.apache.org/viewvc?rev=937077&view=rev
Log:
Follow-up to r937033, stop dereferencing an uninitialized pointer when
dumping rev 0.
a.k.a. Stop breaking the entire test suite :-(
* subversion/libsvn_repos/dump.c
(svn_repos_dump_fs3): We never get a dump editor and baton when dumping
r0, so don't assume we have one.
Modified:
subversion/trunk/subversion/libsvn_repos/dump.c
Modified: subversion/trunk/subversion/libsvn_repos/dump.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/dump.c?rev=937077&r1=937076&r2=937077&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_repos/dump.c (original)
+++ subversion/trunk/subversion/libsvn_repos/dump.c Thu Apr 22 21:57:37 2010
@@ -979,7 +979,7 @@ svn_repos_dump_fs3(svn_repos_t *repos,
apr_pool_t *pool)
{
const svn_delta_editor_t *dump_editor;
- void *dump_edit_baton;
+ void *dump_edit_baton = NULL;
svn_revnum_t i;
svn_fs_t *fs = svn_repos_fs(repos);
apr_pool_t *subpool = svn_pool_create(pool);
@@ -1115,7 +1115,8 @@ svn_repos_dump_fs3(svn_repos_t *repos,
if (progress_func)
SVN_ERR(progress_func(progress_baton, to_rev, NULL, subpool));
- if (((struct edit_baton *)dump_edit_baton)->found_old_reference)
+ if (dump_edit_baton /* We never get an edit baton for r0. */
+ && ((struct edit_baton *)dump_edit_baton)->found_old_reference)
found_old_reference = TRUE;
}