You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/08/15 03:33:11 UTC
[kudu-CR] Various comment / doc improvements
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3977
to review the following change.
Change subject: Various comment / doc improvements
......................................................................
Various comment / doc improvements
* Update link to code review for supporting reinsert
* Fix comment in HybridClock header docs
* Improve comment documentation in compaction code
Change-Id: I45d45d265652b0c462aec1bedbcb4b254a2a05da
---
M src/kudu/common/row_changelist.h
M src/kudu/server/hybrid_clock.h
M src/kudu/tablet/delta_compaction.cc
3 files changed, 13 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/3977/1
--
To view, visit http://gerrit.cloudera.org:8080/3977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45d45d265652b0c462aec1bedbcb4b254a2a05da
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Various comment / doc improvements
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Various comment / doc improvements
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3977/1/src/kudu/tablet/delta_compaction.cc
File src/kudu/tablet/delta_compaction.cc:
PS1, Line 182: Any other types of mutations in the compacted columns will
: // now be either UNDO mutations or base data.
> this sentence doesn't make much sense to me -- base data isn't a mutation,
Done
--
To view, visit http://gerrit.cloudera.org:8080/3977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45d45d265652b0c462aec1bedbcb4b254a2a05da
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Various comment / doc improvements
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Various comment / doc improvements
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3977/1/src/kudu/tablet/delta_compaction.cc
File src/kudu/tablet/delta_compaction.cc:
PS1, Line 182: Any other types of mutations in the compacted columns will
: // now be either UNDO mutations or base data.
this sentence doesn't make much sense to me -- base data isn't a mutation, and not sure what "mutations in the compacted columns" really means. Maybe just remove it?
--
To view, visit http://gerrit.cloudera.org:8080/3977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45d45d265652b0c462aec1bedbcb4b254a2a05da
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Various comment / doc improvements
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Various comment / doc improvements
......................................................................
Various comment / doc improvements
* Update link to code review for supporting reinsert
* Fix comment in HybridClock header docs
* Improve comment documentation in compaction code
Change-Id: I45d45d265652b0c462aec1bedbcb4b254a2a05da
Reviewed-on: http://gerrit.cloudera.org:8080/3977
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/common/row_changelist.h
M src/kudu/server/hybrid_clock.h
M src/kudu/tablet/delta_compaction.cc
3 files changed, 12 insertions(+), 9 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45d45d265652b0c462aec1bedbcb4b254a2a05da
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Various comment / doc improvements
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Various comment / doc improvements
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45d45d265652b0c462aec1bedbcb4b254a2a05da
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Various comment / doc improvements
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Various comment / doc improvements
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2902/
--
To view, visit http://gerrit.cloudera.org:8080/3977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45d45d265652b0c462aec1bedbcb4b254a2a05da
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Various comment / doc improvements
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Various comment / doc improvements
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2887/
--
To view, visit http://gerrit.cloudera.org:8080/3977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45d45d265652b0c462aec1bedbcb4b254a2a05da
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Various comment / doc improvements
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Various comment / doc improvements
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/2908/
--
To view, visit http://gerrit.cloudera.org:8080/3977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45d45d265652b0c462aec1bedbcb4b254a2a05da
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Various comment / doc improvements
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3977
to look at the new patch set (#2).
Change subject: Various comment / doc improvements
......................................................................
Various comment / doc improvements
* Update link to code review for supporting reinsert
* Fix comment in HybridClock header docs
* Improve comment documentation in compaction code
Change-Id: I45d45d265652b0c462aec1bedbcb4b254a2a05da
---
M src/kudu/common/row_changelist.h
M src/kudu/server/hybrid_clock.h
M src/kudu/tablet/delta_compaction.cc
3 files changed, 12 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/3977/2
--
To view, visit http://gerrit.cloudera.org:8080/3977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I45d45d265652b0c462aec1bedbcb4b254a2a05da
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>