You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/03/15 03:58:00 UTC
[GitHub] mlampert commented on a change in pull request #910: Common hal for stm32f3
mlampert commented on a change in pull request #910: Common hal for stm32f3
URL: https://github.com/apache/mynewt-core/pull/910#discussion_r174671518
##########
File path: hw/mcu/stm/stm32f3xx/src/hal_flash.c
##########
@@ -127,7 +127,7 @@ stm32f3_flash_dev()
stm32f3_flash_dev_.hf_base_addr = FLASH_BASE;
stm32f3_flash_dev_.hf_size = HAL_FLASH_SIZE;
stm32f3_flash_dev_.hf_sector_cnt = HAL_FLASH_SIZE / HAL_FLASH_SECTOR_SIZE;
- stm32f3_flash_dev_.hf_align = FLASH_PAGE_SIZE;
+ stm32f3_flash_dev_.hf_align = 2;
Review comment:
I'm sure you know what you're doing - I would like to understand as well. Could you explain why the alignment is `2` and doesn't have to be the `FLASH_PAGE_SIZE` please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services