[GitHub] MaxGekk commented on a change in pull request #23406: [SPARK-26504][SQL] Rope-wise dumping of Spark plans

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #23406: [SPARK-26504][SQL] Rope-wise dumping of Spark plans
URL: https://github.com/apache/spark/pull/23406#discussion_r244514501
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
 ##########
 @@ -87,4 +87,28 @@ object StringUtils {
     }
     funcNames.toSeq
   }
+
+  class StringRope {
+    private var list = List.empty[String]
 
 Review comment:
   I supposed reverse is relatively cheap O(n). Coping a string would be more expensive than adding element in the head of list inside of the reverse() method. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org