[GitHub] bolkedebruin commented on a change in pull request #4237: [AIRFLOW-1823] added possibility to send execution date with millisec…

[GitBox <gi...@apache.org>]

bolkedebruin commented on a change in pull request #4237: [AIRFLOW-1823] added possibility to send execution date with millisec…
URL: https://github.com/apache/incubator-airflow/pull/4237#discussion_r236089571
 
 

 ##########
 File path: airflow/www_rbac/api/experimental/endpoints.py
 ##########
 @@ -168,18 +168,21 @@ def task_instance_info(dag_id, execution_date, task_id):
     """
     Returns a JSON with a task instance's public instance variables.
     The format for the exec_date is expected to be
-    "YYYY-mm-DDTHH:MM:SS", for example: "2016-11-16T11:34:15". This will
+    "YYYY-mm-DDTHH:MM:SS", for example: "2016-11-16T11:34:15" or
+    "YYYY-mm-DDTHH:MM:SS.f", for example: "2016-11-16T11:34:15.680399". This will
     of course need to have been encoded for URL in the request.
     """
 
     # Convert string datetime into actual datetime
     try:
-        execution_date = timezone.parse(execution_date)
 
 Review comment:
   You are removing timezone information here and rely on your own parsing mechanism. I don't think that's a good idea?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services