[GitHub] [arrow-rs] kindly commented on a diff in pull request #4120: Retry on all request errors.

["kindly (via GitHub)" <gi...@apache.org>]

kindly commented on code in PR #4120:
URL: https://github.com/apache/arrow-rs/pull/4120#discussion_r1176918637


##########
object_store/src/client/retry.rs:
##########
@@ -192,11 +192,20 @@ impl RetryExt for reqwest::RequestBuilder {
                     },
                     Err(e) =>
                     {
-                        return Err(Error{
-                            retries,
-                            message: "request error".to_string(),
-                            source: Some(e)
-                        })
+                        if retries == max_retries
+                            || now.elapsed() > retry_timeout
+                            || !e.is_request() {

Review Comment:
   @tustvold 
   I have basically done what you have said here.  I added another condition `is_incomplete_message()` which was coming up for me when loading a large file, not on a stable connection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org