You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Arjun Mishra <am...@cloudera.com> on 2017/07/26 14:43:23 UTC
Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query INFO
level logging spams Sentry log files
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61138/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov and Vadim Spector.
Repository: sentry
Description
-------
In the Sentry service, DataNucleus.Query property, when not defined in log4j.properties file, is by default set to INFO. This floods the log files with INFO level logs every few seconds. We should set the default value to WARN to avoid this, unless until specified in the log4j.properties file
Diffs
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java 3a981b2a1
Diff: https://reviews.apache.org/r/61138/diff/1/
Testing
-------
Thanks,
Arjun Mishra
Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query
INFO level logging spams Sentry log files
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61138/#review181458
-----------------------------------------------------------
Ship it!
Ship It!
- kalyan kumar kalvagadda
On July 26, 2017, 2:44 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61138/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 2:44 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> For Sentry HA - In the Sentry service, DataNucleus.Query property, when not defined in log4j.properties file, is by default set to INFO. This floods the log files with INFO level logs every few seconds. We should set the default value to WARN to avoid this, unless until specified in the log4j.properties file
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java 3a981b2a1
>
>
> Diff: https://reviews.apache.org/r/61138/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query
INFO level logging spams Sentry log files
Posted by Arjun Mishra <am...@cloudera.com>.
> On July 26, 2017, 6:47 p.m., Alexander Kolbasov wrote:
> > I think the right way to fix it is by applying SENTRY-1868 rather then modifying DataNucleus debug levels.
Works. I will close this ticket.
- Arjun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61138/#review181477
-----------------------------------------------------------
On July 26, 2017, 2:44 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61138/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 2:44 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> For Sentry HA - In the Sentry service, DataNucleus.Query property, when not defined in log4j.properties file, is by default set to INFO. This floods the log files with INFO level logs every few seconds. We should set the default value to WARN to avoid this, unless until specified in the log4j.properties file
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java 3a981b2a1
>
>
> Diff: https://reviews.apache.org/r/61138/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query
INFO level logging spams Sentry log files
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61138/#review181477
-----------------------------------------------------------
I think the right way to fix it is by applying SENTRY-1868 rather then modifying DataNucleus debug levels.
- Alexander Kolbasov
On July 26, 2017, 2:44 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61138/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 2:44 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> For Sentry HA - In the Sentry service, DataNucleus.Query property, when not defined in log4j.properties file, is by default set to INFO. This floods the log files with INFO level logs every few seconds. We should set the default value to WARN to avoid this, unless until specified in the log4j.properties file
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java 3a981b2a1
>
>
> Diff: https://reviews.apache.org/r/61138/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query
INFO level logging spams Sentry log files
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61138/#review181470
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On July 26, 2017, 2:44 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61138/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 2:44 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> For Sentry HA - In the Sentry service, DataNucleus.Query property, when not defined in log4j.properties file, is by default set to INFO. This floods the log files with INFO level logs every few seconds. We should set the default value to WARN to avoid this, unless until specified in the log4j.properties file
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java 3a981b2a1
>
>
> Diff: https://reviews.apache.org/r/61138/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query
INFO level logging spams Sentry log files
Posted by Mat Crocker <ma...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61138/#review181463
-----------------------------------------------------------
Ship it!
Ship It!
- Mat Crocker
On July 26, 2017, 2:44 p.m., Arjun Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61138/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 2:44 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> For Sentry HA - In the Sentry service, DataNucleus.Query property, when not defined in log4j.properties file, is by default set to INFO. This floods the log files with INFO level logs every few seconds. We should set the default value to WARN to avoid this, unless until specified in the log4j.properties file
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java 3a981b2a1
>
>
> Diff: https://reviews.apache.org/r/61138/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Mishra
>
>
Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query
INFO level logging spams Sentry log files
Posted by Arjun Mishra <am...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61138/
-----------------------------------------------------------
(Updated July 26, 2017, 9:06 p.m.)
Review request for sentry, Alexander Kolbasov and Vadim Spector.
Repository: sentry
Description
-------
For Sentry HA - In the Sentry service, DataNucleus.Query property, when not defined in log4j.properties file, is by default set to INFO. This floods the log files with INFO level logs every few seconds. We should set the default value to WARN to avoid this, unless until specified in the log4j.properties file
Diffs
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java 3a981b2a1
Diff: https://reviews.apache.org/r/61138/diff/1/
Testing (updated)
-------
Closing this review based on Alexander Kolbasov's feedback. This fix will be handled by SENTRY-1868
Thanks,
Arjun Mishra
Re: Review Request 61138: Sentry HA- SENTRY-1867 - DataNucleus.Query
INFO level logging spams Sentry log files
Posted by Arjun Mishra <am...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61138/
-----------------------------------------------------------
(Updated July 26, 2017, 2:44 p.m.)
Review request for sentry, Alexander Kolbasov and Vadim Spector.
Repository: sentry
Description (updated)
-------
For Sentry HA - In the Sentry service, DataNucleus.Query property, when not defined in log4j.properties file, is by default set to INFO. This floods the log files with INFO level logs every few seconds. We should set the default value to WARN to avoid this, unless until specified in the log4j.properties file
Diffs
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java 3a981b2a1
Diff: https://reviews.apache.org/r/61138/diff/1/
Testing
-------
Thanks,
Arjun Mishra