You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/17 13:54:35 UTC

[GitHub] [incubator-nuttx] anchao opened a new pull request, #7121: arch/arm/ac6: add armlink steering file

anchao opened a new pull request, #7121:
URL: https://github.com/apache/incubator-nuttx/pull/7121

   
   
   ## Summary
   
   arch/arm/ac6: add armlink steering file
   
   add armlink steering file to allows nuttx to keep using existing linker symbols defined in scatter and used throughout the code tree.
   
   Reference:
   https://developer.arm.com/documentation/dui0803/a/Accessing-and-managing-symbols-with-armlink/What-is-a-steering-file-
   
   Signed-off-by: chao an <an...@xiaomi.com>
   
   ## Impact
   
   N/A
   
   ## Testing
   
   armlink


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #7121: arch/arm/ac6: add armlink steering file

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #7121: arch/arm/ac6: add armlink steering file
URL: https://github.com/apache/incubator-nuttx/pull/7121


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7121: arch/arm/ac6: add armlink steering file

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7121:
URL: https://github.com/apache/incubator-nuttx/pull/7121#discussion_r973590227


##########
arch/arm/src/Makefile:
##########
@@ -102,8 +102,9 @@ ifeq ($(CONFIG_ARM_TOOLCHAIN_ARMCLANG),)
   SCRIPT_OPT  = -T
 else
   LIBPATH_OPT = --userlibpath
-  EXTRA_LIBS += arm_vectors.o
   SCRIPT_OPT  = --scatter=
+  EXTRA_LIBS += arm_vectors.o arm_link_steering.o

Review Comment:
   remove arm_vectors.o



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7121: arch/arm/ac6: add armlink steering file

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7121:
URL: https://github.com/apache/incubator-nuttx/pull/7121#issuecomment-1255079412

   let's call this since #7165 is more simpler.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7121: arch/arm/ac6: add armlink steering file

Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #7121:
URL: https://github.com/apache/incubator-nuttx/pull/7121#discussion_r973591231


##########
arch/arm/src/Makefile:
##########
@@ -102,8 +102,9 @@ ifeq ($(CONFIG_ARM_TOOLCHAIN_ARMCLANG),)
   SCRIPT_OPT  = -T
 else
   LIBPATH_OPT = --userlibpath
-  EXTRA_LIBS += arm_vectors.o
   SCRIPT_OPT  = --scatter=
+  EXTRA_LIBS += arm_vectors.o arm_link_steering.o

Review Comment:
   arm_vectors.o must be declared on the command line on cortex-m(use vector array), otherwise the following error will occur:
   `Error: L6236E: No section matches selector - no section to be FIRST/LAST.`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org