You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/13 19:04:08 UTC

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29078: [SPARK-29292][STREAMING][SQL][BUILD] Get streaming, catalyst, sql compiling for Scala 2.13

dongjoon-hyun edited a comment on pull request #29078:
URL: https://github.com/apache/spark/pull/29078#issuecomment-657736058


   @srowen .  Interestingly, the root cause of the failure is the following inside `ContinuousMemoryStream`. Can we revert `.map(_.toSeq)` and use a different approach?
   ```scala
     private val records = Seq.fill(numPartitions)(new ListBuffer[UnsafeRow])
   - private val recordEndpoint = new ContinuousRecordEndpoint(records, this)
   + private val recordEndpoint = new ContinuousRecordEndpoint(records.map(_.toSeq), this)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org