[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #12: CASSANDRA-15920 expose client warnings via QueryResult (and its implementations where reasonable)

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #12:
URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/12#discussion_r451174354



##########
File path: src/main/java/org/apache/cassandra/distributed/api/SimpleQueryResult.java
##########
@@ -63,14 +63,21 @@
 {
     private final String[] names;
     private final Object[][] results;
+    private final String[] warnings;
     private final Predicate<Row> filter;
     private final Row row;
     private int offset = -1;
 
     public SimpleQueryResult(String[] names, Object[][] results)
+    {
+        this(names, results, new String[0]);

Review comment:
       may be good to have a constant empty array

##########
File path: src/main/java/org/apache/cassandra/distributed/api/QueryResults.java
##########
@@ -176,6 +176,12 @@ private FilterQueryResult(QueryResult delegate, Predicate<Row> filter)
         {
             return delegate.names();
         }
+        
+        @Override 
+        public List<String> warnings()

Review comment:
       Can we add these to `Builder` as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org