You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/11/30 09:31:02 UTC
Review Request 64201: KYLIN-3073 When you save a new query condition,
the 'Saved Queries' tab page will not be automatically refreshed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64201/
-----------------------------------------------------------
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Bugs: KYLIN-3073
https://issues.apache.org/jira/browse/KYLIN-3073
Repository: kylin
Description
-------
When you save a new query condition, the 'Saved Queries' tab will not be automatically refreshed.
1. Open the 'Insight' page;
2. Choose the 'Saved Queries' tab page, you will see the current page;;
3. Resubmit anyone query, then save it;
4. When you saved it, you will find the 'Saved Queries' tab page will not be automatically refreshed;
5. You should manually refresh it by clicking the 'Saved Queries' tab.
I check the code and find the reason, when closing the 'Save Query' dialog, the code doesn't trigger refreshing 'Saved Queries' tab.
I have repaired this code, please check the patch, thanks!
Diffs
-----
webapp/app/js/controllers/query.js 945ddef
Diff: https://reviews.apache.org/r/64201/diff/1/
Testing
-------
Thanks,
pengjianhua