You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "yzeng1618 (via GitHub)" <gi...@apache.org> on 2026/01/06 08:04:53 UTC

[PR] [Fix][Connector-V2][Hbase] Fix source reader only scanning first split [seatunnel]

yzeng1618 opened a new pull request, #10287:
URL: https://github.com/apache/seatunnel/pull/10287

   Fixes https://github.com/apache/seatunnel/issues/10286
   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   -->
   
   ### Purpose of this pull request
   Fix a correctness issue in `connector-hbase` source: when multiple splits (regions) are assigned, `HbaseSourceReader` could effectively scan only the first split because an exhausted `ResultScanner` was reused for subsequent splits.  
   This PR creates a new `ResultScanner` per split, closes it after scanning, and adds a unit test to prevent regression.  
   A `@VisibleForTesting` constructor is added only to allow injecting a mocked `HbaseClient` in tests; the production behavior is unchanged.
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   
   ### Does this PR introduce _any_ user-facing change?
   Yes. For HBase source, the read count can now correctly include all assigned splits/regions. Previously, the job could finish successfully but read only a fraction of rows.
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
   If no, write 'No'.
   If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
   -->
   
   
   ### How was this patch tested?
   Added unit test: `HbaseSourceReaderTest`
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
   -->
   
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If necessary, please update `incompatible-changes.md` to describe the incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2][Hbase] Fix source reader only scanning first split [seatunnel]

Posted by "yzeng1618 (via GitHub)" <gi...@apache.org>.
yzeng1618 commented on PR #10287:
URL: https://github.com/apache/seatunnel/pull/10287#issuecomment-3713626685

   After-repair Test Results
   <img width="1014" height="663" alt="企业微信截图_17676849392798" src="https://github.com/user-attachments/assets/670d089f-e39c-4a2d-9bf4-3462f7ae84b7" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2][Hbase] Fix source reader only scanning first split [seatunnel]

Posted by "corgy-w (via GitHub)" <gi...@apache.org>.
corgy-w merged PR #10287:
URL: https://github.com/apache/seatunnel/pull/10287


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2][Hbase] Fix source reader only scanning first split [seatunnel]

Posted by "yzeng1618 (via GitHub)" <gi...@apache.org>.
yzeng1618 commented on code in PR #10287:
URL: https://github.com/apache/seatunnel/pull/10287#discussion_r2666845454


##########
seatunnel-connectors-v2/connector-hbase/src/main/java/org/apache/seatunnel/connectors/seatunnel/hbase/source/HbaseSourceReader.java:
##########
@@ -115,14 +129,17 @@ public void pollNext(Collector<SeaTunnelRow> output) throws Exception {
             final HbaseSourceSplit split = sourceSplits.poll();
             if (Objects.nonNull(split)) {
                 // read logic
-                if (currentScanner == null) {
-                    currentScanner = hbaseClient.scan(split, hbaseParameters, this.columnNames);
-                }
-                for (Result result : currentScanner) {
-                    SeaTunnelRow seaTunnelRow =
-                            hbaseDeserializationFormat.deserialize(
-                                    convertRawRow(result), seaTunnelRowType);
-                    output.collect(seaTunnelRow);
+                try (ResultScanner scanner =
+                        hbaseClient.scan(split, hbaseParameters, this.columnNames)) {
+                    currentScanner = scanner;
+                    for (Result result : scanner) {
+                        SeaTunnelRow seaTunnelRow =
+                                hbaseDeserializationFormat.deserialize(
+                                        convertRawRow(result), seaTunnelRowType);
+                        output.collect(seaTunnelRow);
+                    }
+                } finally {
+                    currentScanner = null;
                 }

Review Comment:
   Good catch, the currentScanner field is no longer needed, I removed it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Connector-V2][Hbase] Fix source reader only scanning first split [seatunnel]

Posted by "zhangshenghang (via GitHub)" <gi...@apache.org>.
zhangshenghang commented on code in PR #10287:
URL: https://github.com/apache/seatunnel/pull/10287#discussion_r2664845117


##########
seatunnel-connectors-v2/connector-hbase/src/main/java/org/apache/seatunnel/connectors/seatunnel/hbase/source/HbaseSourceReader.java:
##########
@@ -115,14 +129,17 @@ public void pollNext(Collector<SeaTunnelRow> output) throws Exception {
             final HbaseSourceSplit split = sourceSplits.poll();
             if (Objects.nonNull(split)) {
                 // read logic
-                if (currentScanner == null) {
-                    currentScanner = hbaseClient.scan(split, hbaseParameters, this.columnNames);
-                }
-                for (Result result : currentScanner) {
-                    SeaTunnelRow seaTunnelRow =
-                            hbaseDeserializationFormat.deserialize(
-                                    convertRawRow(result), seaTunnelRowType);
-                    output.collect(seaTunnelRow);
+                try (ResultScanner scanner =
+                        hbaseClient.scan(split, hbaseParameters, this.columnNames)) {
+                    currentScanner = scanner;
+                    for (Result result : scanner) {
+                        SeaTunnelRow seaTunnelRow =
+                                hbaseDeserializationFormat.deserialize(
+                                        convertRawRow(result), seaTunnelRowType);
+                        output.collect(seaTunnelRow);
+                    }
+                } finally {
+                    currentScanner = null;
                 }

Review Comment:
   After modification, the currentScanner field is no longer necessary and can be deleted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org