You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2016/12/15 20:07:59 UTC

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space 

Bharath Vissapragada has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5523

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................

IMPALA-4673: Use --local_library_dir for tzdb startup scratch space

Currently we hardcode the the path to /tmp which may not be
accessible on certain environments.

Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
---
M be/src/exprs/timezone_db.cc
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/5523/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5523/5/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 7076:   TimezoneDatabase::Initialize();
Check the return Status here?

It would be good to add WARN_UNUSED_RESULT to Initialize() as well just to make sure it's not dropped (we should do this in a lot of places but it's good to fix things as we touch them).


-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 4: Code-Review+2

Carrying +2. Thanks Tim for the quick reviews.

-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5523/1/be/src/exprs/timezone_db.cc
File be/src/exprs/timezone_db.cc:

Line 670:   // interface only loads this format from a file.  We don't want to raise
This comment about raising an error is wrong - looks like I missed updating it when I changed this code.


PS1, Line 673: FLAGS_local_library_dir
We should update the command line option info string to reflect that it's now used for an additional purpose.


Line 678:     return Status(Substitute("Could not create temporary timezone file: $0", filestr));
Augment comment to mention --local_library_dir. E.g. "Check that --local_library_dir is writable by Impala".


-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


IMPALA-4673: Use --local_library_dir for tzdb startup scratch space

Currently we hardcode the the path to /tmp which may not be
accessible on certain environments.

Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Reviewed-on: http://gerrit.cloudera.org:8080/5523
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/common/init.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/timezone_db.cc
M be/src/exprs/timezone_db.h
M be/src/runtime/lib-cache.cc
M be/src/service/impalad-main.cc
6 files changed, 20 insertions(+), 10 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Bharath Vissapragada: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Internal Jenkins, Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5523

to look at the new patch set (#6).

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................

IMPALA-4673: Use --local_library_dir for tzdb startup scratch space

Currently we hardcode the the path to /tmp which may not be
accessible on certain environments.

Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
---
M be/src/common/init.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/timezone_db.cc
M be/src/exprs/timezone_db.h
M be/src/runtime/lib-cache.cc
M be/src/service/impalad-main.cc
6 files changed, 20 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/5523/6
-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5523/3/be/src/common/init.cc
File be/src/common/init.cc:

PS3, Line 77: initialinzing
> initializing.
Ouch. Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has uploaded a new patch set (#3).

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................

IMPALA-4673: Use --local_library_dir for tzdb startup scratch space

Currently we hardcode the the path to /tmp which may not be
accessible on certain environments.

Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
---
M be/src/common/init.cc
M be/src/exprs/timezone_db.cc
M be/src/runtime/lib-cache.cc
3 files changed, 15 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/5523/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5523/3/be/src/common/init.cc
File be/src/common/init.cc:

PS3, Line 77: initialinzing
initializing.


-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 6:

Tim, any more comments on this? Can I carry your earlier +2?

-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Internal Jenkins, Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5523

to look at the new patch set (#5).

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................

IMPALA-4673: Use --local_library_dir for tzdb startup scratch space

Currently we hardcode the the path to /tmp which may not be
accessible on certain environments.

Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
---
M be/src/common/init.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/timezone_db.cc
M be/src/runtime/lib-cache.cc
M be/src/service/impalad-main.cc
5 files changed, 19 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/5523/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 4:

Oops I missed this. Lemme check the GVO failures and resubmit. Thanks for asking.

-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 6: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 4:

What's happening here?

-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5523/5/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 7076:   TimezoneDatabase::Initialize();
> Check the return Status here?
Agreed. Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 4:

Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/653/

-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 7:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/413/

-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has uploaded a new patch set (#2).

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................

IMPALA-4673: Use --local_library_dir for tzdb startup scratch space

Currently we hardcode the the path to /tmp which may not be
accessible on certain environments.

Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
---
M be/src/common/init.cc
M be/src/exprs/timezone_db.cc
M be/src/runtime/lib-cache.cc
3 files changed, 14 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/5523/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 5:

Tim, mind taking a quick look at the latest patch?

The problem was that we are init'ing the timezonedb in the InitCommonRuntime(). One of the tests relied on testing a custom local_library_dir was hitting a race in Catalog invoking it, which is not required. It isn't required on the Catalog/SS. I moved it to ImpaladMain().

-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5523/1/be/src/exprs/timezone_db.cc
File be/src/exprs/timezone_db.cc:

Line 670:   // interface only loads this format from a file.  We don't want to raise
> This comment about raising an error is wrong - looks like I missed updating
Done


PS1, Line 673: FLAGS_local_library_dir
> We should update the command line option info string to reflect that it's n
Done. Also moved the DEFINE to init.cc since it isn't specific to lib-cache anymore.


Line 678:     return Status(Substitute("Could not create temporary timezone file: $0", filestr));
> Augment comment to mention --local_library_dir. E.g. "Check that --local_li
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 7: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 4: Verified-1

Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/652/

-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................


Patch Set 7: Code-Review+2

Rebased, carrying +2. Thanks for the review Tim.

-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4673: Use --local library dir for tzdb startup scratch space

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5523

to look at the new patch set (#4).

Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space
......................................................................

IMPALA-4673: Use --local_library_dir for tzdb startup scratch space

Currently we hardcode the the path to /tmp which may not be
accessible on certain environments.

Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
---
M be/src/common/init.cc
M be/src/exprs/timezone_db.cc
M be/src/runtime/lib-cache.cc
3 files changed, 15 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/5523/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>