You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/12 15:38:47 UTC
[GitHub] [flink-kubernetes-operator] mbalassi opened a new pull request, #315: [FLINK-28496] Label selector setting for operator
mbalassi opened a new pull request, #315:
URL: https://github.com/apache/flink-kubernetes-operator/pull/315
## What is the purpose of the change
Adds support for labelselector on Flink custom resources. This enables having multiple operators potentially watch the same namespace for blue/green deployment scenarios. When no selector is set the existing behavior of watching all resources of a namespace is reatined.
## Verifying this change
I have added a test for it verifying that we properly pass the labelselector configuration to JOSDK. Unfortunately the test fails when run together with a specific other test, have to fix this. It might make sense to add an e2e test to cover this too.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changes to the `CustomResourceDescriptors`: (no)
- Core observer or reconciler logic that is regularly executed: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (via the configuration description)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #315: [FLINK-28496] Label selector setting for operator
Posted by GitBox <gi...@apache.org>.
mbalassi merged PR #315:
URL: https://github.com/apache/flink-kubernetes-operator/pull/315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #315: [FLINK-28496] Label selector setting for operator
Posted by GitBox <gi...@apache.org>.
mbalassi commented on code in PR #315:
URL: https://github.com/apache/flink-kubernetes-operator/pull/315#discussion_r921147901
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -233,6 +233,15 @@ public class KubernetesOperatorConfigOptions {
.withDescription(
"Comma separated list of namespaces the operator monitors for custom resources.");
+ @Documentation.Section(SECTION_SYSTEM)
+ public static final ConfigOption<String> OPERATOR_LABEL_SELECTOR =
Review Comment:
Thanks, @SteNicholas. Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #315: [FLINK-28496] Label selector setting for operator
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #315:
URL: https://github.com/apache/flink-kubernetes-operator/pull/315#discussion_r919399982
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -233,6 +233,15 @@ public class KubernetesOperatorConfigOptions {
.withDescription(
"Comma separated list of namespaces the operator monitors for custom resources.");
+ @Documentation.Section(SECTION_SYSTEM)
+ public static final ConfigOption<String> OPERATOR_LABEL_SELECTOR =
Review Comment:
Please run `mvn package -Pgenerate-docs -pl flink-kubernetes-docs -nsu -DskipTests` to generate the config option in the configuration document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org