You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/26 09:00:26 UTC

[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4389: [INLONG-4388][Manager] Change Elasticsearch scaling_factor use correct mapping info

healchow commented on code in PR #4389:
URL: https://github.com/apache/incubator-inlong/pull/4389#discussion_r882466787


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/es/ElasticsearchApi.java:
##########
@@ -133,10 +133,10 @@ private List<String> getMappingInfo(List<ElasticsearchFieldInfo> fieldsInfo) {
                     fieldStr.append(",\n          \"format\" : \"")
                             .append(entry.getFormat()).append("\"");
                 }
-            } else if (entry.getType().contains("float")) {

Review Comment:
   Suggested change the `entry` to `field`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org